Re: [PATCH v2 01/10] iommu/amd: Use struct protection_domain in helper functions

[Jason Gunthorpe <jgg@ziepe.ca>]

On Wed, Aug 16, 2023 at 05:40:22PM +0000, Vasant Hegde wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> To simplify the unnecessary use of container_of() on the struct
> iommu_domain to get the container structure.
> 
> No functional changes intended.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Co-developed-by: Vasant Hegde <vasant.hegde@amd.com>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
>  drivers/iommu/amd/amd_iommu.h     | 13 +++++++++----
>  drivers/iommu/amd/io_pgtable_v2.c |  8 ++++----
>  drivers/iommu/amd/iommu.c         | 18 ++++--------------
>  3 files changed, 17 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/iommu/amd/amd_iommu.h b/drivers/iommu/amd/amd_iommu.h
> index 8b586effbefc..87739d95ea8b 100644
> --- a/drivers/iommu/amd/amd_iommu.h
> +++ b/drivers/iommu/amd/amd_iommu.h
> @@ -55,15 +55,15 @@ int amd_iommu_pc_set_reg(struct amd_iommu *iommu, u8 bank, u8 cntr,
>  int amd_iommu_pdev_enable_cap_pri(struct pci_dev *pdev);
>  void amd_iommu_pdev_disable_cap_pri(struct pci_dev *pdev);
>  
> -int amd_iommu_flush_page(struct iommu_domain *dom, u32 pasid, u64 address);
> +int amd_iommu_flush_page(struct protection_domain *domain, u32 pasid, u64 address);
>  void amd_iommu_update_and_flush_device_table(struct protection_domain *domain);
>  void amd_iommu_domain_update(struct protection_domain *domain);
>  void amd_iommu_domain_flush_complete(struct protection_domain *domain);
>  void amd_iommu_domain_flush_tlb_pde(struct protection_domain *domain);
> -int amd_iommu_flush_tlb(struct iommu_domain *dom, u32 pasid);
> -int amd_iommu_domain_set_gcr3(struct iommu_domain *dom, u32 pasid,
> +int amd_iommu_flush_tlb(struct protection_domain *domain, u32 pasid);
> +int amd_iommu_domain_set_gcr3(struct protection_domain *domain, u32 pasid,
>  			      unsigned long cr3);
> -int amd_iommu_domain_clear_gcr3(struct iommu_domain *dom, u32 pasid);
> +int amd_iommu_domain_clear_gcr3(struct protection_domain *domain, u32 pasid);
>  
>  #ifdef CONFIG_IRQ_REMAP
>  int amd_iommu_create_irq_domain(struct amd_iommu *iommu);
> @@ -147,6 +147,11 @@ static inline void *alloc_pgtable_page(int nid, gfp_t gfp)
>  	return page ? page_address(page) : NULL;
>  }
>  
> +static inline struct protection_domain *to_pdomain(struct iommu_domain *dom)
> +{
> +	return container_of(dom, struct protection_domain, domain);
> +}
> +

The change looks fine, but why did this patch move this into a header?

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason