* [PATCH] kselftest: missing arg in ptrace.c
@ 2024-07-12 23:17 Remington Brasga
2024-07-15 2:50 ` Anshuman Khandual
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Remington Brasga @ 2024-07-12 23:17 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Shuah Khan
Cc: linux-arm-kernel, linux-kselftest, linux-kernel,
linux-kernel-mentees, Remington Brasga
The string passed to ksft_test_result_skip is missing the `type_name`
Signed-off-by: Remington Brasga <rbrasga@uci.edu>
---
clang-tidy reported clang-diagnostic-format-insufficient-args warning
on this line, so I am fixing it.
tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
index abe4d58d731d..6144f83f8ab4 100644
--- a/tools/testing/selftests/arm64/abi/ptrace.c
+++ b/tools/testing/selftests/arm64/abi/ptrace.c
@@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
/* Zero is not currently architecturally valid */
ksft_test_result(arch, "%s_arch_set\n", type_name);
} else {
- ksft_test_result_skip("%s_arch_set\n");
+ ksft_test_result_skip("%s_arch_set\n", type_name);
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] kselftest: missing arg in ptrace.c
2024-07-12 23:17 [PATCH] kselftest: missing arg in ptrace.c Remington Brasga
@ 2024-07-15 2:50 ` Anshuman Khandual
2024-07-15 12:02 ` Dev Jain
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Anshuman Khandual @ 2024-07-15 2:50 UTC (permalink / raw)
To: Remington Brasga, Catalin Marinas, Will Deacon, Shuah Khan
Cc: linux-arm-kernel, linux-kselftest, linux-kernel,
linux-kernel-mentees
On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> ---
> clang-tidy reported clang-diagnostic-format-insufficient-args warning
> on this line, so I am fixing it.
>
> tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index abe4d58d731d..6144f83f8ab4 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> /* Zero is not currently architecturally valid */
> ksft_test_result(arch, "%s_arch_set\n", type_name);
> } else {
> - ksft_test_result_skip("%s_arch_set\n");
> + ksft_test_result_skip("%s_arch_set\n", type_name);
> }
> }
>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kselftest: missing arg in ptrace.c
2024-07-12 23:17 [PATCH] kselftest: missing arg in ptrace.c Remington Brasga
2024-07-15 2:50 ` Anshuman Khandual
@ 2024-07-15 12:02 ` Dev Jain
2024-07-16 4:19 ` Dev Jain
2024-07-23 15:46 ` Will Deacon
3 siblings, 0 replies; 7+ messages in thread
From: Dev Jain @ 2024-07-15 12:02 UTC (permalink / raw)
To: Remington Brasga, Catalin Marinas, Will Deacon, Shuah Khan
Cc: linux-arm-kernel, linux-kselftest, linux-kernel,
linux-kernel-mentees
On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga@uci.edu>
Reviewed-by: Dev Jain <dev.jain@arm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kselftest: missing arg in ptrace.c
2024-07-12 23:17 [PATCH] kselftest: missing arg in ptrace.c Remington Brasga
2024-07-15 2:50 ` Anshuman Khandual
2024-07-15 12:02 ` Dev Jain
@ 2024-07-16 4:19 ` Dev Jain
2024-07-18 15:34 ` Will Deacon
2024-07-23 15:46 ` Will Deacon
3 siblings, 1 reply; 7+ messages in thread
From: Dev Jain @ 2024-07-16 4:19 UTC (permalink / raw)
To: Remington Brasga, Catalin Marinas, Will Deacon, Shuah Khan
Cc: linux-arm-kernel, linux-kselftest, linux-kernel,
linux-kernel-mentees, Anshuman.Khandual, Mark Brown, Ryan Roberts
On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> ---
> clang-tidy reported clang-diagnostic-format-insufficient-args warning
> on this line, so I am fixing it.
>
> tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index abe4d58d731d..6144f83f8ab4 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> /* Zero is not currently architecturally valid */
> ksft_test_result(arch, "%s_arch_set\n", type_name);
> } else {
> - ksft_test_result_skip("%s_arch_set\n");
> + ksft_test_result_skip("%s_arch_set\n", type_name);
> }
> }
Okay, I almost forgot that I had a patch fixing this as part of another series:
https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
If that is OK, Will, can you please pull that? Or should I send that as a
separate patch?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kselftest: missing arg in ptrace.c
2024-07-16 4:19 ` Dev Jain
@ 2024-07-18 15:34 ` Will Deacon
2024-07-23 14:26 ` Will Deacon
0 siblings, 1 reply; 7+ messages in thread
From: Will Deacon @ 2024-07-18 15:34 UTC (permalink / raw)
To: Dev Jain
Cc: Remington Brasga, Catalin Marinas, Shuah Khan, linux-arm-kernel,
linux-kselftest, linux-kernel, linux-kernel-mentees,
Anshuman.Khandual, Mark Brown, Ryan Roberts
On Tue, Jul 16, 2024 at 09:49:12AM +0530, Dev Jain wrote:
>
> On 7/13/24 04:47, Remington Brasga wrote:
> > The string passed to ksft_test_result_skip is missing the `type_name`
> >
> > Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> > ---
> > clang-tidy reported clang-diagnostic-format-insufficient-args warning
> > on this line, so I am fixing it.
> >
> > tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> > index abe4d58d731d..6144f83f8ab4 100644
> > --- a/tools/testing/selftests/arm64/abi/ptrace.c
> > +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> > @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> > /* Zero is not currently architecturally valid */
> > ksft_test_result(arch, "%s_arch_set\n", type_name);
> > } else {
> > - ksft_test_result_skip("%s_arch_set\n");
> > + ksft_test_result_skip("%s_arch_set\n", type_name);
> > }
> > }
>
> Okay, I almost forgot that I had a patch fixing this as part of another series:
> https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
> If that is OK, Will, can you please pull that? Or should I send that as a
> separate patch?
I think Mark already suggested sending that separately:
| This should ideally be a separate patch, there's no overlap.
and he's right: it's best to keep fixes and features separate.
Will
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kselftest: missing arg in ptrace.c
2024-07-18 15:34 ` Will Deacon
@ 2024-07-23 14:26 ` Will Deacon
0 siblings, 0 replies; 7+ messages in thread
From: Will Deacon @ 2024-07-23 14:26 UTC (permalink / raw)
To: Dev Jain
Cc: Remington Brasga, Catalin Marinas, Shuah Khan, linux-arm-kernel,
linux-kselftest, linux-kernel, linux-kernel-mentees,
Anshuman.Khandual, Mark Brown, Ryan Roberts
On Thu, Jul 18, 2024 at 04:34:10PM +0100, Will Deacon wrote:
> On Tue, Jul 16, 2024 at 09:49:12AM +0530, Dev Jain wrote:
> >
> > On 7/13/24 04:47, Remington Brasga wrote:
> > > The string passed to ksft_test_result_skip is missing the `type_name`
> > >
> > > Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> > > ---
> > > clang-tidy reported clang-diagnostic-format-insufficient-args warning
> > > on this line, so I am fixing it.
> > >
> > > tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> > > index abe4d58d731d..6144f83f8ab4 100644
> > > --- a/tools/testing/selftests/arm64/abi/ptrace.c
> > > +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> > > @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> > > /* Zero is not currently architecturally valid */
> > > ksft_test_result(arch, "%s_arch_set\n", type_name);
> > > } else {
> > > - ksft_test_result_skip("%s_arch_set\n");
> > > + ksft_test_result_skip("%s_arch_set\n", type_name);
> > > }
> > > }
> >
> > Okay, I almost forgot that I had a patch fixing this as part of another series:
> > https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
> > If that is OK, Will, can you please pull that? Or should I send that as a
> > separate patch?
>
> I think Mark already suggested sending that separately:
>
> | This should ideally be a separate patch, there's no overlap.
>
> and he's right: it's best to keep fixes and features separate.
I didn't spot a patch from you, so I'm going to pick this one up instead.
Will
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kselftest: missing arg in ptrace.c
2024-07-12 23:17 [PATCH] kselftest: missing arg in ptrace.c Remington Brasga
` (2 preceding siblings ...)
2024-07-16 4:19 ` Dev Jain
@ 2024-07-23 15:46 ` Will Deacon
3 siblings, 0 replies; 7+ messages in thread
From: Will Deacon @ 2024-07-23 15:46 UTC (permalink / raw)
To: Catalin Marinas, Shuah Khan, Remington Brasga
Cc: kernel-team, Will Deacon, linux-arm-kernel, linux-kselftest,
linux-kernel, linux-kernel-mentees
On Fri, 12 Jul 2024 23:17:30 +0000, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
>
Applied to arm64 (for-next/core), thanks!
[1/1] kselftest: missing arg in ptrace.c
https://git.kernel.org/arm64/c/0c35e3bd412a
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-23 15:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-12 23:17 [PATCH] kselftest: missing arg in ptrace.c Remington Brasga
2024-07-15 2:50 ` Anshuman Khandual
2024-07-15 12:02 ` Dev Jain
2024-07-16 4:19 ` Dev Jain
2024-07-18 15:34 ` Will Deacon
2024-07-23 14:26 ` Will Deacon
2024-07-23 15:46 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox