Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: linuxram at us.ibm.com (Ram Pai)
Subject: [Linux-kselftest-mirror] [PATCH v10 09/27] powerpc: ability to create execute-disabled pkeys
Date: Thu, 18 Jan 2018 17:50:30 -0800	[thread overview]
Message-ID: <1516326648-22775-10-git-send-email-linuxram@us.ibm.com> (raw)
In-Reply-To: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com>

powerpc has hardware support to disable execute on a pkey.
This patch enables the ability to create execute-disabled
keys.

Signed-off-by: Ram Pai <linuxram at us.ibm.com>
---
 arch/powerpc/include/uapi/asm/mman.h |    6 ++++++
 arch/powerpc/mm/pkeys.c              |   16 ++++++++++++++++
 2 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/include/uapi/asm/mman.h b/arch/powerpc/include/uapi/asm/mman.h
index e63bc37..65065ce 100644
--- a/arch/powerpc/include/uapi/asm/mman.h
+++ b/arch/powerpc/include/uapi/asm/mman.h
@@ -30,4 +30,10 @@
 #define MAP_STACK	0x20000		/* give out an address that is best suited for process/thread stacks */
 #define MAP_HUGETLB	0x40000		/* create a huge page mapping */
 
+/* Override any generic PKEY permission defines */
+#define PKEY_DISABLE_EXECUTE   0x4
+#undef PKEY_ACCESS_MASK
+#define PKEY_ACCESS_MASK       (PKEY_DISABLE_ACCESS |\
+				PKEY_DISABLE_WRITE  |\
+				PKEY_DISABLE_EXECUTE)
 #endif /* _UAPI_ASM_POWERPC_MMAN_H */
diff --git a/arch/powerpc/mm/pkeys.c b/arch/powerpc/mm/pkeys.c
index eca04cd..39e9814 100644
--- a/arch/powerpc/mm/pkeys.c
+++ b/arch/powerpc/mm/pkeys.c
@@ -29,6 +29,14 @@ int pkey_initialize(void)
 	int os_reserved, i;
 
 	/*
+	 * We define PKEY_DISABLE_EXECUTE in addition to the arch-neutral
+	 * generic defines for PKEY_DISABLE_ACCESS and PKEY_DISABLE_WRITE.
+	 * Ensure that the bits a distinct.
+	 */
+	BUILD_BUG_ON(PKEY_DISABLE_EXECUTE &
+		     (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE));
+
+	/*
 	 * Disable the pkey system till everything is in place. A subsequent
 	 * patch will enable it.
 	 */
@@ -181,10 +189,18 @@ int __arch_set_user_pkey_access(struct task_struct *tsk, int pkey,
 				unsigned long init_val)
 {
 	u64 new_amr_bits = 0x0ul;
+	u64 new_iamr_bits = 0x0ul;
 
 	if (!is_pkey_enabled(pkey))
 		return -EINVAL;
 
+	if (init_val & PKEY_DISABLE_EXECUTE) {
+		if (!pkey_execute_disable_supported)
+			return -EINVAL;
+		new_iamr_bits |= IAMR_EX_BIT;
+	}
+	init_iamr(pkey, new_iamr_bits);
+
 	/* Set the bits we need in AMR: */
 	if (init_val & PKEY_DISABLE_ACCESS)
 		new_amr_bits |= AMR_RD_BIT | AMR_WR_BIT;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: linuxram@us.ibm.com (Ram Pai)
Subject: [Linux-kselftest-mirror] [PATCH v10 09/27] powerpc: ability to create execute-disabled pkeys
Date: Thu, 18 Jan 2018 17:50:30 -0800	[thread overview]
Message-ID: <1516326648-22775-10-git-send-email-linuxram@us.ibm.com> (raw)
Message-ID: <20180119015030.VCU2Gc0Dfxtie7wx99SonJs7xpdhjG6yx_1CleI8jWM@z> (raw)
In-Reply-To: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com>

powerpc has hardware support to disable execute on a pkey.
This patch enables the ability to create execute-disabled
keys.

Signed-off-by: Ram Pai <linuxram at us.ibm.com>
---
 arch/powerpc/include/uapi/asm/mman.h |    6 ++++++
 arch/powerpc/mm/pkeys.c              |   16 ++++++++++++++++
 2 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/include/uapi/asm/mman.h b/arch/powerpc/include/uapi/asm/mman.h
index e63bc37..65065ce 100644
--- a/arch/powerpc/include/uapi/asm/mman.h
+++ b/arch/powerpc/include/uapi/asm/mman.h
@@ -30,4 +30,10 @@
 #define MAP_STACK	0x20000		/* give out an address that is best suited for process/thread stacks */
 #define MAP_HUGETLB	0x40000		/* create a huge page mapping */
 
+/* Override any generic PKEY permission defines */
+#define PKEY_DISABLE_EXECUTE   0x4
+#undef PKEY_ACCESS_MASK
+#define PKEY_ACCESS_MASK       (PKEY_DISABLE_ACCESS |\
+				PKEY_DISABLE_WRITE  |\
+				PKEY_DISABLE_EXECUTE)
 #endif /* _UAPI_ASM_POWERPC_MMAN_H */
diff --git a/arch/powerpc/mm/pkeys.c b/arch/powerpc/mm/pkeys.c
index eca04cd..39e9814 100644
--- a/arch/powerpc/mm/pkeys.c
+++ b/arch/powerpc/mm/pkeys.c
@@ -29,6 +29,14 @@ int pkey_initialize(void)
 	int os_reserved, i;
 
 	/*
+	 * We define PKEY_DISABLE_EXECUTE in addition to the arch-neutral
+	 * generic defines for PKEY_DISABLE_ACCESS and PKEY_DISABLE_WRITE.
+	 * Ensure that the bits a distinct.
+	 */
+	BUILD_BUG_ON(PKEY_DISABLE_EXECUTE &
+		     (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE));
+
+	/*
 	 * Disable the pkey system till everything is in place. A subsequent
 	 * patch will enable it.
 	 */
@@ -181,10 +189,18 @@ int __arch_set_user_pkey_access(struct task_struct *tsk, int pkey,
 				unsigned long init_val)
 {
 	u64 new_amr_bits = 0x0ul;
+	u64 new_iamr_bits = 0x0ul;
 
 	if (!is_pkey_enabled(pkey))
 		return -EINVAL;
 
+	if (init_val & PKEY_DISABLE_EXECUTE) {
+		if (!pkey_execute_disable_supported)
+			return -EINVAL;
+		new_iamr_bits |= IAMR_EX_BIT;
+	}
+	init_iamr(pkey, new_iamr_bits);
+
 	/* Set the bits we need in AMR: */
 	if (init_val & PKEY_DISABLE_ACCESS)
 		new_amr_bits |= AMR_RD_BIT | AMR_WR_BIT;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-01-19  1:50 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  1:50 [Linux-kselftest-mirror] [PATCH v10 00/27] powerpc, mm: Memory Protection Keys linuxram
2018-01-19  1:50 ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 01/27] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-21 15:34   ` aneesh.kumar
2018-01-21 15:34     ` Aneesh Kumar K.V
2018-01-23  6:37   ` linuxram
2018-01-23  6:37     ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 02/27] mm, powerpc, x86: introduce an additional vma bit for powerpc pkey linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 03/27] powerpc: initial pkey plumbing linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-22  3:34   ` [Linux-kselftest-mirror] [v10, " patch-notifications
2018-01-22  3:34     ` Michael Ellerman
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 04/27] powerpc: track allocation status of all pkeys linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 05/27] powerpc: helper function to read, write AMR, IAMR, UAMOR registers linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 06/27] powerpc: helper functions to initialize AMR, IAMR and " linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 07/27] powerpc: cleanup AMR, IAMR when a key is allocated or freed linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 08/27] powerpc: implementation for arch_set_user_pkey_access() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` linuxram [this message]
2018-01-19  1:50   ` [Linux-kselftest-mirror] [PATCH v10 09/27] powerpc: ability to create execute-disabled pkeys Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 10/27] powerpc: store and restore the pkey state across context switches linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 11/27] powerpc: introduce execute-only pkey linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 12/27] powerpc: ability to associate pkey to a vma linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 13/27] powerpc: implementation for arch_override_mprotect_pkey() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 14/27] powerpc: map vma key-protection bits to pte key bits linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 15/27] powerpc: Program HPTE key protection bits linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 16/27] powerpc: helper to validate key-access permissions of a pte linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 17/27] powerpc: check key protection for user page access linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 18/27] powerpc: implementation for arch_vma_access_permitted() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 19/27] powerpc: Handle exceptions caused by pkey violation linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 20/27] powerpc: introduce get_mm_addr_key() helper linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 21/27] powerpc: Deliver SEGV signal on pkey violation linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 22/27] powerpc/ptrace: Add memory protection key regset linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 23/27] powerpc: Enable pkey subsystem linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 24/27] powerpc: sys_pkey_alloc() and sys_pkey_free() system calls linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 25/27] powerpc: sys_pkey_mprotect() system call linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 26/27] mm, x86 : introduce arch_pkeys_enabled() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 27/27] mm: display pkey in smaps if arch_pkeys_enabled() is true linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19 16:09   ` ebiederm
2018-01-19 16:09     ` Eric W. Biederman
2018-01-19 16:50     ` linuxram
2018-01-19 16:50       ` Ram Pai
2018-01-19 17:04       ` ebiederm
2018-01-19 17:04         ` Eric W. Biederman
2018-01-30 12:16   ` mhocko
2018-01-30 12:16     ` Michal Hocko
2018-01-30 16:28     ` linuxram
2018-01-30 16:28       ` Ram Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516326648-22775-10-git-send-email-linuxram@us.ibm.com \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox