Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: linuxram at us.ibm.com (Ram Pai)
Subject: [Linux-kselftest-mirror] [PATCH v10 02/27] mm, powerpc, x86: introduce an additional vma bit for powerpc pkey
Date: Thu, 18 Jan 2018 17:50:23 -0800	[thread overview]
Message-ID: <1516326648-22775-3-git-send-email-linuxram@us.ibm.com> (raw)
In-Reply-To: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com>

Currently only 4bits are allocated in the vma flags to hold 16
keys. This is sufficient for x86. PowerPC  supports  32  keys,
which needs 5bits. This patch allocates an  additional bit.

Acked-by: Balbir Singh <bsingharora at gmail.com>
Signed-off-by: Ram Pai <linuxram at us.ibm.com>
---
 fs/proc/task_mmu.c |    1 +
 include/linux/mm.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index b139617..0edd4da 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -680,6 +680,7 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
 		[ilog2(VM_PKEY_BIT1)]	= "",
 		[ilog2(VM_PKEY_BIT2)]	= "",
 		[ilog2(VM_PKEY_BIT3)]	= "",
+		[ilog2(VM_PKEY_BIT4)]	= "",
 #endif /* CONFIG_ARCH_HAS_PKEYS */
 	};
 	size_t i;
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 01381d3..ebcb997 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -231,9 +231,10 @@ extern int overcommit_kbytes_handler(struct ctl_table *, int, void __user *,
 #ifdef CONFIG_ARCH_HAS_PKEYS
 # define VM_PKEY_SHIFT	VM_HIGH_ARCH_BIT_0
 # define VM_PKEY_BIT0	VM_HIGH_ARCH_0	/* A protection key is a 4-bit value */
-# define VM_PKEY_BIT1	VM_HIGH_ARCH_1
+# define VM_PKEY_BIT1	VM_HIGH_ARCH_1	/* on x86 and 5-bit value on ppc64   */
 # define VM_PKEY_BIT2	VM_HIGH_ARCH_2
 # define VM_PKEY_BIT3	VM_HIGH_ARCH_3
+# define VM_PKEY_BIT4	VM_HIGH_ARCH_4
 #endif /* CONFIG_ARCH_HAS_PKEYS */
 
 #if defined(CONFIG_X86)
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: linuxram@us.ibm.com (Ram Pai)
Subject: [Linux-kselftest-mirror] [PATCH v10 02/27] mm, powerpc, x86: introduce an additional vma bit for powerpc pkey
Date: Thu, 18 Jan 2018 17:50:23 -0800	[thread overview]
Message-ID: <1516326648-22775-3-git-send-email-linuxram@us.ibm.com> (raw)
Message-ID: <20180119015023.L9o3yC9xS0_lx0Zew4qXAzqOr2sc_j6Iq5Itm8K6c2A@z> (raw)
In-Reply-To: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com>

Currently only 4bits are allocated in the vma flags to hold 16
keys. This is sufficient for x86. PowerPC  supports  32  keys,
which needs 5bits. This patch allocates an  additional bit.

Acked-by: Balbir Singh <bsingharora at gmail.com>
Signed-off-by: Ram Pai <linuxram at us.ibm.com>
---
 fs/proc/task_mmu.c |    1 +
 include/linux/mm.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index b139617..0edd4da 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -680,6 +680,7 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
 		[ilog2(VM_PKEY_BIT1)]	= "",
 		[ilog2(VM_PKEY_BIT2)]	= "",
 		[ilog2(VM_PKEY_BIT3)]	= "",
+		[ilog2(VM_PKEY_BIT4)]	= "",
 #endif /* CONFIG_ARCH_HAS_PKEYS */
 	};
 	size_t i;
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 01381d3..ebcb997 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -231,9 +231,10 @@ extern int overcommit_kbytes_handler(struct ctl_table *, int, void __user *,
 #ifdef CONFIG_ARCH_HAS_PKEYS
 # define VM_PKEY_SHIFT	VM_HIGH_ARCH_BIT_0
 # define VM_PKEY_BIT0	VM_HIGH_ARCH_0	/* A protection key is a 4-bit value */
-# define VM_PKEY_BIT1	VM_HIGH_ARCH_1
+# define VM_PKEY_BIT1	VM_HIGH_ARCH_1	/* on x86 and 5-bit value on ppc64   */
 # define VM_PKEY_BIT2	VM_HIGH_ARCH_2
 # define VM_PKEY_BIT3	VM_HIGH_ARCH_3
+# define VM_PKEY_BIT4	VM_HIGH_ARCH_4
 #endif /* CONFIG_ARCH_HAS_PKEYS */
 
 #if defined(CONFIG_X86)
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-01-19  1:50 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  1:50 [Linux-kselftest-mirror] [PATCH v10 00/27] powerpc, mm: Memory Protection Keys linuxram
2018-01-19  1:50 ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 01/27] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-21 15:34   ` aneesh.kumar
2018-01-21 15:34     ` Aneesh Kumar K.V
2018-01-23  6:37   ` linuxram
2018-01-23  6:37     ` Ram Pai
2018-01-19  1:50 ` linuxram [this message]
2018-01-19  1:50   ` [Linux-kselftest-mirror] [PATCH v10 02/27] mm, powerpc, x86: introduce an additional vma bit for powerpc pkey Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 03/27] powerpc: initial pkey plumbing linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-22  3:34   ` [Linux-kselftest-mirror] [v10, " patch-notifications
2018-01-22  3:34     ` Michael Ellerman
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 04/27] powerpc: track allocation status of all pkeys linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 05/27] powerpc: helper function to read, write AMR, IAMR, UAMOR registers linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 06/27] powerpc: helper functions to initialize AMR, IAMR and " linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 07/27] powerpc: cleanup AMR, IAMR when a key is allocated or freed linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 08/27] powerpc: implementation for arch_set_user_pkey_access() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 09/27] powerpc: ability to create execute-disabled pkeys linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 10/27] powerpc: store and restore the pkey state across context switches linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 11/27] powerpc: introduce execute-only pkey linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 12/27] powerpc: ability to associate pkey to a vma linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 13/27] powerpc: implementation for arch_override_mprotect_pkey() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 14/27] powerpc: map vma key-protection bits to pte key bits linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 15/27] powerpc: Program HPTE key protection bits linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 16/27] powerpc: helper to validate key-access permissions of a pte linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 17/27] powerpc: check key protection for user page access linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 18/27] powerpc: implementation for arch_vma_access_permitted() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 19/27] powerpc: Handle exceptions caused by pkey violation linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 20/27] powerpc: introduce get_mm_addr_key() helper linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 21/27] powerpc: Deliver SEGV signal on pkey violation linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 22/27] powerpc/ptrace: Add memory protection key regset linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 23/27] powerpc: Enable pkey subsystem linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 24/27] powerpc: sys_pkey_alloc() and sys_pkey_free() system calls linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 25/27] powerpc: sys_pkey_mprotect() system call linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 26/27] mm, x86 : introduce arch_pkeys_enabled() linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19  1:50 ` [Linux-kselftest-mirror] [PATCH v10 27/27] mm: display pkey in smaps if arch_pkeys_enabled() is true linuxram
2018-01-19  1:50   ` Ram Pai
2018-01-19 16:09   ` ebiederm
2018-01-19 16:09     ` Eric W. Biederman
2018-01-19 16:50     ` linuxram
2018-01-19 16:50       ` Ram Pai
2018-01-19 17:04       ` ebiederm
2018-01-19 17:04         ` Eric W. Biederman
2018-01-30 12:16   ` mhocko
2018-01-30 12:16     ` Michal Hocko
2018-01-30 16:28     ` linuxram
2018-01-30 16:28       ` Ram Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516326648-22775-3-git-send-email-linuxram@us.ibm.com \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox