[PATCH net 3/4] net/udpgso_bench_tx: fix sendmmsg on unconnected socket

public inbox for linux-kselftest@vger.kernel.org
 help / color / mirror / Atom feed

From: fklassen at appneta.com (Fred Klassen)
Subject: [PATCH net 3/4] net/udpgso_bench_tx: fix sendmmsg on unconnected socket
Date: Thu, 23 May 2019 14:06:50 -0700	[thread overview]
Message-ID: <20190523210651.80902-4-fklassen@appneta.com> (raw)
In-Reply-To: <20190523210651.80902-1-fklassen@appneta.com>

Fixes the following error if using both -m and -u options:

    # ./udpgso_bench -4um -D 172.16.120.189
    ./udpgso_bench: sendmmsg: Destination address required

Fixes: 3a687bef148d ("selftests: udp gso benchmark")
Signed-off-by: Fred Klassen <fklassen at appneta.com>
---
 tools/testing/selftests/net/udpgso_bench_tx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/net/udpgso_bench_tx.c b/tools/testing/selftests/net/udpgso_bench_tx.c
index a900f016b9e7..56e0d890b066 100644
--- a/tools/testing/selftests/net/udpgso_bench_tx.c
+++ b/tools/testing/selftests/net/udpgso_bench_tx.c
@@ -378,6 +378,8 @@ static int send_udp_sendmmsg(int fd, char *data)
 
 		mmsgs[i].msg_hdr.msg_iov = iov + i;
 		mmsgs[i].msg_hdr.msg_iovlen = 1;
+		mmsgs[i].msg_hdr.msg_name = (void *)&cfg_dst_addr;
+		mmsgs[i].msg_hdr.msg_namelen = cfg_alen;
 		if (msg_controllen) {
 			mmsgs[i].msg_hdr.msg_control = control;
 			mmsgs[i].msg_hdr.msg_controllen = msg_controllen;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)

From: fklassen@appneta.com (Fred Klassen)
Subject: [PATCH net 3/4] net/udpgso_bench_tx: fix sendmmsg on unconnected socket
Date: Thu, 23 May 2019 14:06:50 -0700	[thread overview]
Message-ID: <20190523210651.80902-4-fklassen@appneta.com> (raw)
Message-ID: <20190523210650.S0dduIxokrNWQN3remSHNxQKsSmyZedQO_q0Jp_Q9p4@z> (raw)
In-Reply-To: <20190523210651.80902-1-fklassen@appneta.com>

Fixes the following error if using both -m and -u options:

    # ./udpgso_bench -4um -D 172.16.120.189
    ./udpgso_bench: sendmmsg: Destination address required

Fixes: 3a687bef148d ("selftests: udp gso benchmark")
Signed-off-by: Fred Klassen <fklassen at appneta.com>
---
 tools/testing/selftests/net/udpgso_bench_tx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/net/udpgso_bench_tx.c b/tools/testing/selftests/net/udpgso_bench_tx.c
index a900f016b9e7..56e0d890b066 100644
--- a/tools/testing/selftests/net/udpgso_bench_tx.c
+++ b/tools/testing/selftests/net/udpgso_bench_tx.c
@@ -378,6 +378,8 @@ static int send_udp_sendmmsg(int fd, char *data)
 
 		mmsgs[i].msg_hdr.msg_iov = iov + i;
 		mmsgs[i].msg_hdr.msg_iovlen = 1;
+		mmsgs[i].msg_hdr.msg_name = (void *)&cfg_dst_addr;
+		mmsgs[i].msg_hdr.msg_namelen = cfg_alen;
 		if (msg_controllen) {
 			mmsgs[i].msg_hdr.msg_control = control;
 			mmsgs[i].msg_hdr.msg_controllen = msg_controllen;
-- 
2.11.0

next prev parent reply	other threads:[~2019-05-23 21:06 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 21:06 [PATCH net 0/4] Allow TX timestamp with UDP GSO fklassen
2019-05-23 21:06 ` Fred Klassen
2019-05-23 21:06 ` [PATCH net 1/4] net/udp_gso: " fklassen
2019-05-23 21:06   ` Fred Klassen
2019-05-23 21:39   ` willemdebruijn.kernel
2019-05-23 21:39     ` Willem de Bruijn
2019-05-24  1:38     ` fklassen
2019-05-24  1:38       ` Fred Klassen
2019-05-24  4:53       ` willemdebruijn.kernel
2019-05-24  4:53         ` Willem de Bruijn
2019-05-24 16:34         ` fklassen
2019-05-24 16:34           ` Fred Klassen
2019-05-24 19:29           ` willemdebruijn.kernel
2019-05-24 19:29             ` Willem de Bruijn
2019-05-24 22:01             ` fklassen
2019-05-24 22:01               ` Fred Klassen
2019-05-25 15:20               ` willemdebruijn.kernel
2019-05-25 15:20                 ` Willem de Bruijn
2019-05-25 18:47                 ` fklassen
2019-05-25 18:47                   ` Fred Klassen
2019-05-27  1:30                   ` willemdebruijn.kernel
2019-05-27  1:30                     ` Willem de Bruijn
2019-05-27  2:09                     ` willemdebruijn.kernel
2019-05-27  2:09                       ` Willem de Bruijn
2019-05-25 20:46     ` fklassen
2019-05-25 20:46       ` Fred Klassen
2019-05-23 21:59   ` willemdebruijn.kernel
2019-05-23 21:59     ` Willem de Bruijn
2019-05-25 20:09     ` fklassen
2019-05-25 20:09       ` Fred Klassen
2019-05-25 20:47     ` fklassen
2019-05-25 20:47       ` Fred Klassen
2019-05-23 21:06 ` [PATCH net 2/4] net/udpgso_bench_tx: options to exercise TX CMSG fklassen
2019-05-23 21:06   ` Fred Klassen
2019-05-23 21:45   ` willemdebruijn.kernel
2019-05-23 21:45     ` Willem de Bruijn
2019-05-23 21:52   ` willemdebruijn.kernel
2019-05-23 21:52     ` Willem de Bruijn
2019-05-24  2:10     ` fklassen
2019-05-24  2:10       ` Fred Klassen
2019-05-23 21:06 ` fklassen [this message]
2019-05-23 21:06   ` [PATCH net 3/4] net/udpgso_bench_tx: fix sendmmsg on unconnected socket Fred Klassen
2019-05-23 21:06 ` [PATCH net 4/4] net/udpgso_bench_tx: audit error queue fklassen
2019-05-23 21:06   ` Fred Klassen
2019-05-23 21:56   ` willemdebruijn.kernel
2019-05-23 21:56     ` Willem de Bruijn
2019-05-24  1:27     ` fklassen
2019-05-24  1:27       ` Fred Klassen
2019-05-24  5:02       ` willemdebruijn.kernel
2019-05-24  5:02         ` Willem de Bruijn
2019-05-27 21:30     ` fklassen
2019-05-27 21:30       ` Fred Klassen
2019-05-27 21:46       ` willemdebruijn.kernel
2019-05-27 21:46         ` Willem de Bruijn
2019-05-27 22:56         ` fklassen
2019-05-27 22:56           ` Fred Klassen
2019-05-28  1:15           ` willemdebruijn.kernel
2019-05-28  1:15             ` Willem de Bruijn
2019-05-28  5:19             ` fklassen
2019-05-28  5:19               ` Fred Klassen
2019-05-28 15:08               ` willemdebruijn.kernel
2019-05-28 15:08                 ` Willem de Bruijn
2019-05-28 16:57                 ` fklassen
2019-05-28 16:57                   ` Fred Klassen
2019-05-28 17:07                   ` willemdebruijn.kernel
2019-05-28 17:07                     ` Willem de Bruijn
2019-05-28 17:11                     ` willemdebruijn.kernel
2019-05-28 17:11                       ` Willem de Bruijn

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:a900f016b9e dfblob:56e0d890b06 dfblob:a900f016b9e
dfblob:56e0d890b06 )
 OR (
bs:"[PATCH net 3/4] net/udpgso_bench_tx: fix sendmmsg on unconnected socket" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523210651.80902-4-fklassen@appneta.com \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox