From: George Stark <gnstark@salutedevices.com>
To: <pavel@ucw.cz>, <lee@kernel.org>, <vadimp@nvidia.com>,
<mpe@ellerman.id.au>, <npiggin@gmail.com>,
<christophe.leroy@csgroup.eu>, <hdegoede@redhat.com>,
<mazziesaccount@gmail.com>, <andy.shevchenko@gmail.com>,
<jic23@kernel.org>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>, <kernel@salutedevices.com>,
George Stark <gnstark@salutedevices.com>
Subject: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it
Date: Mon, 4 Dec 2023 21:05:55 +0300 [thread overview]
Message-ID: <20231204180603.470421-3-gnstark@salutedevices.com> (raw)
In-Reply-To: <20231204180603.470421-1-gnstark@salutedevices.com>
In the probe() callback in case of error mutex is destroyed being locked
which is not allowed so unlock the mute before destroying.
Signed-off-by: George Stark <gnstark@salutedevices.com>
---
drivers/leds/leds-aw2013.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c
index 59765640b70f..c2bc0782c0cd 100644
--- a/drivers/leds/leds-aw2013.c
+++ b/drivers/leds/leds-aw2013.c
@@ -397,6 +397,7 @@ static int aw2013_probe(struct i2c_client *client)
regulator_disable(chip->vcc_regulator);
error:
+ mutex_unlock(&chip->mutex);
mutex_destroy(&chip->mutex);
return ret;
}
--
2.38.4
next prev parent reply other threads:[~2023-12-04 18:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 18:05 [PATCH v2 00/10] devm_led_classdev_register() usage problem George Stark
2023-12-04 18:05 ` [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init George Stark
2023-12-04 18:11 ` Andy Shevchenko
2023-12-06 7:56 ` George Stark
2023-12-06 14:58 ` Hans de Goede
2023-12-04 23:05 ` Christophe Leroy
2023-12-05 6:20 ` Matti Vaittinen
2023-12-06 15:01 ` Hans de Goede
2023-12-06 18:58 ` George Stark
2023-12-06 19:55 ` Hans de Goede
2023-12-06 21:02 ` Waiman Long
2023-12-07 0:37 ` George Stark
2023-12-07 2:16 ` Waiman Long
2023-12-07 21:29 ` Waiman Long
2023-12-06 22:14 ` Christophe Leroy
2023-12-06 22:37 ` Christophe Leroy
2023-12-06 23:24 ` George Stark
2023-12-07 11:59 ` Andy Shevchenko
2023-12-07 12:31 ` Christophe Leroy
2023-12-07 12:45 ` Andy Shevchenko
2023-12-07 12:02 ` Andy Shevchenko
2023-12-07 12:28 ` Christophe Leroy
2023-12-07 12:51 ` George Stark
2023-12-07 13:01 ` Christophe Leroy
2023-12-07 13:24 ` George Stark
2023-12-04 18:05 ` George Stark [this message]
2023-12-04 18:13 ` [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it Andy Shevchenko
2023-12-04 23:09 ` Christophe Leroy
2023-12-06 8:37 ` George Stark
2023-12-04 18:05 ` [PATCH v2 03/10] leds: aw2013: use devm API to cleanup module's resources George Stark
2023-12-04 18:15 ` Andy Shevchenko
2023-12-04 23:14 ` Christophe Leroy
2023-12-04 18:05 ` [PATCH v2 04/10] leds: aw200xx: " George Stark
2023-12-04 18:16 ` Andy Shevchenko
2023-12-04 23:17 ` Christophe Leroy
2023-12-04 18:05 ` [PATCH v2 05/10] leds: lp3952: " George Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204180603.470421-3-gnstark@salutedevices.com \
--to=gnstark@salutedevices.com \
--cc=andy.shevchenko@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=kernel@salutedevices.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mazziesaccount@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=pavel@ucw.cz \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox