From: Hans de Goede <hdegoede@redhat.com>
To: George Stark <gnstark@salutedevices.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: pavel@ucw.cz, lee@kernel.org, vadimp@nvidia.com,
mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, mazziesaccount@gmail.com,
jic23@kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kernel@salutedevices.com
Subject: Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init
Date: Wed, 6 Dec 2023 15:58:23 +0100 [thread overview]
Message-ID: <6381d523-8f49-48e2-8576-b74a14eead30@redhat.com> (raw)
In-Reply-To: <48ea90f9-922d-4a03-86da-cbb5aa9908b6@salutedevices.com>
Hi,
On 12/6/23 08:56, George Stark wrote:
> Hello Andy
>
> Thanks for the review.
>
> On 12/4/23 21:11, Andy Shevchenko wrote:
>> On Mon, Dec 4, 2023 at 8:07 PM George Stark <gnstark@salutedevices.com> wrote:
>>>
>>> Using of devm API leads to certain order of releasing resources.
>>> So all dependent resources which are not devm-wrapped should be deleted
>>> with respect to devm-release order. Mutex is one of such objects that
>>> often is bound to other resources and has no own devm wrapping.
>>> Since mutex_destroy() actually does nothing in non-debug builds
>>> frequently calling mutex_destroy() is just ignored which is safe for now
>>> but wrong formally and can lead to a problem if mutex_destroy() is
>>> extended so introduce devm_mutex_init().
>>
>> ...
>>
>> Do you need to include mutex.h?
> It's already included in linux/device.h which is included in devm-helpers. Should I include mutex.h explicitly?
Yes you must explicitly include all headers you use definitions
from. Relying on other headers to do this for you is error prone.
Regards,
Hans
next prev parent reply other threads:[~2023-12-06 14:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 18:05 [PATCH v2 00/10] devm_led_classdev_register() usage problem George Stark
2023-12-04 18:05 ` [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init George Stark
2023-12-04 18:11 ` Andy Shevchenko
2023-12-06 7:56 ` George Stark
2023-12-06 14:58 ` Hans de Goede [this message]
2023-12-04 23:05 ` Christophe Leroy
2023-12-05 6:20 ` Matti Vaittinen
2023-12-06 15:01 ` Hans de Goede
2023-12-06 18:58 ` George Stark
2023-12-06 19:55 ` Hans de Goede
2023-12-06 21:02 ` Waiman Long
2023-12-07 0:37 ` George Stark
2023-12-07 2:16 ` Waiman Long
2023-12-07 21:29 ` Waiman Long
2023-12-06 22:14 ` Christophe Leroy
2023-12-06 22:37 ` Christophe Leroy
2023-12-06 23:24 ` George Stark
2023-12-07 11:59 ` Andy Shevchenko
2023-12-07 12:31 ` Christophe Leroy
2023-12-07 12:45 ` Andy Shevchenko
2023-12-07 12:02 ` Andy Shevchenko
2023-12-07 12:28 ` Christophe Leroy
2023-12-07 12:51 ` George Stark
2023-12-07 13:01 ` Christophe Leroy
2023-12-07 13:24 ` George Stark
2023-12-04 18:05 ` [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it George Stark
2023-12-04 18:13 ` Andy Shevchenko
2023-12-04 23:09 ` Christophe Leroy
2023-12-06 8:37 ` George Stark
2023-12-04 18:05 ` [PATCH v2 03/10] leds: aw2013: use devm API to cleanup module's resources George Stark
2023-12-04 18:15 ` Andy Shevchenko
2023-12-04 23:14 ` Christophe Leroy
2023-12-04 18:05 ` [PATCH v2 04/10] leds: aw200xx: " George Stark
2023-12-04 18:16 ` Andy Shevchenko
2023-12-04 23:17 ` Christophe Leroy
2023-12-04 18:05 ` [PATCH v2 05/10] leds: lp3952: " George Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6381d523-8f49-48e2-8576-b74a14eead30@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gnstark@salutedevices.com \
--cc=jic23@kernel.org \
--cc=kernel@salutedevices.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mazziesaccount@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=pavel@ucw.cz \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox