Linux Manual Pages development
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx+linux-man@kernel.org>
To: "Günther Noack" <gnoack3000@gmail.com>
Cc: Kuniyuki Iwashima <kuniyu@google.com>, linux-man@vger.kernel.org
Subject: Re: [PATCH v2 0/8] unix.7: Socket Options and SCM_* fixes
Date: Fri, 20 Nov 2026 00:37:03 +0100	[thread overview]
Message-ID: <av-HtwHXlZBTpzZc@devuan> (raw)
In-Reply-To: <20261103202211.13820-1-gnoack3000@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3593 bytes --]

Hi Günther,

> Date: 2026-11-03 21:22:02+0100
> From: Günther Noack <gnoack3000@gmail.com>
>
> Hello!
> 
> This is patch set (B) spun off from the "Documentation fixes in
> unix(7)" patch set [1], which is now split into these three parts:
> 
>  (A) Miscellaneous fixes, mostly in unix.7, one in socket.7
>  (B) Socket options and Socket-level Control Messages (SCM_*) <-- this one
>  (C) sock_diag.7

Would you mind rebasing and sending a revised patch set?
There are some patches which I'd like to apply, but they don't apply
cleanly.

There's also some patches which I haven't applied yet (I commented on
them).


Have a lovely night!
Alex

> 
> This patch set fixes unix(7) documentation related to socket options
> and SCM_* control messages.  The first 5 commits are fixes and factual
> corrections, the last two commits are documenting two relevant new
> features (PIDFD passing and SO_PASSRIGHTS).
> 
> The patch set is based on the "miscellaneous" patch set (A) ("General
> Unix Domain Socket fixes"), since it is touching some error code
> documentation in the same corner as what is getting changed in (A).
> 
> Thank you for your reviews of v1 and v2 of the still-joined patch set,
> as well as of v1 of the split patch set.
> 
> Changes in v2 (split):
> 
> * Mention commit hashes in commit messages, not in groff comments
> * Reword __scm_send() code snippet in commit message
> * s/the last one takes effect/the last one is sent/
> * Rewrite SCM_SECURITY section to be about byte buffers
>   and independent of the LSM
> * New commit:
>   * Remove mentions of "namespace" in the general sense
> 
> Changes in v1 (split):
> 
> * Some commit message rewording (especially quoted the kernel code
>   more directly).
> * I removed the commit that changed the wording about Out-of-Band
>   messaging, per Kuniyuki's suggestion in [2].
> * The ETOOMANYREFS commit is a SCM_RIGHTS-specific error; the Autobind
>   documentation change is included here because it refers to
>   SO_PASSPIDFD.
> * I am not 100% happy with how verbose the SCM_SECURITY change has
>   become, but I don't see a good way to shorten it without cutting
>   away from the substance.
> 
> v1: https://lore.kernel.org/all/20261021212256.27961-1-gnoack3000@gmail.com/
> 
> More details are attached in the commit notes.
> 
> This patch set has been produced with the help of a LLM, which was
> helpful for spotting a long list of inaccuracies, comparing the
> documentation with the kernel implementation.  (More details in [1])
> 
> –Günther
> 
> P.S.: Part (C) will come soon, but not today any more. :)
>       That part is more independent again and, being about "sock_diag",
>       it is outside of the main unix(7) documentation.
> 
> 
> Günther Noack (8):
>   man/man7/unix.7: ERRORS: ETOOMANYREFS: Fix the conditions
>   man/man7/unix.7: Multiple same-typed SCM_* messages may be sent in one
>     message
>   man/man7/unix.7: Autobind: Clarify when it happens, and mention
>     SO_PASSPIDFD
>   man/man7/unix.7: SCM_SECURITY: Generalize to other LSMs, not just
>     SELinux
>   man/man7/unix.7: SO_PASSSEC: wfix
>   man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD
>   man/man7/unix.7: Document SO_PASSRIGHTS
>   man/man7/unix.7: Remove mentions of "namespace" in the general sense
> 
>  man/man7/unix.7 | 215 +++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 195 insertions(+), 20 deletions(-)
> 
> -- 
> 2.56.0
> 
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2026-11-19 23:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 20:22 [PATCH v2 0/8] unix.7: Socket Options and SCM_* fixes Günther Noack
2026-11-03 20:22 ` [PATCH v2 1/8] man/man7/unix.7: ERRORS: ETOOMANYREFS: Fix the conditions Günther Noack
2026-11-06 13:00   ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 2/8] man/man7/unix.7: Multiple same-typed SCM_* messages may be sent in one message Günther Noack
2026-11-16  0:52   ` Kuniyuki Iwashima
2026-11-18  0:59     ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 3/8] man/man7/unix.7: Autobind: Clarify when it happens, and mention SO_PASSPIDFD Günther Noack
2026-11-16  0:53   ` Kuniyuki Iwashima
2026-11-18  1:06     ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 4/8] man/man7/unix.7: SCM_SECURITY: Generalize to other LSMs, not just SELinux Günther Noack
2026-11-16  0:55   ` Kuniyuki Iwashima
2026-11-16  7:35     ` Günther Noack
2026-11-18  1:15       ` Alejandro Colomar
2026-11-18  1:13   ` Alejandro Colomar
2026-11-20 14:17     ` Günther Noack
2026-11-20 14:41       ` Alejandro Colomar
2026-11-20 14:42         ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 5/8] man/man7/unix.7: SO_PASSSEC: wfix Günther Noack
2026-11-03 20:22 ` [PATCH v2 6/8] man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD Günther Noack
2026-11-16  1:03   ` Kuniyuki Iwashima
2026-11-18 16:24   ` Christian Brauner
2026-11-20 15:59     ` Günther Noack
2026-11-03 20:22 ` [PATCH v2 7/8] man/man7/unix.7: Document SO_PASSRIGHTS Günther Noack
2026-11-16  1:02   ` Kuniyuki Iwashima
2026-11-03 20:22 ` [PATCH v2 8/8] man/man7/unix.7: Remove mentions of "namespace" in the general sense Günther Noack
2026-11-16  0:59   ` Kuniyuki Iwashima
2026-11-19 23:37 ` Alejandro Colomar [this message]
2026-11-20 16:02   ` [PATCH v2 0/8] unix.7: Socket Options and SCM_* fixes Günther Noack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av-HtwHXlZBTpzZc@devuan \
    --to=alx+linux-man@kernel.org \
    --cc=gnoack3000@gmail.com \
    --cc=kuniyu@google.com \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox