Linux Manual Pages development
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: Matthieu Buffet <matthieu@buffet.re>
Cc: "Günther Noack" <gnoack3000@gmail.com>,
	"Mickaël Salaün" <mic@digikod.net>,
	linux-man@vger.kernel.org, g.branden.robinson@gmail.com
Subject: Re: [PATCH v2 2/2] man/man?/landlock*.?: Document UDP support
Date: Sun, 15 Nov 2026 22:18:06 +0100	[thread overview]
Message-ID: <avogyPekOEm-xBPV@devuan> (raw)
In-Reply-To: <bc495b26-2e26-4fc0-934b-37d55cb423a8@buffet.re>

[-- Attachment #1: Type: text/plain, Size: 4187 bytes --]

[CC += Branden]

Hi Matthieu,

> Date: 2026-11-15 21:55:50+0100
> From: Matthieu Buffet <matthieu@buffet.re>
>
> Hi Günther, Alejandro,
> 
> On 11/6/26 11:02 PM, Günther Noack wrote:
> > On Tue, Nov 03, 2026 at 12:39:32AM +0100, Matthieu Buffet wrote:
> >>   A Landlock rule with port 0
> >>   and the
> >>   .B LANDLOCK_ACCESS_NET_BIND_TCP
> >> -right means that requesting to bind on port 0 is allowed
> >> -and it will automatically translate to binding on the related port
> range.
> >> +or
> >> +.B LANDLOCK_ACCESS_NET_BIND_UDP
> >> +right means that requesting to bind on port 0
> >> +(explicitly, or implicitly
> >> +for instance by sending a datagram on an unbound UDP socket)
> >> +is allowed
> >> +and it will automatically translate to binding on a kernel-assigned
> ephemeral port.
> >
> > With the caveat of not being a native speaker either, the commas in
> > this sentence feel wrong to me.
> 
> I was trying to make the comma match the fact that the example only applies
> to the implicit case, but if it sounds wrong let's use your suggestion.

Perhaps you could use two levels of separation, with ';':

	(explicitly;
	or implicitly,
	for instance, by sending a datagram ...)

But this is a bit beyond my expertise.  I've CCd Branden, which will
surely be able to help.


Have a lovely night!
Alex

> 
> >> +To allow this if
> >> +.B LANDLOCK_ACCESS_NET_BIND_UDP
> >> +is handled
> >> +(even if
> >> +.B LANDLOCK_ACCESS_NET_CONNECT_SEND_UDP
> >> +is not),
> >
> > This phrasing is different to the kernel documentation, where it says:
> >
> >     To allow this if both LANDLOCK_ACCESS_NET_BIND_UDP and
> >     LANDLOCK_ACCESS_NET_CONNECT_SEND_UDP are handled, [...]
> >
> >     (see https://docs.kernel.org/userspace-api/landlock.html)
> >
> > Is this intentional?
> 
> Absolutely, it's bullet point #1 (the most important imho) in the three
> divergences I listed in the patch description. My current text in the kernel
> docs is not technically wrong, but it does not highlight the most
> non-trivial case (connect+send not handled, but bind handled, causing
> connect+send denials).
> 
> >> +Note on
> >> +.BR AF_UNSPEC :
> >> +Calling
> >> +.BR connect (2)
> >> +on a TCP or UDP socket
> >> +with an address of the
> >> +.B AF_UNSPEC
> >> +family
> >> +can only dissolve existing associations,
> >> +and as such is always allowed.
> >> +On IPv6 UDP sockets, if
> >> +.B LANDLOCK_ACCESS_NET_CONNECT_SEND_UDP
> >> +is handled,
> >> +sending datagrams to
> >> +.B AF_UNSPEC
> >> +addresses is not supported
> >> +and will always result in a denial,
> >> +as if the policy rejected it:
> >> +use a
> >> +.I NULL
> >> +address instead to get the same semantics
> >> +inside and outside a Landlock domain.
> >> +Other uses of the
> >> +.B AF_UNSPEC
> >> +family have unchanged semantics.
> >
> > This second "note" discussion seems to deviate in its meaning from
> > what the second "note" box said in the kernel documentation.
> >
> > https://docs.kernel.org/userspace-api/landlock.html#network-flags
> >
> > Is this intentional?
> 
> Yes that's bullet point #2, a better description ("always result in a
> denial, as if the policy rejected it" instead of just "not supported") of
> this deviation from normal network stack behavior.
> 
> > I admittedly have trouble following the documentation in this
> > rewritten note (and also the kernel documentation).  What does
> > "sending datagrams to AF_UNSPEC" mean in the context of IPv6?
> 
> You are correct about connect(AF_UNSPEC) semantics, and here I meant
> sendto()/sendmsg()/etc. on an IPv6 UDP socket with a msg_name whose family
> is AF_UNSPEC (which is interpreted as "no address" by the network stack). I
> changed this to a hopefully more explicit wording in v3.
> 
> > Is the new man page phrasing one that you'd also like to carry over
> > into the kernel documentation?
> 
> Absolutely, tell me what you think about v3, and once we agree on the
> changes I will send a patch to sync them into the docs.
> 
> Have a nice day!
> 
> Matthieu

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2026-11-15 21:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  7:58 [PATCH 0/3] Add Landlock UDP support documentation Matthieu Buffet
2026-09-17  7:58 ` [PATCH 1/3] man/man2/landlock_add_rule.2: Clarify ephemeral port range Matthieu Buffet
2026-09-26 10:00   ` Günther Noack
2026-09-29 19:02   ` Mickaël Salaün
2026-09-17  7:58 ` [PATCH 2/3] man/man7/landlock.7: Document AF_UNSPEC behaviour and error codes Matthieu Buffet
2026-09-26 10:13   ` Günther Noack
2026-09-17  7:58 ` [PATCH 3/3] man/man7/landlock.7, man/man2/landlock_add_rule.2: Document UDP support Matthieu Buffet
2026-09-26 14:01   ` Günther Noack
2026-09-29 19:03     ` Mickaël Salaün
2026-09-29 19:02 ` [PATCH 0/3] Add Landlock UDP support documentation Mickaël Salaün
2026-10-30 19:24   ` Günther Noack
2026-11-02 23:37     ` Matthieu Buffet
2026-11-02 23:39       ` [PATCH v2 1/2] man/man2/landlock_add_rule.2: Clarify ephemeral port range Matthieu Buffet
2026-11-02 23:39         ` [PATCH v2 2/2] man/man?/landlock*.?: Document UDP support Matthieu Buffet
2026-11-06 22:02           ` Günther Noack
2026-11-07 11:15             ` Alejandro Colomar
2026-11-15 20:55               ` Matthieu Buffet
2026-11-15 20:58                 ` [PATCH v3] " Matthieu Buffet
2026-11-15 21:18                 ` Alejandro Colomar [this message]
2026-11-15 21:53                   ` [PATCH v2 2/2] " G. Branden Robinson
2026-11-17  9:47                     ` Alejandro Colomar
2026-11-06 21:24         ` [PATCH v2 1/2] man/man2/landlock_add_rule.2: Clarify ephemeral port range Günther Noack
2026-11-07 11:10           ` Alejandro Colomar
2026-11-03  0:24       ` [PATCH 0/3] Add Landlock UDP support documentation Alejandro Colomar
2026-11-03  9:04         ` Matthieu Buffet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avogyPekOEm-xBPV@devuan \
    --to=alx@kernel.org \
    --cc=g.branden.robinson@gmail.com \
    --cc=gnoack3000@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=matthieu@buffet.re \
    --cc=mic@digikod.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox