Linux Manual Pages development
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: "G. Branden Robinson" <g.branden.robinson@gmail.com>
Cc: "Matthieu Buffet" <matthieu@buffet.re>,
	"Günther Noack" <gnoack3000@gmail.com>,
	"Mickaël Salaün" <mic@digikod.net>,
	linux-man@vger.kernel.org
Subject: Re: [PATCH v2 2/2] man/man?/landlock*.?: Document UDP support
Date: Tue, 17 Nov 2026 10:47:28 +0100	[thread overview]
Message-ID: <avwiSt7sMInH0_d-@devuan> (raw)
In-Reply-To: <20261115215359.tcfw7u3apvbqxde5@illithid>

[-- Attachment #1: Type: text/plain, Size: 3177 bytes --]

Hi Branden,

> Date: 2026-11-15 15:53:59-0600
> From: "G. Branden Robinson" <g.branden.robinson@gmail.com>
>
> Hi Alex,
> 
> At 2026-11-15T22:18:06+0100, Alejandro Colomar wrote:
> > > Date: 2026-11-15 21:55:50+0100
> > > From: Matthieu Buffet <matthieu@buffet.re>
> > > On 11/6/26 11:02 PM, Günther Noack wrote:
> > > > On Tue, Nov 03, 2026 at 12:39:32AM +0100, Matthieu Buffet wrote:
> > > >>   A Landlock rule with port 0
> > > >>   and the
> > > >>   .B LANDLOCK_ACCESS_NET_BIND_TCP
> > > >> -right means that requesting to bind on port 0 is allowed
> > > >> -and it will automatically translate to binding on the related port
> > > range.
> > > >> +or
> > > >> +.B LANDLOCK_ACCESS_NET_BIND_UDP
> > > >> +right means that requesting to bind on port 0
> > > >> +(explicitly, or implicitly
> > > >> +for instance by sending a datagram on an unbound UDP socket)
> > > >> +is allowed
> > > >> +and it will automatically translate to binding on a kernel-assigned
> > > ephemeral port.
> > > >
> > > > With the caveat of not being a native speaker either, the commas in
> > > > this sentence feel wrong to me.
> > > 
> > > I was trying to make the comma match the fact that the example only applies
> > > to the implicit case, but if it sounds wrong let's use your suggestion.
> > 
> > Perhaps you could use two levels of separation, with ';':
> > 
> > 	(explicitly;
> > 	or implicitly,
> > 	for instance, by sending a datagram ...)
> > 
> > But this is a bit beyond my expertise.  I've CCd Branden, which will
> > surely be able to help.
> 
> Well, maybe.
> 
> I don't know of hard rules governing this sort of construction, but use
> of a semicolon here "feels" wrong, as you're not joining independent
> clauses nor are you separating list items, at least some of which
> contain commas.
> 
> I might use an em dash here.  But, trying to interpret this language for
> myself, I think the best solution might be to recast to break up this
> long sentence into shorter ones.
> 
> Thus:
> 
> A Landlock rule with port 0
> and the
> .B LANDLOCK_ACCESS_NET_BIND_TCP
> or
> .B LANDLOCK_ACCESS_NET_BIND_UDP
> right means that a port 0 binding request is allowed,
> automatically translating
> to a binding on a kernel-assigned ephemeral port.
> Such binding can be done explicitly or implicitly.
> Sending a datagram on an unbound UDP socket is one implicit means.

Thanks!  That sounds good.  Perhaps we could put the last sentence in
parentheses, as it's not part of the specification.

	A Landlock rule with port 0
	and the
	.B LANDLOCK_ACCESS_NET_BIND_TCP
	or
	.B LANDLOCK_ACCESS_NET_BIND_UDP
	right means that a port 0 binding request is allowed,
	automatically translating
	to a binding on a kernel-assigned ephemeral port.
	Such binding can be done explicitly or implicitly
	(sending a datagram on an unbound UDP socket is one implicit means).

Have a lovely day!
Alex

> 
> I also recast the text to tighten wording, to reduce use of passive
> voice, and to favor present tense over future.
> 
> Does this help?
> 
> Regards,
> Branden



-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-11-17  9:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  7:58 [PATCH 0/3] Add Landlock UDP support documentation Matthieu Buffet
2026-09-17  7:58 ` [PATCH 1/3] man/man2/landlock_add_rule.2: Clarify ephemeral port range Matthieu Buffet
2026-09-26 10:00   ` Günther Noack
2026-09-29 19:02   ` Mickaël Salaün
2026-09-17  7:58 ` [PATCH 2/3] man/man7/landlock.7: Document AF_UNSPEC behaviour and error codes Matthieu Buffet
2026-09-26 10:13   ` Günther Noack
2026-09-17  7:58 ` [PATCH 3/3] man/man7/landlock.7, man/man2/landlock_add_rule.2: Document UDP support Matthieu Buffet
2026-09-26 14:01   ` Günther Noack
2026-09-29 19:03     ` Mickaël Salaün
2026-09-29 19:02 ` [PATCH 0/3] Add Landlock UDP support documentation Mickaël Salaün
2026-10-30 19:24   ` Günther Noack
2026-11-02 23:37     ` Matthieu Buffet
2026-11-02 23:39       ` [PATCH v2 1/2] man/man2/landlock_add_rule.2: Clarify ephemeral port range Matthieu Buffet
2026-11-02 23:39         ` [PATCH v2 2/2] man/man?/landlock*.?: Document UDP support Matthieu Buffet
2026-11-06 22:02           ` Günther Noack
2026-11-07 11:15             ` Alejandro Colomar
2026-11-15 20:55               ` Matthieu Buffet
2026-11-15 20:58                 ` [PATCH v3] " Matthieu Buffet
2026-11-15 21:18                 ` [PATCH v2 2/2] " Alejandro Colomar
2026-11-15 21:53                   ` G. Branden Robinson
2026-11-17  9:47                     ` Alejandro Colomar [this message]
2026-11-06 21:24         ` [PATCH v2 1/2] man/man2/landlock_add_rule.2: Clarify ephemeral port range Günther Noack
2026-11-07 11:10           ` Alejandro Colomar
2026-11-03  0:24       ` [PATCH 0/3] Add Landlock UDP support documentation Alejandro Colomar
2026-11-03  9:04         ` Matthieu Buffet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avwiSt7sMInH0_d-@devuan \
    --to=alx@kernel.org \
    --cc=g.branden.robinson@gmail.com \
    --cc=gnoack3000@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=matthieu@buffet.re \
    --cc=mic@digikod.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox