* [PATCH] staging: media: atomisp: Removed a function entry log
@ 2021-04-12 15:59 Martiros Shakhzadyan
2021-04-12 21:28 ` Sakari Ailus
2021-04-13 14:51 ` Hans Verkuil
0 siblings, 2 replies; 6+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-12 15:59 UTC (permalink / raw)
To: mchehab; +Cc: sakari.ailus, hverkuil, linux-media, vrzh
Removed a function entry log in ov2722_remove, as ftrace is a preferred
method for function entry/exit tracing.
Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index c017e9066b7a..912eadaffc44 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
struct v4l2_subdev *sd = i2c_get_clientdata(client);
struct ov2722_device *dev = to_ov2722_sensor(sd);
- dev_dbg(&client->dev, "ov2722_remove...\n");
-
dev->platform_data->csi_cfg(sd, 0);
v4l2_ctrl_handler_free(&dev->ctrl_handler);
v4l2_device_unregister_subdev(sd);
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: media: atomisp: Removed a function entry log
2021-04-12 15:59 [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
@ 2021-04-12 21:28 ` Sakari Ailus
2021-04-13 14:51 ` Hans Verkuil
1 sibling, 0 replies; 6+ messages in thread
From: Sakari Ailus @ 2021-04-12 21:28 UTC (permalink / raw)
To: Martiros Shakhzadyan; +Cc: mchehab, hverkuil, linux-media
Hi Martiros,
Thanks for the patch.
On Mon, Apr 12, 2021 at 11:59:59AM -0400, Martiros Shakhzadyan wrote:
> Removed a function entry log in ov2722_remove, as ftrace is a preferred
> method for function entry/exit tracing.
>
> Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
For this and your other atomisp patch:
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: media: atomisp: Removed a function entry log
2021-04-12 15:59 [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12 21:28 ` Sakari Ailus
@ 2021-04-13 14:51 ` Hans Verkuil
2021-04-13 17:53 ` Martiros Shakhzadyan
1 sibling, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2021-04-13 14:51 UTC (permalink / raw)
To: Martiros Shakhzadyan, mchehab; +Cc: sakari.ailus, linux-media
On 12/04/2021 17:59, Martiros Shakhzadyan wrote:
> Removed a function entry log in ov2722_remove, as ftrace is a preferred
> method for function entry/exit tracing.
It turns out that someone else already made the same fix [1], so marking
this patch as obsolete.
There are quite a few atomisp patches pending for 5.13, so it might be
a good idea to checkout the media subsystem master tree since that is
more recent than mainline.
https://git.linuxtv.org/media_tree.git/
Regards,
Hans
[1]:
https://patchwork.linuxtv.org/project/linux-media/patch/20210106181158.2270-1-fil.kolev@gmail.com/
>
> Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> index c017e9066b7a..912eadaffc44 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
> struct v4l2_subdev *sd = i2c_get_clientdata(client);
> struct ov2722_device *dev = to_ov2722_sensor(sd);
>
> - dev_dbg(&client->dev, "ov2722_remove...\n");
> -
> dev->platform_data->csi_cfg(sd, 0);
> v4l2_ctrl_handler_free(&dev->ctrl_handler);
> v4l2_device_unregister_subdev(sd);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: media: atomisp: Removed a function entry log
2021-04-13 14:51 ` Hans Verkuil
@ 2021-04-13 17:53 ` Martiros Shakhzadyan
0 siblings, 0 replies; 6+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-13 17:53 UTC (permalink / raw)
To: Hans Verkuil; +Cc: sakari.ailus, linux-media
On Tue, Apr 13, 2021 at 04:51:18PM +0200, Hans Verkuil wrote:
> On 12/04/2021 17:59, Martiros Shakhzadyan wrote:
> > Removed a function entry log in ov2722_remove, as ftrace is a preferred
> > method for function entry/exit tracing.
>
> It turns out that someone else already made the same fix [1], so marking
> this patch as obsolete.
>
> There are quite a few atomisp patches pending for 5.13, so it might be
> a good idea to checkout the media subsystem master tree since that is
> more recent than mainline.
>
> https://git.linuxtv.org/media_tree.git/
>
> Regards,
>
> Hans
>
> [1]:
> https://patchwork.linuxtv.org/project/linux-media/patch/20210106181158.2270-1-fil.kolev@gmail.com/
>
Noted. I will continue to work off of that repo - Thanks!
> >
> > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> > ---
> > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > index c017e9066b7a..912eadaffc44 100644
> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
> > struct v4l2_subdev *sd = i2c_get_clientdata(client);
> > struct ov2722_device *dev = to_ov2722_sensor(sd);
> >
> > - dev_dbg(&client->dev, "ov2722_remove...\n");
> > -
> > dev->platform_data->csi_cfg(sd, 0);
> > v4l2_ctrl_handler_free(&dev->ctrl_handler);
> > v4l2_device_unregister_subdev(sd);
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: media: atomisp: Coding style fixes
@ 2021-04-12 2:35 Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
0 siblings, 1 reply; 6+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-12 2:35 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Martiros Shakhzadyan, Sakari Ailus, linux-media
The following set of patches fixes coding style issues in
atomisp-ov2722.
Martiros Shakhzadyan (3):
staging: media: atomisp: Removed a superfluous else clause
staging: media: atomisp: Removed a function entry log
staging: media: atomisp: Minor code style changes
.../media/atomisp/i2c/atomisp-ov2722.c | 20 +++++++++----------
1 file changed, 9 insertions(+), 11 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: media: atomisp: Removed a function entry log
2021-04-12 2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
@ 2021-04-12 2:35 ` Martiros Shakhzadyan
2021-04-12 9:28 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-12 2:35 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Martiros Shakhzadyan, Sakari Ailus, linux-media
Coding style fix.
Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index c017e9066b7a..912eadaffc44 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
struct v4l2_subdev *sd = i2c_get_clientdata(client);
struct ov2722_device *dev = to_ov2722_sensor(sd);
- dev_dbg(&client->dev, "ov2722_remove...\n");
-
dev->platform_data->csi_cfg(sd, 0);
v4l2_ctrl_handler_free(&dev->ctrl_handler);
v4l2_device_unregister_subdev(sd);
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: media: atomisp: Removed a function entry log
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
@ 2021-04-12 9:28 ` Hans Verkuil
0 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2021-04-12 9:28 UTC (permalink / raw)
To: Martiros Shakhzadyan, Mauro Carvalho Chehab; +Cc: Sakari Ailus, linux-media
On 12/04/2021 04:35, Martiros Shakhzadyan wrote:
> Coding style fix.
What exactly is the coding style issue? Please mention that.
Also, by removing the line you change the behavior (i.e. if debugging is
enabled, you no longer see this message). That's more than a coding style
fix...
Regards,
Hans
>
> Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> index c017e9066b7a..912eadaffc44 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
> struct v4l2_subdev *sd = i2c_get_clientdata(client);
> struct ov2722_device *dev = to_ov2722_sensor(sd);
>
> - dev_dbg(&client->dev, "ov2722_remove...\n");
> -
> dev->platform_data->csi_cfg(sd, 0);
> v4l2_ctrl_handler_free(&dev->ctrl_handler);
> v4l2_device_unregister_subdev(sd);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-13 17:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-12 15:59 [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12 21:28 ` Sakari Ailus
2021-04-13 14:51 ` Hans Verkuil
2021-04-13 17:53 ` Martiros Shakhzadyan
-- strict thread matches above, loose matches on Subject: below --
2021-04-12 2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12 9:28 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox