Re: [PATCH v3 00/15] media: mt9m114: Changes to make it work with atomisp devices

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hans,

On Sun, Jun 29, 2025 at 10:56:10PM +0200, Hans de Goede wrote:
> Hi All,
> 
> Here is v3 of my series to make the "mainline" mt9m114 driver work
> on devices with an atomisp CSI2 receiver / ISP. This has been tested on
> an Asus T100TA.
> 
> Changes in v3:
> - Document that using 768Mhz for out_clock_max does not work
> - Improve "media: mt9m114: Put sensor in reset on power down" commit message
> - Drop setting of the MT9M114_CAM_OUTPUT_FORMAT_BT656_CROP_SCALE_DISABLE bit
> - Split "media: mt9m114: Fix scaler bypass mode" into multiple patches,
>   addressing various review comments as part of this
> 
> Changes in v2:
> - Rebase on top of sailus/media_tree.git/fixes which now has 4 of
>   the patches from Mathis': "MT9M114 driver bugfix and improvements"
>   series, this avoids most of the conlicts between the 2 series
> - Add Laurent's Reviewed-by to some of the patches
> - Add select VIDEO_APTINA_PLL to Kconfig
> - Use correct aptina_pll_limits
> - After setting reset high wait 20 clk cycles before disabling
>   the clk and regulators
> - When bypassing the scalar make ifp_get_selection() / ifp_set_selection()
>   fill sel->r with a rectangle of (0,0)/wxh and return 0 instead of
>   returning -EINVAL

It appears that some of my review comments on v2 crossed your v3. That's
the case for 03/12 and 10/12. For 03/12 in particular, I think the
comments will result in changes for v4. How would you like to proceed,
should I review the rest first ?

> Hans de Goede (15):
>   media: aptina-pll: Debug log p1 min and max values
>   media: mt9m114: Add support for clock-frequency property
>   media: mt9m114: Use aptina-PLL helper to get PLL values
>   media: mt9m114: Lower minimum vblank value
>   media: mt9m114: Fix default hblank and vblank values
>   media: mt9m114: Tweak default hblank and vblank for more accurate fps
>   media: mt9m114: Avoid a reset low spike during probe()
>   media: mt9m114: Put sensor in reset on power down
>   media: mt9m114: Add and use mt9m114_ifp_get_border() helper function
>   media: mt9m114: Adjust IFP selections and src format when src pixelfmt
>     changes to/from RAW10
>   media: mt9m114: Update src pad sel and format when sink pad format
>     changes
>   media: mt9m114: Don't allow changing the IFP crop/compose selections
>     when bypassing the scaler
>   media: mt9m114: Drop start-, stop-streaming sequence from initialize
>   media: mt9m114: Return -EPROBE_DEFER if no endpoint is found
>   media: mt9m114: Add ACPI enumeration support
> 
>  drivers/media/i2c/Kconfig      |   1 +
>  drivers/media/i2c/aptina-pll.c |   2 +
>  drivers/media/i2c/mt9m114.c    | 255 +++++++++++++++++++++++++--------
>  3 files changed, 196 insertions(+), 62 deletions(-)

-- 
Regards,

Laurent Pinchart