Re: [PATCH v3 11/15] media: mt9m114: Update src pad sel and format when sink pad format changes

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hans,

Thank you for the patch.

On Sun, Jun 29, 2025 at 10:56:21PM +0200, Hans de Goede wrote:
> Call mt9m114_ifp_update_sel_and_src_fmt() on sink pad format changes to
> propagate these downstream.
> 
> This is necessary in 2 different scenarios:
> 
> 1. When passing through RAW10 bypassing the scaler then any sink pad format
> changes must be propagated to the crop/compose selections and to the src

s/src/source/

> pad format.
> 
> 2. When the scaler is active, then the crop-rectangle cannot be bigger then
> the sink pad format minus a 4 pixel border all around. If the sink format
> change reduces the size then things also needs to be propagated downstream.
> 
> Rather then adding extra code to check for these conditions, simply always
> propagate sink pad format changes downstream.
> 
> Signed-off-by: Hans de Goede <hansg@kernel.org>
> ---
>  drivers/media/i2c/mt9m114.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c
> index ef27780384f2..1f305bba180e 100644
> --- a/drivers/media/i2c/mt9m114.c
> +++ b/drivers/media/i2c/mt9m114.c
> @@ -1871,6 +1871,8 @@ static int mt9m114_ifp_set_fmt(struct v4l2_subdev *sd,
>  		format->height = clamp(ALIGN(fmt->format.height, 8),
>  				       MT9M114_PIXEL_ARRAY_MIN_OUTPUT_HEIGHT,
>  				       MT9M114_PIXEL_ARRAY_HEIGHT);

Blank line here.

> +		/* Propagate changes downstream */

s/downstream/downstream./

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +		mt9m114_ifp_update_sel_and_src_fmt(state);
>  	} else {
>  		const struct mt9m114_format_info *info;
>  

-- 
Regards,

Laurent Pinchart