Re: [PATCH v2 7/7] media: ipu6: add PCI ID for IPU8

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Manik,

On Thu, Oct 01, 2026 at 03:24:25PM +0530, Manik Bajpai wrote:
> 
> Hi Sakari,
> 
> On Thu, 1 Oct 2026, Sakari Ailus wrote:
> 
> > Hi Divyamani,
> > 
> > On Thu, Oct 01, 2026 at 10:31:34AM +0300, Divyamani Tripathi wrote:
> > >  static const struct ipu6_buttress_registers ipu6_buttress_regs = {
> > >  	/* Registers */
> > >  	.irq_status	= BUTTRESS_REG_ISR_STATUS,
> > > @@ -624,7 +646,8 @@ static int ipu6_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> > >  	int ret;
> > >  
> > >  	if ((id->device == PCI_DEVICE_ID_INTEL_IPU7 ||
> > > -	     id->device == PCI_DEVICE_ID_INTEL_IPU7P5) && force_no_probe_ipu7)
> > > +	     id->device == PCI_DEVICE_ID_INTEL_IPU7P5 ||
> > > +	     id->device == PCI_DEVICE_ID_INTEL_IPU8) && force_no_probe_ipu7)
> > 
> > One question about this -- is there a need to do this for IPU8? There's no
> > IPU8 support in the ipu7 staging driver so I might leave this as-is.
> 
> If I go through the (rest of) the patches from Divyamani, I do see some 
> IPU8 functionality being added. I was wondering if we still needed to do 
> away with this portion of code.

Yes, I'll drop this when merging the patch.

I didn't notice the pattern regarding the 4th patch so I'll leave that for
a later cleanup.

-- 
Regards,

Sakari Ailus