[2.6 patch] malta_mtd.c: add MODULE_LICENSE

[2.6 patch] malta_mtd.c: add MODULE_LICENSE

[Adrian Bunk]

This patch adds the missing MODULE_LICENSE("GPL").

Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 arch/mips/mips-boards/malta/malta_mtd.c |    3 +++
 1 file changed, 3 insertions(+)

da2e8fd47a57f6e5c48dc0781db3aa7a46365c38 diff --git a/arch/mips/mips-boards/malta/malta_mtd.c b/arch/mips/mips-boards/malta/malta_mtd.c
index 8ad9bdf..dd38c12 100644
--- a/arch/mips/mips-boards/malta/malta_mtd.c
+++ b/arch/mips/mips-boards/malta/malta_mtd.c
@@ -8,6 +8,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/mtd/partitions.h>
 #include <linux/mtd/physmap.h>
@@ -61,3 +62,5 @@ static int __init malta_mtd_init(void)
 }
 
 module_init(malta_mtd_init)
+
+MODULE_LICENSE("GPL");

Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE

[Ralf Baechle]

On Sun, Jun 15, 2008 at 07:13:21PM +0300, Adrian Bunk wrote:

> This patch adds the missing MODULE_LICENSE("GPL").
> 
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

NACK.  This file is only a module because 2.6.20 wouldn't build otherwise.
That's long fixed.

  Ralf

Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE

[Dmitri Vorobiev]

Ralf Baechle wrote:
> On Sun, Jun 15, 2008 at 07:13:21PM +0300, Adrian Bunk wrote:
> 
>> This patch adds the missing MODULE_LICENSE("GPL").
>>
>> Reported-by: Adrian Bunk <bunk@kernel.org>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> NACK.  This file is only a module because 2.6.20 wouldn't build otherwise.
> That's long fixed.

Every time I come across this file I wonder whether this needs to be
modularized at all. Isn't you chainsaw itching for this as well? :)

Dmitri

> 
>   Ralf
> 

Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE

[Ralf Baechle]

On Mon, Jun 16, 2008 at 05:34:58PM +0300, Dmitri Vorobiev wrote:

> Every time I come across this file I wonder whether this needs to be
> modularized at all. Isn't you chainsaw itching for this as well? :)

The reason why it was implemented as a module was that due to a MTD
"feature" the code wouldn't compile in 2.6.20 and earlier.  So yes, I
chainsawed it into the right shape, patch is on the way to Linus.

  Ralf

Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE

[Dmitri Vorobiev]

Ralf Baechle wrote:
> On Mon, Jun 16, 2008 at 05:34:58PM +0300, Dmitri Vorobiev wrote:
> 
>> Every time I come across this file I wonder whether this needs to be
>> modularized at all. Isn't you chainsaw itching for this as well? :)
> 
> The reason why it was implemented as a module was that due to a MTD
> "feature" the code wouldn't compile in 2.6.20 and earlier.  So yes, I
> chainsawed it into the right shape, patch is on the way to Linus.
> 

Understood. Thanks for the fast reply!

Dmitri

>   Ralf

Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE

[Dmitri Vorobiev]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

Ralf Baechle wrote:
> On Mon, Jun 16, 2008 at 05:34:58PM +0300, Dmitri Vorobiev wrote:
> 
>> Every time I come across this file I wonder whether this needs to be
>> modularized at all. Isn't you chainsaw itching for this as well? :)
> 
> The reason why it was implemented as a module was that due to a MTD
> "feature" the code wouldn't compile in 2.6.20 and earlier.  So yes, I
> chainsawed it into the right shape, patch is on the way to Linus.

Looks like Linus has applied the patch.

I think that module_init() needs to be replaced by device_initcall() in
malta_mtd.c. Not that it would make any difference at all, but just some
nitpicking - I simply get a bit nervous and irritated when looking at
the `module' word in the core kernel code. :)

Patch attached.

Dmitri

> 
>   Ralf
> 

Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE

[Dmitri Vorobiev]

Dmitri Vorobiev wrote:
> 
> Patch attached.

Oops, and I made a typo in the S-O-B line. Sorry for sloppiness. The
line should read:

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>