From: Paul Burton <paul.burton@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: <linux-mips@linux-mips.org>, Jason Cooper <jason@lakedaemon.net>,
"Marc Zyngier" <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Ralf Baechle" <ralf@linux-mips.org>
Subject: Re: [PATCH 37/38] irqchip: mips-gic: Use cpumask_first_and() in gic_set_affinity()
Date: Mon, 14 Aug 2017 09:18:18 -0700 [thread overview]
Message-ID: <2303810.q0vlmmS52X@np-p-burton> (raw)
In-Reply-To: <8af291b4-2cdc-d9aa-88a3-a6c3af856bb4@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
Hi Sergei,
On Sunday, 13 August 2017 02:08:50 PDT Sergei Shtylyov wrote:
> Hello!
>
> On 8/13/2017 7:36 AM, Paul Burton wrote:
> > Currently in gic_set_affinity() we calculate a temporary cpumask holding
> > the intersection of the provided cpumask & the CPUs that are online,
> > then we call cpumask_first twice on it to find the first such CPU. Since
> > we don't need to temporary cpumask for anything else & we only care
>
> s/to/the/?
Indeed - nice to know someone is reading a 38 patch series :)
I'll fix up but leave submitting a v2 until someone asks me to.
Thanks,
Paul
>
> > about the first CPU that's both online & in the provided cpumask, we can
> > instead use cpumask_first_and to find that CPU & drop the temporary
> > mask.
> >
> > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: linux-mips@linux-mips.org
>
> [...]
>
> MBR, Serge
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Paul Burton <paul.burton@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mips@linux-mips.org, Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 37/38] irqchip: mips-gic: Use cpumask_first_and() in gic_set_affinity()
Date: Mon, 14 Aug 2017 09:18:18 -0700 [thread overview]
Message-ID: <2303810.q0vlmmS52X@np-p-burton> (raw)
Message-ID: <20170814161818.p9w4xAAPkbNPcdIT4Ce2RtGhposx9GpGnxd_rtLS2dI@z> (raw)
In-Reply-To: <8af291b4-2cdc-d9aa-88a3-a6c3af856bb4@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
Hi Sergei,
On Sunday, 13 August 2017 02:08:50 PDT Sergei Shtylyov wrote:
> Hello!
>
> On 8/13/2017 7:36 AM, Paul Burton wrote:
> > Currently in gic_set_affinity() we calculate a temporary cpumask holding
> > the intersection of the provided cpumask & the CPUs that are online,
> > then we call cpumask_first twice on it to find the first such CPU. Since
> > we don't need to temporary cpumask for anything else & we only care
>
> s/to/the/?
Indeed - nice to know someone is reading a 38 patch series :)
I'll fix up but leave submitting a v2 until someone asks me to.
Thanks,
Paul
>
> > about the first CPU that's both online & in the provided cpumask, we can
> > instead use cpumask_first_and to find that CPU & drop the temporary
> > mask.
> >
> > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: linux-mips@linux-mips.org
>
> [...]
>
> MBR, Serge
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-14 16:18 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 4:36 [PATCH 00/38] irqchip: mips-gic: Cleanup & optimisation Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 01/38] irqchip: mips-gic: SYNC after enabling GIC region Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 02/38] MIPS: GIC: Introduce asm/mips-gic.h with accessor functions Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-18 11:10 ` Marc Zyngier
2017-08-18 16:43 ` Paul Burton
2017-08-18 16:43 ` Paul Burton
2017-08-13 4:36 ` [PATCH 03/38] clocksource: mips-gic-timer: Use new GIC " Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 04/38] irqchip: mips-gic: Remove counter access functions Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 05/38] MIPS: CPS: Read GIC_VL_IDENT directly, not via irqchip driver Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 06/38] irqchip: mips-gic: Remove gic_read_local_vp_id() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 07/38] lib/iomap_copy.c: Add __ioread64_copy Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 08/38] irqchip: mips-gic: Simplify shared interrupt pending/mask reads Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 09/38] irqchip: mips-gic: Simplify gic_local_irq_domain_map() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 10/38] irqchip: mips-gic: Drop gic_(re)set_mask() functions Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 11/38] irqchip: mips-gic: Remove gic_set_polarity() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 12/38] irqchip: mips-gic: Remove gic_set_trigger() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 13/38] irqchip: mips-gic: Remove gic_set_dual_edge() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 14/38] irqchip: mips-gic: Remove gic_map_to_pin() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 15/38] irqchip: mips-gic: Remove gic_map_to_vpe() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 16/38] irqchip: mips-gic: Convert remaining shared reg access to new accessors Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 17/38] irqchip: mips-gic: Convert local int mask " Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 18/38] irqchip: mips-gic: Convert remaining local reg " Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 19/38] MIPS: GIC: Move GIC_LOCAL_INT_* to asm/mips-gic.h Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 20/38] irqchip: mips-gic: Remove GIC_CPU_INT* macros Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 21/38] irqchip: mips-gic: Move various definitions to the driver Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 22/38] MIPS: VDSO: Drop gic_get_usm_range() usage Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-18 11:38 ` Marc Zyngier
2017-08-18 16:47 ` Paul Burton
2017-08-18 16:47 ` Paul Burton
2017-08-18 16:52 ` Marc Zyngier
2017-08-13 4:36 ` [PATCH 23/38] irqchip: mips-gic: Remove gic_get_usm_range() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 24/38] irqchip: mips-gic: Remove __gic_irq_dispatch() forward declaration Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 25/38] irqchip: mips-gic: Remove gic_init() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 26/38] MIPS: Use mips_gic_present() in place of gic_present Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 27/38] irqchip: mips-gic: Remove gic_present Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 28/38] irqchip: mips-gic: Move gic_get_c0_*_int() to asm/mips-gic.h Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 29/38] MIPS: VDSO: Avoid use of linux/irqchip/mips-gic.h Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 30/38] MIPS: Remove unnecessary inclusions " Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 31/38] irqchip: mips-gic: Remove linux/irqchip/mips-gic.h Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 32/38] irqchip: mips-gic: Inline __gic_init() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 33/38] irqchip: mips-gic: Inline gic_basic_init() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 34/38] irqchip: mips-gic: Make pcpu_masks a per-cpu variable Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-18 15:37 ` Marc Zyngier
2017-08-18 17:02 ` Paul Burton
2017-08-18 17:02 ` Paul Burton
2017-08-18 17:18 ` Marc Zyngier
2017-08-13 4:36 ` [PATCH 35/38] irqchip: mips-gic: Use pcpu_masks to avoid reading GIC_SH_MASK* Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-18 15:44 ` Marc Zyngier
2017-08-18 17:11 ` Paul Burton
2017-08-18 17:11 ` Paul Burton
2017-08-18 17:25 ` Marc Zyngier
2017-08-18 21:02 ` [PATCH v2 " Paul Burton
2017-08-18 21:02 ` Paul Burton
2017-08-13 4:36 ` [PATCH 36/38] irqchip: mips-gic: Clean up mti,reserved-cpu-vectors handling Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 4:36 ` [PATCH 37/38] irqchip: mips-gic: Use cpumask_first_and() in gic_set_affinity() Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-13 9:08 ` Sergei Shtylyov
2017-08-14 16:18 ` Paul Burton [this message]
2017-08-14 16:18 ` Paul Burton
2017-08-14 16:48 ` Sergei Shtylyov
2017-08-18 21:04 ` [PATCH v2 " Paul Burton
2017-08-18 21:04 ` Paul Burton
2017-08-13 4:36 ` [PATCH 38/38] irqchip: mips-gic: Let the core set struct irq_common_data affinity Paul Burton
2017-08-13 4:36 ` Paul Burton
2017-08-15 10:13 ` [PATCH 00/38] irqchip: mips-gic: Cleanup & optimisation Marc Zyngier
2017-08-15 16:16 ` Paul Burton
2017-08-15 16:16 ` Paul Burton
2017-08-15 16:49 ` Marc Zyngier
2017-08-18 17:28 ` Marc Zyngier
2017-08-18 17:44 ` Paul Burton
2017-08-18 17:44 ` Paul Burton
2017-08-18 17:49 ` Marc Zyngier
2017-08-18 21:09 ` Paul Burton
2017-08-18 21:09 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2303810.q0vlmmS52X@np-p-burton \
--to=paul.burton@imgtec.com \
--cc=jason@lakedaemon.net \
--cc=linux-mips@linux-mips.org \
--cc=marc.zyngier@arm.com \
--cc=ralf@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox