Re: [PATCH 00/38] irqchip: mips-gic: Cleanup & optimisation

[Paul Burton <paul.burton@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 2013 bytes --]

Hi Marc,

On Friday, 18 August 2017 10:49:27 PDT Marc Zyngier wrote:
> On 18/08/17 18:44, Paul Burton wrote:
> > Hi Marc,
> > 
> > On Friday, 18 August 2017 10:28:01 PDT Marc Zyngier wrote:
> >> Hi Paul,
> >> 
> >> On 13/08/17 05:36, Paul Burton wrote:
> >>> This series cleans up the MIPS Global Interrupt Controller (GIC) driver
> >>> somewhat. It moves us towards using a header in a similar vein to the
> >>> ones we have for the MIPS Coherence Manager (CM) & Cluster Power
> >>> Controller (CPC) which allows us to access the GIC outside of the
> >>> irqchip driver - something beneficial already for the clocksource &
> >>> clock event driver, and which will be beneficial for further drivers
> >>> (eg. one for the GIC watchdog timer) and for multi-cluster work. Using
> >>> this header is also beneficial for consistency & code-sharing.
> >>> 
> >>> In addition to cleanups the series also optimises the driver in various
> >>> ways, including by using a per-CPU variable for pcpu_masks & removing
> >>> the need to read the GIC_SH_MASK_* registers when decoding interrupts in
> >>> gic_handle_shared_int().
> >>> 
> >>> This series requires my "[PATCH 00/19] MIPS: Initial multi-cluster
> >>> support" series to be applied first.
> >> 
> >> I went through the whole series, and didn't spot anything bad (the
> >> couple of nits I raised can either be fixed at a later time or as a
> >> fixup on top of what you have).
> > 
> > Thanks :) I appreciate your review. So shall I take that as you'd prefer
> > that I submit separate fixup patches rather than submit a v2?
> 
> Just post the fixups on top. Nobody wants a new 38 series in their
> Inbox! ;-)

The changes to patch 35 wound up causing conflicts with patch 37 if you go 
squash the fixup commit, so I instead submitted a v2 of just those 2 patches.

I've also updated a bundle on the linux-mips patchwork which is hopefully 
convenient for whomever merges the series:

https://patchwork.linux-mips.org/bundle/paulburton/4.14-gic/

Thanks,
    Paul

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]