From: Jun Sun <jsun@mvista.com>
To: Ralf Baechle <ralf@oss.sgi.com>,
linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: load_unaligned() and "uld" instruction
Date: Fri, 06 Oct 2000 18:35:15 -0700 [thread overview]
Message-ID: <39DE7DD3.7A67B19E@mvista.com> (raw)
In-Reply-To: 39DD68DE.E9B26A3D@mvista.com
Jun Sun wrote:
>
> Ralf, I notice you have fixed it in the CVS tree. Just did a test, and
> it looks good here.
>
I was too soon to say that ... :-)
While the __ldq_u() did work, I had a couple of syntax problems with
put_unaligned(). See the patch below.
In addition, my usb subsystem now hangs. It might mean a bug in the new
unaligned.h or the fix to unaligned.h reveals another bug. I will let
you know.
Jun
--- unaligned.h.ralf Fri Oct 6 18:32:34 2000
+++ unaligned.h Fri Oct 6 18:01:43 2000
@@ -117,20 +117,20 @@
__val;
\
})
-#define put_unaligned(x,ptr)
\
+#define put_unaligned(val,ptr)
\
do {
\
switch (sizeof(*(ptr))) {
\
case 1:
\
- *(unsigned char *)ptr = (val);
\
+ *(unsigned char *)(ptr) = (val);
\
break;
\
case 2:
\
- __stw_u(val, (unsigned short *)ptr);
\
+ __stw_u(val, (unsigned short *)(ptr));
\
break;
\
case 4:
\
- __stl_u(val, (unsigned int *)ptr);
\
+ __stl_u(val, (unsigned int *)(ptr));
\
break;
\
case 8:
\
- __stq_u(val, (unsigned long long *)ptr);
\
+ __stq_u(val, (unsigned long long *)(ptr));
\
break;
\
default:
\
__put_unaligned_bad_length();
\
next prev parent reply other threads:[~2000-10-06 21:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-09-25 18:48 load_unaligned() and "uld" instruction Jun Sun
2000-09-25 21:16 ` Dominic Sweetman
2000-09-25 21:36 ` Jun Sun
2000-09-25 23:29 ` Ralf Baechle
2000-09-26 6:22 ` Kevin D. Kissell
2000-09-26 6:22 ` Kevin D. Kissell
2000-09-26 9:08 ` Dominic Sweetman
2000-09-26 9:08 ` Dominic Sweetman
2000-09-29 17:22 ` Ralf Baechle
2000-10-09 14:49 ` Dominic Sweetman
2000-09-26 18:04 ` Jun Sun
2000-09-27 10:06 ` Maciej W. Rozycki
2000-10-06 0:43 ` Ralf Baechle
2000-10-06 9:54 ` Maciej W. Rozycki
2000-10-06 16:21 ` Ralf Baechle
2000-10-05 12:13 ` Ralf Baechle
2000-10-06 1:11 ` Jun Sun
2000-10-05 19:41 ` Kevin D. Kissell
2000-10-05 19:41 ` Kevin D. Kissell
2000-10-06 4:32 ` Jun Sun
2000-10-05 22:10 ` Kevin D. Kissell
2000-10-05 22:10 ` Kevin D. Kissell
2000-10-06 5:53 ` Jun Sun
2000-10-05 23:14 ` Kevin D. Kissell
2000-10-05 23:14 ` Kevin D. Kissell
2000-10-06 16:32 ` Ralf Baechle
2000-10-07 1:35 ` Jun Sun [this message]
2000-10-06 22:26 ` Ralf Baechle
2000-10-06 16:28 ` Ralf Baechle
2000-10-07 1:24 ` Jun Sun
2000-10-06 20:46 ` Kevin D. Kissell
2000-10-06 20:46 ` Kevin D. Kissell
2000-10-07 7:16 ` Jun Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39DE7DD3.7A67B19E@mvista.com \
--to=jsun@mvista.com \
--cc=linux-mips@fnet.fr \
--cc=linux-mips@oss.sgi.com \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox