* [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
@ 2007-08-06 15:09 Aurelien Jarno
2007-08-06 18:09 ` Michael Buesch
0 siblings, 1 reply; 9+ messages in thread
From: Aurelien Jarno @ 2007-08-06 15:09 UTC (permalink / raw)
To: Andrew Morton, linux-mips
Cc: Michael Buesch, Waldemar Brodkorb, Felix Fietkau,
Florian Schirmer
The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to
Kconfig.
Cc: Michael Buesch <mb@bu3sch.de>
Cc: Waldemar Brodkorb <wbx@openwrt.org>
Cc: Felix Fietkau <nbd@openwrt.org>
Cc: Florian Schirmer <jolt@tuxbox.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -38,6 +38,22 @@
Lemote Fulong mini-PC board based on the Chinese Loongson-2E CPU and
an FPGA northbridge
+config BCM947XX
+ bool "Support for BCM947xx based boards"
+ select DMA_NONCOHERENT
+ select HW_HAS_PCI
+ select IRQ_CPU
+ select SYS_HAS_CPU_MIPS32_R1
+ select SYS_SUPPORTS_32BIT_KERNEL
+ select SYS_SUPPORTS_LITTLE_ENDIAN
+ select SSB
+ select SSB_SERIAL
+ select SSB_DRIVER_PCICORE
+ select SSB_PCICORE_HOSTMODE
+ select GENERIC_GPIO
+ help
+ Support for BCM947xx based boards
+
config MACH_ALCHEMY
bool "Alchemy processor based machines"
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
2007-08-06 15:09 [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig Aurelien Jarno
@ 2007-08-06 18:09 ` Michael Buesch
2007-08-06 18:13 ` Felix Fietkau
2007-08-06 19:49 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig Aurelien Jarno
0 siblings, 2 replies; 9+ messages in thread
From: Michael Buesch @ 2007-08-06 18:09 UTC (permalink / raw)
To: Aurelien Jarno
Cc: Andrew Morton, linux-mips, Waldemar Brodkorb, Felix Fietkau,
Florian Schirmer
On Monday 06 August 2007, Aurelien Jarno wrote:
> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to
> Kconfig.
>
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Waldemar Brodkorb <wbx@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Florian Schirmer <jolt@tuxbox.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -38,6 +38,22 @@
> Lemote Fulong mini-PC board based on the Chinese Loongson-2E CPU and
> an FPGA northbridge
>
> +config BCM947XX
> + bool "Support for BCM947xx based boards"
> + select DMA_NONCOHERENT
> + select HW_HAS_PCI
Not sure what this does.
My 47xx machines do _not_ have a PCI bus.
> + select IRQ_CPU
> + select SYS_HAS_CPU_MIPS32_R1
> + select SYS_SUPPORTS_32BIT_KERNEL
> + select SYS_SUPPORTS_LITTLE_ENDIAN
> + select SSB
> + select SSB_SERIAL
> + select SSB_DRIVER_PCICORE
> + select SSB_PCICORE_HOSTMODE
Shouldn't we leave the PCICORE an option instead of force selecting
it here?
My WRT54G doesn't have a (usable) PCI core. So it would work
without the driver for it.
Especially on the small WAP54G disabling PCIcore support could
be useful to reduce the kernel size.
> + select GENERIC_GPIO
> + help
> + Support for BCM947xx based boards
> +
> config MACH_ALCHEMY
> bool "Alchemy processor based machines"
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
2007-08-06 18:09 ` Michael Buesch
@ 2007-08-06 18:13 ` Felix Fietkau
2007-08-06 18:24 ` Michael Buesch
2007-08-06 19:49 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig Aurelien Jarno
1 sibling, 1 reply; 9+ messages in thread
From: Felix Fietkau @ 2007-08-06 18:13 UTC (permalink / raw)
To: Michael Buesch
Cc: Aurelien Jarno, Andrew Morton, linux-mips, Waldemar Brodkorb,
Florian Schirmer
Michael Buesch wrote:
> Shouldn't we leave the PCICORE an option instead of force selecting
> it here?
> My WRT54G doesn't have a (usable) PCI core. So it would work
> without the driver for it.
> Especially on the small WAP54G disabling PCIcore support could
> be useful to reduce the kernel size.
Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
the PCICORE option would be reasonable, since many 47xx devices do have pci.
- Felix
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
2007-08-06 18:13 ` Felix Fietkau
@ 2007-08-06 18:24 ` Michael Buesch
2007-08-06 18:33 ` Aurelien Jarno
2007-08-06 20:16 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2) Aurelien Jarno
0 siblings, 2 replies; 9+ messages in thread
From: Michael Buesch @ 2007-08-06 18:24 UTC (permalink / raw)
To: Felix Fietkau
Cc: Aurelien Jarno, Andrew Morton, linux-mips, Waldemar Brodkorb,
Florian Schirmer
On Monday 06 August 2007, Felix Fietkau wrote:
> Michael Buesch wrote:
>
> > Shouldn't we leave the PCICORE an option instead of force selecting
> > it here?
> > My WRT54G doesn't have a (usable) PCI core. So it would work
> > without the driver for it.
> > Especially on the small WAP54G disabling PCIcore support could
> > be useful to reduce the kernel size.
> Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
> the PCICORE option would be reasonable, since many 47xx devices do have pci.
Yeah, probably a good idea.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
2007-08-06 18:24 ` Michael Buesch
@ 2007-08-06 18:33 ` Aurelien Jarno
2007-08-06 20:16 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2) Aurelien Jarno
1 sibling, 0 replies; 9+ messages in thread
From: Aurelien Jarno @ 2007-08-06 18:33 UTC (permalink / raw)
To: Michael Buesch
Cc: Felix Fietkau, Andrew Morton, linux-mips, Waldemar Brodkorb,
Florian Schirmer
On Mon, Aug 06, 2007 at 08:24:53PM +0200, Michael Buesch wrote:
> On Monday 06 August 2007, Felix Fietkau wrote:
> > Michael Buesch wrote:
> >
> > > Shouldn't we leave the PCICORE an option instead of force selecting
> > > it here?
> > > My WRT54G doesn't have a (usable) PCI core. So it would work
> > > without the driver for it.
> > > Especially on the small WAP54G disabling PCIcore support could
> > > be useful to reduce the kernel size.
> > Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
> > the PCICORE option would be reasonable, since many 47xx devices do have pci.
>
> Yeah, probably a good idea.
>
I will send a new patch to fix that.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2)
2007-08-06 18:24 ` Michael Buesch
2007-08-06 18:33 ` Aurelien Jarno
@ 2007-08-06 20:16 ` Aurelien Jarno
2007-08-06 20:18 ` Michael Buesch
2007-08-06 20:32 ` Florian Schirmer
1 sibling, 2 replies; 9+ messages in thread
From: Aurelien Jarno @ 2007-08-06 20:16 UTC (permalink / raw)
To: Michael Buesch
Cc: Felix Fietkau, Andrew Morton, linux-mips, Waldemar Brodkorb,
Florian Schirmer
The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to
Kconfig and modify the SSB Kconfig to select SSB_PCICORE_HOSTMODE by
default with BCM947XX CPUs.
Cc: Michael Buesch <mb@bu3sch.de>
Cc: Waldemar Brodkorb <wbx@openwrt.org>
Cc: Felix Fietkau <nbd@openwrt.org>
Cc: Florian Schirmer <jolt@tuxbox.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -67,6 +67,20 @@
note that a kernel built with this option selected will not be
able to run on normal units.
+config BCM947XX
+ bool "BCM947xx based boards"
+ select DMA_NONCOHERENT
+ select HW_HAS_PCI
+ select IRQ_CPU
+ select SYS_HAS_CPU_MIPS32_R1
+ select SYS_SUPPORTS_32BIT_KERNEL
+ select SYS_SUPPORTS_LITTLE_ENDIAN
+ select SSB
+ select SSB_DRIVER_MIPS
+ select GENERIC_GPIO
+ help
+ Support for BCM947xx based boards
+
config MIPS_COBALT
bool "Cobalt Server"
select DMA_NONCOHERENT
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -67,6 +67,7 @@
config SSB_PCICORE_HOSTMODE
bool "Hostmode support for SSB PCI core"
depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
+ default y if BCM947XX
help
PCIcore hostmode operation (external PCI bus).
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2)
2007-08-06 20:16 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2) Aurelien Jarno
@ 2007-08-06 20:18 ` Michael Buesch
2007-08-06 20:32 ` Florian Schirmer
1 sibling, 0 replies; 9+ messages in thread
From: Michael Buesch @ 2007-08-06 20:18 UTC (permalink / raw)
To: Aurelien Jarno
Cc: Felix Fietkau, Andrew Morton, linux-mips, Waldemar Brodkorb,
Florian Schirmer
On Monday 06 August 2007 22:16:50 Aurelien Jarno wrote:
> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to
> Kconfig and modify the SSB Kconfig to select SSB_PCICORE_HOSTMODE by
> default with BCM947XX CPUs.
>
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Waldemar Brodkorb <wbx@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Florian Schirmer <jolt@tuxbox.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Acked-by: Michael Buesch <mb@bu3sch.de>
>
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -67,6 +67,20 @@
> note that a kernel built with this option selected will not be
> able to run on normal units.
>
> +config BCM947XX
> + bool "BCM947xx based boards"
> + select DMA_NONCOHERENT
> + select HW_HAS_PCI
> + select IRQ_CPU
> + select SYS_HAS_CPU_MIPS32_R1
> + select SYS_SUPPORTS_32BIT_KERNEL
> + select SYS_SUPPORTS_LITTLE_ENDIAN
> + select SSB
> + select SSB_DRIVER_MIPS
> + select GENERIC_GPIO
> + help
> + Support for BCM947xx based boards
> +
> config MIPS_COBALT
> bool "Cobalt Server"
> select DMA_NONCOHERENT
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -67,6 +67,7 @@
> config SSB_PCICORE_HOSTMODE
> bool "Hostmode support for SSB PCI core"
> depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> + default y if BCM947XX
> help
> PCIcore hostmode operation (external PCI bus).
>
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2)
2007-08-06 20:16 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2) Aurelien Jarno
2007-08-06 20:18 ` Michael Buesch
@ 2007-08-06 20:32 ` Florian Schirmer
1 sibling, 0 replies; 9+ messages in thread
From: Florian Schirmer @ 2007-08-06 20:32 UTC (permalink / raw)
To: Aurelien Jarno
Cc: Michael Buesch, Felix Fietkau, Andrew Morton, linux-mips,
Waldemar Brodkorb
Hi,
Aurelien Jarno wrote:
> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to
> Kconfig and modify the SSB Kconfig to select SSB_PCICORE_HOSTMODE by
> default with BCM947XX CPUs.
>
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Waldemar Brodkorb <wbx@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Florian Schirmer <jolt@tuxbox.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
>
Looks good!
Acked-by: Florian Schirmer <jolt@tuxbox.org>
Best,
Florian
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -67,6 +67,20 @@
> note that a kernel built with this option selected will not be
> able to run on normal units.
>
> +config BCM947XX
> + bool "BCM947xx based boards"
> + select DMA_NONCOHERENT
> + select HW_HAS_PCI
> + select IRQ_CPU
> + select SYS_HAS_CPU_MIPS32_R1
> + select SYS_SUPPORTS_32BIT_KERNEL
> + select SYS_SUPPORTS_LITTLE_ENDIAN
> + select SSB
> + select SSB_DRIVER_MIPS
> + select GENERIC_GPIO
> + help
> + Support for BCM947xx based boards
> +
> config MIPS_COBALT
> bool "Cobalt Server"
> select DMA_NONCOHERENT
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -67,6 +67,7 @@
> config SSB_PCICORE_HOSTMODE
> bool "Hostmode support for SSB PCI core"
> depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> + default y if BCM947XX
> help
> PCIcore hostmode operation (external PCI bus).
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
2007-08-06 18:09 ` Michael Buesch
2007-08-06 18:13 ` Felix Fietkau
@ 2007-08-06 19:49 ` Aurelien Jarno
1 sibling, 0 replies; 9+ messages in thread
From: Aurelien Jarno @ 2007-08-06 19:49 UTC (permalink / raw)
To: Michael Buesch
Cc: Andrew Morton, linux-mips, Waldemar Brodkorb, Felix Fietkau,
Florian Schirmer
Michael Buesch a écrit :
> On Monday 06 August 2007, Aurelien Jarno wrote:
>> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to
>> Kconfig.
>>
>> Cc: Michael Buesch <mb@bu3sch.de>
>> Cc: Waldemar Brodkorb <wbx@openwrt.org>
>> Cc: Felix Fietkau <nbd@openwrt.org>
>> Cc: Florian Schirmer <jolt@tuxbox.org>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -38,6 +38,22 @@
>> Lemote Fulong mini-PC board based on the Chinese Loongson-2E CPU and
>> an FPGA northbridge
>>
>> +config BCM947XX
>> + bool "Support for BCM947xx based boards"
>> + select DMA_NONCOHERENT
>> + select HW_HAS_PCI
>
> Not sure what this does.
> My 47xx machines do _not_ have a PCI bus.
Without HW_HAS_PCI, it is not possible to enable the PCI bus, as it
depends on this variable. However having it defined, does not mean the
PCI bus has to be enabled.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2007-08-06 20:34 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-06 15:09 [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig Aurelien Jarno
2007-08-06 18:09 ` Michael Buesch
2007-08-06 18:13 ` Felix Fietkau
2007-08-06 18:24 ` Michael Buesch
2007-08-06 18:33 ` Aurelien Jarno
2007-08-06 20:16 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2) Aurelien Jarno
2007-08-06 20:18 ` Michael Buesch
2007-08-06 20:32 ` Florian Schirmer
2007-08-06 19:49 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox