* [PATCH] MIPS: kernel: proc: Fix typo in proc.c
@ 2015-11-03 16:39 Tony Wu
2015-11-03 16:42 ` Markos Chandras
2015-11-03 17:15 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Tony Wu @ 2015-11-03 16:39 UTC (permalink / raw)
To: linux-mips, ralf; +Cc: Markos Chandras
Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add
MIPS R6 support to /proc/cpuinfo), mips1 should be tested against
cpu_has_mips_1, not cpu_has_mips_r1.
Signed-off-by: Tony Wu <tung7970@gmail.com>
Cc: Markos Chandras <markos.chandras@imgtec.com>
diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
index 211fcd4..3417ce0 100644
--- a/arch/mips/kernel/proc.c
+++ b/arch/mips/kernel/proc.c
@@ -83,7 +83,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
}
seq_printf(m, "isa\t\t\t:");
- if (cpu_has_mips_r1)
+ if (cpu_has_mips_1)
seq_printf(m, " mips1");
if (cpu_has_mips_2)
seq_printf(m, "%s", " mips2");
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: kernel: proc: Fix typo in proc.c
2015-11-03 16:39 [PATCH] MIPS: kernel: proc: Fix typo in proc.c Tony Wu
@ 2015-11-03 16:42 ` Markos Chandras
2015-11-03 16:42 ` Markos Chandras
2015-11-03 17:15 ` Sergei Shtylyov
1 sibling, 1 reply; 4+ messages in thread
From: Markos Chandras @ 2015-11-03 16:42 UTC (permalink / raw)
To: Tony Wu, linux-mips, ralf
On 11/03/2015 04:39 PM, Tony Wu wrote:
> Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add
> MIPS R6 support to /proc/cpuinfo), mips1 should be tested against
> cpu_has_mips_1, not cpu_has_mips_r1.
>
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
>
> diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
> index 211fcd4..3417ce0 100644
> --- a/arch/mips/kernel/proc.c
> +++ b/arch/mips/kernel/proc.c
> @@ -83,7 +83,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
> }
>
> seq_printf(m, "isa\t\t\t:");
> - if (cpu_has_mips_r1)
> + if (cpu_has_mips_1)
> seq_printf(m, " mips1");
> if (cpu_has_mips_2)
> seq_printf(m, "%s", " mips2");
>
Good catch. Might worth adding CC:stable #v4.0+ as well
--
markos
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: kernel: proc: Fix typo in proc.c
2015-11-03 16:42 ` Markos Chandras
@ 2015-11-03 16:42 ` Markos Chandras
0 siblings, 0 replies; 4+ messages in thread
From: Markos Chandras @ 2015-11-03 16:42 UTC (permalink / raw)
To: Tony Wu, linux-mips, ralf
On 11/03/2015 04:39 PM, Tony Wu wrote:
> Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add
> MIPS R6 support to /proc/cpuinfo), mips1 should be tested against
> cpu_has_mips_1, not cpu_has_mips_r1.
>
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
>
> diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
> index 211fcd4..3417ce0 100644
> --- a/arch/mips/kernel/proc.c
> +++ b/arch/mips/kernel/proc.c
> @@ -83,7 +83,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
> }
>
> seq_printf(m, "isa\t\t\t:");
> - if (cpu_has_mips_r1)
> + if (cpu_has_mips_1)
> seq_printf(m, " mips1");
> if (cpu_has_mips_2)
> seq_printf(m, "%s", " mips2");
>
Good catch. Might worth adding CC:stable #v4.0+ as well
--
markos
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: kernel: proc: Fix typo in proc.c
2015-11-03 16:39 [PATCH] MIPS: kernel: proc: Fix typo in proc.c Tony Wu
2015-11-03 16:42 ` Markos Chandras
@ 2015-11-03 17:15 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2015-11-03 17:15 UTC (permalink / raw)
To: Tony Wu, linux-mips, ralf; +Cc: Markos Chandras
Hello.
On 11/03/2015 07:39 PM, Tony Wu wrote:
> Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add
Please run the patch scripts/checkpatch.pl -- it now enforces certain
style of the commit citing.
> MIPS R6 support to /proc/cpuinfo), mips1 should be tested against
> cpu_has_mips_1, not cpu_has_mips_r1.
>
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-03 17:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 16:39 [PATCH] MIPS: kernel: proc: Fix typo in proc.c Tony Wu
2015-11-03 16:42 ` Markos Chandras
2015-11-03 16:42 ` Markos Chandras
2015-11-03 17:15 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox