* [PATCH] mips: dts: ralink: mt7621: define each reset as an item
@ 2023-09-17 10:37 Arınç ÜNAL
2023-09-18 8:29 ` Sergio Paracuellos
2023-10-06 8:22 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Arınç ÜNAL @ 2023-09-17 10:37 UTC (permalink / raw)
To: Arınç ÜNAL, Sergio Paracuellos, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thomas Bogendoerfer,
Matthias Brugger, AngeloGioacchino Del Regno
Cc: linux-mips, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek
Each item of the resets property should define a reset. Split the item with
two resets on the ethernet node into two separate items.
Sort the items of the clocks property to the same line as a trivial change.
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
arch/mips/boot/dts/ralink/mt7621.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index 7caed0d14f11..35a10258f235 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -300,14 +300,13 @@ ethernet: ethernet@1e100000 {
compatible = "mediatek,mt7621-eth";
reg = <0x1e100000 0x10000>;
- clocks = <&sysc MT7621_CLK_FE>,
- <&sysc MT7621_CLK_ETH>;
+ clocks = <&sysc MT7621_CLK_FE>, <&sysc MT7621_CLK_ETH>;
clock-names = "fe", "ethif";
#address-cells = <1>;
#size-cells = <0>;
- resets = <&sysc MT7621_RST_FE &sysc MT7621_RST_ETH>;
+ resets = <&sysc MT7621_RST_FE>, <&sysc MT7621_RST_ETH>;
reset-names = "fe", "eth";
interrupt-parent = <&gic>;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mips: dts: ralink: mt7621: define each reset as an item
2023-09-17 10:37 [PATCH] mips: dts: ralink: mt7621: define each reset as an item Arınç ÜNAL
@ 2023-09-18 8:29 ` Sergio Paracuellos
2023-10-06 8:22 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Sergio Paracuellos @ 2023-09-18 8:29 UTC (permalink / raw)
To: Arınç ÜNAL
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thomas Bogendoerfer, Matthias Brugger, AngeloGioacchino Del Regno,
linux-mips, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek
On Sun, Sep 17, 2023 at 12:38 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> Each item of the resets property should define a reset. Split the item with
> two resets on the ethernet node into two separate items.
>
> Sort the items of the clocks property to the same line as a trivial change.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Thanks,
Sergio Paracuellos
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mips: dts: ralink: mt7621: define each reset as an item
2023-09-17 10:37 [PATCH] mips: dts: ralink: mt7621: define each reset as an item Arınç ÜNAL
2023-09-18 8:29 ` Sergio Paracuellos
@ 2023-10-06 8:22 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2023-10-06 8:22 UTC (permalink / raw)
To: Arınç ÜNAL
Cc: Sergio Paracuellos, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
linux-mips, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek
On Sun, Sep 17, 2023 at 01:37:53PM +0300, Arınç ÜNAL wrote:
> Each item of the resets property should define a reset. Split the item with
> two resets on the ethernet node into two separate items.
>
> Sort the items of the clocks property to the same line as a trivial change.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 7caed0d14f11..35a10258f235 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -300,14 +300,13 @@ ethernet: ethernet@1e100000 {
> compatible = "mediatek,mt7621-eth";
> reg = <0x1e100000 0x10000>;
>
> - clocks = <&sysc MT7621_CLK_FE>,
> - <&sysc MT7621_CLK_ETH>;
> + clocks = <&sysc MT7621_CLK_FE>, <&sysc MT7621_CLK_ETH>;
> clock-names = "fe", "ethif";
>
> #address-cells = <1>;
> #size-cells = <0>;
>
> - resets = <&sysc MT7621_RST_FE &sysc MT7621_RST_ETH>;
> + resets = <&sysc MT7621_RST_FE>, <&sysc MT7621_RST_ETH>;
> reset-names = "fe", "eth";
>
> interrupt-parent = <&gic>;
> --
> 2.39.2
>
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-06 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-17 10:37 [PATCH] mips: dts: ralink: mt7621: define each reset as an item Arınç ÜNAL
2023-09-18 8:29 ` Sergio Paracuellos
2023-10-06 8:22 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox