Re: [PATCH RFC v3 57/88] vfio: Dispatch guest_memfd provider operations via vfio_device_ops

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] vfio: stray forward declaration before vfio_device_ops breaks
  kernel-doc
--

commit cc851a01b26fbe73cfc6ac69613c43e8df1f4787
Author: Ackerley Tng <ackerleytng@google.com>

vfio: Dispatch guest_memfd provider operations via vfio_device_ops

This commit implements guest_memfd provider operations on vfio_device_fops
and adds gmem_attach and gmem_release callbacks to struct vfio_device_ops.

> diff --git a/include/linux/vfio.h b/include/linux/vfio.h
> index c81373ddf2a9c..65dc2cb523351 100644
> --- a/include/linux/vfio.h
> +++ b/include/linux/vfio.h

[ ... ]

> @@ -114,7 +117,11 @@ struct vfio_device {
>   *             this device is attached to.
>   * @device_feature: Optional, fill in the VFIO_DEVICE_FEATURE ioctl
>   */
> +struct guest_memfd_provider_operations;
> +
>  struct vfio_device_ops {
> +	int (*gmem_attach)(struct vfio_device *device);
> +	void (*gmem_release)(struct vfio_device *device);
>  	char	*name;
>  	int	(*init)(struct vfio_device *vdev);
>  	void	(*release)(struct vfio_device *vdev);

[Severity: Low]
Does placing struct guest_memfd_provider_operations between the kernel-doc
comment and struct vfio_device_ops break kernel-doc parsing for this
header?

scripts/kernel-doc stops collecting the prototype at the first top-level
semicolon after a kernel-doc comment, so it tries to parse the unused
forward declaration as the struct definition and fails with "error: Cannot
parse struct or union!".  In addition, @gmem_attach and @gmem_release are
not documented in the struct vfio_device_ops kernel-doc comment above.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-gmem-alternative-providers-v3-0-8484dde66a7e@google.com?part=57