From: sashiko-bot@kernel.org
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: linux-mm@kvack.org, linux-security-module@vger.kernel.org,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Ben Segall" <bsegall@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"David Hildenbrand" <david@kernel.org>,
"David Howells" <dhowells@redhat.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Ingo Molnar" <mingo@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Jonathan Corbet" <corbet@lwn.net>,
"John Johansen" <john.johansen@canonical.com>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Kees Cook" <kees@kernel.org>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Liam R. Howlett" <liam@infradead.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Manfred Spraul" <manfred@colorfullife.com>,
"Mel Gorman" <mgorman@suse.de>, "Michal Hocko" <mhocko@suse.com>,
"Mike Rapoport" <rppt@kernel.org>, "Neal Gompa" <neal@gompa.dev>,
"Paul Moore" <paul@paul-moore.com>,
"Pavel Tikhomirov" <ptikhomirov@virtuozzo.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Serge Hallyn" <sergeh@kernel.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Valentin Schneider" <vschneid@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Zygmunt Krynicki" <zygmunt.krynicki@canonical.com>
Subject: Re: [RFC PATCH v2 04/13] rootns: Add rootns_create() system call
Date: Wed, 18 Nov 2026 23:15:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-222158@kernel.org> (raw)
In-Reply-To: <20261117231352.3816603-5-jarkko@kernel.org>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] rootns: UAF via unreferenced pid_ns->rootns in create_rootns()
- [High] rootns: cred->user mismatch in create_rootns_creds() for
ROOTNS_USER
--
commit 58de372391f170ac432dcc21ea8238b956c72a12
Author: Jarkko Sakkinen <jarkko@kernel.org>
rootns: Add rootns_create() system call
This commit adds the rootns_create() system call to allocate a detached
root namespace with dedicated mount and PID namespaces, optional extra
namespaces, and credentials, returning a control file descriptor.
> diff --git a/kernel/rootns.c b/kernel/rootns.c
> index e3b203322ae23..caa810b65d0da 100644
> --- a/kernel/rootns.c
> +++ b/kernel/rootns.c
> @@ -145,3 +145,142 @@ void exit_rootns(struct pid_namespace *pid_ns, struct task_struct *tsk)
> wake_up_poll(&c->waitq, EPOLLHUP);
> put_rootns(c);
> }
> +
> +/*
> + * Create credentials for a rootns. Drop keyrings from the new credential to
> + * avoid unnecessary pinning.
> + */
> +static const struct cred *create_rootns_creds(unsigned int flags)
> +{
> + struct cred *new;
> + int ret;
> +
> + new = prepare_creds();
> + if (!new)
> + return ERR_PTR(-ENOMEM);
> +
> +#ifdef CONFIG_KEYS
> + key_put(new->thread_keyring);
> + new->thread_keyring = NULL;
> + key_put(new->process_keyring);
> + new->process_keyring = NULL;
> + key_put(new->session_keyring);
> + new->session_keyring = NULL;
> + key_put(new->request_key_auth);
> + new->request_key_auth = NULL;
> +#endif
> + if (!(flags & ROOTNS_USER))
> + return new;
> +
> + ret = create_user_ns(new);
> + if (ret < 0)
> + goto err;
> + new->euid = new->user_ns->owner;
> + new->egid = new->user_ns->group;
> +
> + new->uid = new->euid;
> + new->suid = new->euid;
> + new->fsuid = new->euid;
> + new->gid = new->egid;
> + new->sgid = new->egid;
> + new->fsgid = new->egid;
> + ret = set_cred_ucounts(new);
> + if (ret < 0)
> + goto err;
> + return new;
[Severity: High]
Does overwriting new->uid with new->euid without updating new->user leave
cred->user out of sync when the caller's real and effective UIDs differ?
prepare_creds() clones new->user from current->cred->user (the caller's
real UID). If a process with real UID 0 switches its effective UID via
seteuid() before calling rootns_create(ROOTNS_USER), new->uid and
new->ucounts are set to the unprivileged effective UID, while new->user
remains INIT_USER. Tasks entering the rootns then bypass the RLIMIT_NPROC
check in copy_process() (which skips enforcement when
p->real_cred->user == INIT_USER) and charge per-user_struct resources to
the wrong user_struct.
Allocating the matching user_struct with alloc_uid(new->uid) and releasing
the old one with free_uid(new->user), as set_user() does in kernel/sys.c,
would keep cred->user consistent with cred->uid.
> +
> +err:
> + abort_creds(new);
> + return ERR_PTR(ret);
> +}
> +
> +/*
> + * Create a new rootns.
> + */
> +static struct rootns *create_rootns(unsigned int flags)
> +{
[ ... ]
> + ns = create_new_namespaces(clone_flags, current->nsproxy, cred->user_ns,
> + NULL);
> + if (IS_ERR(ns)) {
> + ret = PTR_ERR(ns);
> + goto err_put;
> + }
> +
> + c->ns = ns;
> + ns->pid_ns_for_children->rootns = c;
> + nsproxy_ns_active_get(ns);
[Severity: High]
Can storing an uncounted pointer in ns->pid_ns_for_children->rootns lead
to a use-after-free in exit_rootns()?
create_new_namespaces() adds ns->pid_ns_for_children to the namespace
tree, and nsproxy_ns_active_get() marks it active before any init task is
forked into the rootns. However, the reference on c that pairs with
exit_rootns() is only taken in copy_rootns() when c->state is
ROOTNS_FORKING, and put_rootns() does not clear
c->ns->pid_ns_for_children->rootns:
kernel/rootns.c:copy_rootns() {
if (likely(!c || READ_ONCE(c->state) != ROOTNS_FORKING))
return;
scoped_guard(spinlock, &c->lock) {
get_rootns(c);
...
}
If a process with CAP_SYS_ADMIN in init_user_ns opens the active PID
namespace via open_by_handle_at(FD_NSFS_ROOT, ...), enters it with
setns(), and forks a child while c->state is still ROOTNS_EMPTY, that
child becomes the PID namespace's child_reaper without copy_rootns()
taking a reference on c. When the child exits, zap_pid_ns_processes()
calls exit_rootns(), which dereferences the dangling pid_ns->rootns
pointer if the rootns fd was already closed, or drops the control fd's
sole reference on c while the fd is still open.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117231352.3816603-1-jarkko@kernel.org?part=4
next prev parent reply other threads:[~2026-11-18 23:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 23:13 [RFC PATCH v2 00/13] Namespace for namespace roots Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 01/13] nsproxy: Pass nsproxy to create_new_namespaces() Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 02/13] rootns: Add core infrastructure for root namespaces Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 03/13] rootns: Track init lifecycle via copy_process() and pid_namespace Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot
2026-11-17 23:13 ` [RFC PATCH v2 04/13] rootns: Add rootns_create() system call Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot [this message]
2026-11-17 23:13 ` [RFC PATCH v2 05/13] rootns: Add rootns_wait() " Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot
2026-11-17 23:13 ` [RFC PATCH v2 06/13] rootns: Add rootns_kill() " Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot
2026-11-17 23:13 ` [RFC PATCH v2 07/13] fork: Support CLONE_INTO_ROOTNS in clone3() Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot
2026-11-17 23:13 ` [RFC PATCH v2 08/13] fs: Support FSCONFIG_SET_ROOTNS in fsconfig() Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot
2026-11-17 23:13 ` [RFC PATCH v2 09/13] fs: Support installing rootns mount trees via move_mount() Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot
2026-11-17 23:13 ` [RFC PATCH v2 10/13] arch: Wire up rootns system calls Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 11/13] docs: Document root namespace uAPI Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 12/13] selftests/rootns: Add root namespace test suite Jarkko Sakkinen
2026-11-18 23:15 ` sashiko-bot
2026-11-17 23:13 ` [RFC PATCH v2 13/13] MAINTAINERS: Add entry for ROOT NAMESPACE Jarkko Sakkinen
2026-11-18 14:47 ` [RFC PATCH v2 00/13] Namespace for namespace roots Josef Bacik
2026-11-18 15:28 ` Jarkko Sakkinen
2026-11-18 15:39 ` Jarkko Sakkinen
2026-11-18 15:46 ` Jarkko Sakkinen
2026-11-18 16:59 ` Andy Lutomirski
2026-11-18 17:04 ` Jarkko Sakkinen
2026-11-18 17:08 ` Jarkko Sakkinen
2026-11-18 17:30 ` Jarkko Sakkinen
2026-11-18 17:46 ` Andy Lutomirski
2026-11-18 18:23 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222158@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=corbet@lwn.net \
--cc=dave@stgolabs.net \
--cc=david@kernel.org \
--cc=dhowells@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=jack@suse.cz \
--cc=jarkko@kernel.org \
--cc=john.johansen@canonical.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=liam@infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=luto@amacapital.net \
--cc=manfred@colorfullife.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=neal@gompa.dev \
--cc=paul@paul-moore.com \
--cc=peterz@infradead.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sergeh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=zygmunt.krynicki@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox