Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Krzysztof Kozlowski <krzk@kernel.org>]

On Wed, Jan 14, 2026 at 03:18:47PM +0530, Neeraj Soni wrote:
> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
> So add the qcom,ice property to reference it.
> 
> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 938be8228d66..8a6a25ceabe1 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -140,6 +140,10 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: platform specific settings for DLL_CONFIG reg.
>  
> +  qcom,ice:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to the Inline Crypto Engine node

Description should also say: for what purpose.

You either have this phandle or ICE address space on sc7280 and newer.
You cannot have both, so your schema should encode it properly.

Otherwise you just sent something which already was on the list and it
even was reviewed:

https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/

You even copied the commit msg but did copy the authorship!

Anyway v3 and v4 were not correct and probably v2 should be used after
adjusting it with my comments.


Best regards,
Krzysztof