From: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
Date: Mon, 19 Jan 2026 15:26:09 +0530 [thread overview]
Message-ID: <f38e390e-dba9-d02a-e5dd-8eed3d0ebdc4@oss.qualcomm.com> (raw)
In-Reply-To: <0f1afc5e-d5f4-444e-819c-594f0b1e125b@kernel.org>
Hi,
On 1/16/2026 12:49 PM, Krzysztof Kozlowski wrote:
> On 16/01/2026 06:59, Neeraj Soni wrote:
>>> Why this became uppercase?
>> Thnaks for pointing out. I will fix this next patch.
>>>
>>>> + compatible = "qcom,sc7280-inline-crypto-engine",
>>>> + "qcom,inline-crypto-engine";
>>>> + reg = <0x0 0x007C8000 0x0 0x18000>;
>>>
>>> And this? there is no uppercase at all, so maybye you copied it from
>>> downstream, but that's not right approach - do not use downstream code.
>>>
>> Yes it was copied but i missed to align with upstream. Thanks for pointing out. This will be fixed in next patch.
>
> And that's the problem. You must NEVER COPY downstream DTS. We repeat it
> and repeat it...
>
Sure and i apologize for missing this. I will be fixing this in next patch and will ensure this is not repeated
in any future posts.
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-01-19 9:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 9:48 [PATCH v2 0/2] Enable Inline crypto engine for kodiak Neeraj Soni
2026-01-14 9:48 ` [PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni
2026-01-15 9:03 ` Krzysztof Kozlowski
2026-01-16 6:50 ` Neeraj Soni
2026-01-16 7:18 ` Krzysztof Kozlowski
2026-01-19 9:47 ` Neeraj Soni
2026-01-19 10:35 ` Krzysztof Kozlowski
2026-01-14 9:48 ` [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni
2026-01-15 9:05 ` Krzysztof Kozlowski
2026-01-16 5:59 ` Neeraj Soni
2026-01-16 7:19 ` Krzysztof Kozlowski
2026-01-19 9:56 ` Neeraj Soni [this message]
2026-01-14 16:18 ` [PATCH v2 0/2] Enable Inline crypto engine for kodiak Rob Herring
2026-01-16 16:54 ` Krzysztof Kozlowski
2026-01-19 10:04 ` Neeraj Soni
2026-01-20 1:29 ` Rob Herring
2026-01-19 12:48 ` Neeraj Soni
2026-01-20 1:25 ` Rob Herring
2026-01-20 6:24 ` Neeraj Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f38e390e-dba9-d02a-e5dd-8eed3d0ebdc4@oss.qualcomm.com \
--to=neeraj.soni@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox