From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Abel Vesa <abel.vesa@linaro.org>,
Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle
Date: Mon, 2 Mar 2026 17:38:32 +0100 [thread overview]
Message-ID: <3339ddcb-d0f5-4117-99fd-f3f158b7903d@kernel.org> (raw)
In-Reply-To: <06967254-7fa6-218e-db8a-8e4a118a7d24@oss.qualcomm.com>
On 02/03/2026 12:25, Neeraj Soni wrote:
>
>
> On 3/2/2026 2:27 PM, Krzysztof Kozlowski wrote:
>> On 02/03/2026 08:48, Krzysztof Kozlowski wrote:
>>> On 02/03/2026 08:45, Neeraj Soni wrote:
>>>>
>>>>
>>>> On 2/19/2026 1:57 PM, Krzysztof Kozlowski wrote:
>>>>> On 19/02/2026 06:38, Neeraj Soni wrote:
>>>>>>>>
>>>>>>>> + - if:
>>>>>>>> + required:
>>>>>>>> + - qcom,ice
>>>>>>>> + then:
>>>>>>>> + properties:
>>>>>>>> + reg-names:
>>>>>>>> + not:
>>>>>>>> + contains:
>>>>>>>> + const: ice
>>>>>>>
>>>>>>> And reg is still 4? This is not correct syntax. You need to define
>>>>>>> proper and final constraints per each device. I would write example, but
>>>>>>> why... more things you could just ignore.
>>>>>>>
>>>>>> I had included changes for reg in v3:
>>>>>> https://lore.kernel.org/all/20260206112053.3287756-2-neeraj.soni@oss.qualcomm.com/
>>>>>>
>>>>>> but those were not reviewed so i assume them to be incorrect and dropped it.
>>>>>> Will fix this in next patch and post.
>>>>>>
>>>>> Patch v3 was also not correct, because SDHCI v5 devices should have 1 or
>>>>> 2 entries, not 1-3 as previous patch said.
>>>>>
>>>> This is not clear to me. Here:
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n80
>>>> it says the entries should be 1-4 and there are no v5 specific constraints.
>>>
>>> There are, just scroll.
>>
>> Here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n212
>>
> Yes i had looked at this but, as i understand, this constraints the minItems: not the
> maxItems: and in your comment here:
>
> https://lore.kernel.org/all/21a87714-cd11-4217-a2aa-82fddc3a8530@kernel.org/
>
> you expect v5 entries to be constrained to 1-2 and not 1-3. So, as i understand from here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n78
>
> the v5 can have 1-4 entries without "qcom,ice" and 1-3 with it which is what i had posted.
We have long discussion and you are just not replying to the problem. I
am done here. I wrote already what is wrong and what I expect.
Repeating the same as before in the FIRST comment: Your patch allows
incorrectly four reg entries for v4 and there reg entries for v5.
That's a NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-02 16:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 5:25 [PATCH v4 0/3] Enable Inline crypto engine for kodiak and monaco Neeraj Soni
2026-02-17 5:25 ` [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni
2026-02-17 20:16 ` Krzysztof Kozlowski
2026-02-19 5:38 ` Neeraj Soni
2026-02-19 7:20 ` Krzysztof Kozlowski
2026-02-19 8:09 ` Neeraj Soni
2026-02-19 8:27 ` Krzysztof Kozlowski
2026-03-02 7:45 ` Neeraj Soni
2026-03-02 7:48 ` Krzysztof Kozlowski
2026-03-02 8:57 ` Krzysztof Kozlowski
2026-03-02 11:25 ` Neeraj Soni
2026-03-02 16:38 ` Krzysztof Kozlowski [this message]
2026-03-04 7:28 ` Neeraj Soni
2026-02-17 5:25 ` [PATCH v4 2/3] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni
2026-02-17 5:25 ` [PATCH v4 3/3] arm64: dts: qcom: monaco: " Neeraj Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3339ddcb-d0f5-4117-99fd-f3f158b7903d@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=abhinaba.rakshit@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox