From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Abel Vesa <abel.vesa@linaro.org>,
Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle
Date: Thu, 19 Feb 2026 08:20:02 +0100 [thread overview]
Message-ID: <51d75568-5110-4993-b262-71af0a0d4600@kernel.org> (raw)
In-Reply-To: <e3ac0681-605d-c1df-e4f0-78a2c142fa66@oss.qualcomm.com>
On 19/02/2026 06:38, Neeraj Soni wrote:
>>> + qcom,ice:
>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>> + description:
>>> + phandle to the Inline Crypto Engine (ICE) hardware block for this controller.
>>
>>
>> Srsly, I asked once and not much improved. What is explicitly written in
>> coding style which I asked you twice to read?
>>
> I have attempted to modifiy it as per the comment you gave in v3 here:
> https://lore.kernel.org/all/b6e510da-b369-4c43-b9a1-455478af4948@kernel.org/
>
> I will rephrase it to explain the usage better in next patch.
>
>> And how long is this line? Why such trivialities cannot be fixed and I
>> need to remind this every time?
>>
> It is 83 character long but i understand now you expect it to be wrapped
> at 75 as per kernel coding style. I missed it and stuck to the limit
75?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-19 7:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 5:25 [PATCH v4 0/3] Enable Inline crypto engine for kodiak and monaco Neeraj Soni
2026-02-17 5:25 ` [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni
2026-02-17 20:16 ` Krzysztof Kozlowski
2026-02-19 5:38 ` Neeraj Soni
2026-02-19 7:20 ` Krzysztof Kozlowski [this message]
2026-02-19 8:09 ` Neeraj Soni
2026-02-19 8:27 ` Krzysztof Kozlowski
2026-03-02 7:45 ` Neeraj Soni
2026-03-02 7:48 ` Krzysztof Kozlowski
2026-03-02 8:57 ` Krzysztof Kozlowski
2026-03-02 11:25 ` Neeraj Soni
2026-03-02 16:38 ` Krzysztof Kozlowski
2026-03-04 7:28 ` Neeraj Soni
2026-02-17 5:25 ` [PATCH v4 2/3] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni
2026-02-17 5:25 ` [PATCH v4 3/3] arm64: dts: qcom: monaco: " Neeraj Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51d75568-5110-4993-b262-71af0a0d4600@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=abhinaba.rakshit@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox