[PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase

[PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase

[IKEGAMI Tokunori]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

The flash erase error is caused on the Macronix flash device below.
  MX29GL512FHT2I-11G
Also it has been just confirmed to be able to reproduce.
And the retry function can resolved the flash erase error correctly.

The commit message of PATCH v4 2/2 was not correct so let me resend patches.

Tokunori Ikegami (2):
  mtd: cfi_cmdset_0002: Change definition naming to retry write 
    operation
  mtd: cfi_cmdset_0002: Change erase functions to retry for error

 drivers/mtd/chips/cfi_cmdset_0002.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

-- 
2.16.1

Re: [PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase

[Boris Brezillon]

On Mon, 14 May 2018 02:11:48 +0000
IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:

> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> 
> The flash erase error is caused on the Macronix flash device below.
>   MX29GL512FHT2I-11G
> Also it has been just confirmed to be able to reproduce.
> And the retry function can resolved the flash erase error correctly.
> 
> The commit message of PATCH v4 2/2 was not correct so let me resend patches.

Can you please use git send-email when you send your patch series, so
that they are properly threaded.

> 
> Tokunori Ikegami (2):
>   mtd: cfi_cmdset_0002: Change definition naming to retry write 
>     operation
>   mtd: cfi_cmdset_0002: Change erase functions to retry for error
> 
>  drivers/mtd/chips/cfi_cmdset_0002.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 

RE: [PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase

[IKEGAMI Tokunori]

Hi Boris-san,

Thanks for your reviewing.

> Can you please use git send-email when you send your patch series, so
> that they are properly threaded.

  Yes I have just resend the v5 patch series by using git send-email.
  But the source address is set as smtpuser <smtpuser@allied-telesis.co.jp>.
  This is required on our company mail system currently.
  But please do not reply to the address but reply to my email address below.
    Tokunori Ikegami <ikegami at allied-telesis.co.jp>

  Note: I am asking to resolve this issue to our IS department currently.

  I have just resend the patch series so please review the last patch series.
  Very sorry for resending the patch series many times.

Regards,
Ikegami

Re: [PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase

[Boris Brezillon]

On Mon, 14 May 2018 09:32:01 +0000
IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:

> Hi Boris-san,
> 
> Thanks for your reviewing.
> 
> > Can you please use git send-email when you send your patch series, so
> > that they are properly threaded.  
> 
>   Yes I have just resend the v5 patch series by using git send-email.
>   But the source address is set as smtpuser <smtpuser@allied-telesis.co.jp>.
>   This is required on our company mail system currently.
>   But please do not reply to the address but reply to my email address below.
>     Tokunori Ikegami <ikegami at allied-telesis.co.jp>

There's still a problem: the patches do not appear as a thread. Can you
paste the git send-email command you use?

> 
>   Note: I am asking to resolve this issue to our IS department currently.
> 
>   I have just resend the patch series so please review the last patch series.
>   Very sorry for resending the patch series many times.

It seems that nothing has changed, so nothing more to review on my
side. And I'm still not entirely convinced by the fix, but if nobody
complains, I'll apply it. BTW, the changelog is really not clear, you
should have something like:

Changes since v4:
- blabla
- blablabla

Changes since v3:
- blabla
- blablabla

Changes since v2:
- blabla
- blablabla

Changes since v1:
- blabla
- blablabla

RE: [PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase

[IKEGAMI Tokunori]

Hi Boris-san,

Thanks for the comments.

> There's still a problem: the patches do not appear as a thread. Can you
> paste the git send-email command you use?

  The command that I used is below.
    git send-email v5-0000-cover-letter.patch v5-0001-mtd-cfi_cmdset_0002-Change-definition-naming-to-r.patch v5-0002-mtd-cfi_cmdset_0002-Change-erase-functions-to-ret.patch

  I thought that the patches are listed as a thread as below.
    <http://lists.infradead.org/pipermail/linux-mtd/2018-May/080950.html>

  Is this not mentioned by you probably?

> It seems that nothing has changed, so nothing more to review on my side.

  The changes themselves are not changed basically.

> And I'm still not entirely convinced by the fix, but if nobody complains, I'll apply it.

  Probably my explanation or investigation are not enough for you.
  If needed please let me know them I will do that.
    Note: In my understanding the investigation is enough.

  Anyway thank you so much for your reviewing.

> BTW, the changelog is really not clear, you should have something like:

  Very sorry about this let me list the change logs as below.
  Changes since v5:
  - Just fix the commit message of PATCH v4 2/2.
  - No changes for the source code diff.

  Changes since v4:
  - The patch series are just rebased since the coding style fix has been applied.

  Changes since v3:
  - Just fix the commit message of patch to retry the chip erase error.
  - Change the definition naming to MAX_RETRIES from MAX_WRITE_RETRIES.

  Changes since v2:
  - Split the v1 patch to separate as below.
    1. Fix coding style
    2. Change the definition naming
    3. Retry the erase error

  Changes since v1:
  - Initial patch to retry the chip erase error.

  Note: If needed I will do resend the patch series with the change log.
        So please let me know about this if so.

Regards,
Ikegami