"usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

"usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Paul Gortmaker]

This commit:

---------------
commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Date:   Fri Feb 3 16:14:18 2012 +0900

    usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
    
    Problem:
     pch_udc continues operation even if VBUS becomes Low.
     pch_udc performs D+ pulling up before VBUS becomes High.
     USB device should be controlled according to VBUS state.
    
    Root cause:
     The current pch_udc is not always monitoring VBUS.
    
    Solution:
     The change of VBUS is detected using an interrupt of GPIO.
     If VBUS became Low, pch_udc handles 'disconnect'.
     After VBUS became High, a pull improves D+, and pch_udc
     handles 'connect'.
    
    [ balbi@ti.com : make it actually compile ]
    
    Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
---------------

breaks the sparc builds in next:

http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

Thanks,
Paul.

Re: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

[Just cc'ing Greg as this commit is in the usb tree]

On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> This commit:
> 
> ---------------
> commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
> Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> Date:   Fri Feb 3 16:14:18 2012 +0900
> 
>     usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
>     
>     Problem:
>      pch_udc continues operation even if VBUS becomes Low.
>      pch_udc performs D+ pulling up before VBUS becomes High.
>      USB device should be controlled according to VBUS state.
>     
>     Root cause:
>      The current pch_udc is not always monitoring VBUS.
>     
>     Solution:
>      The change of VBUS is detected using an interrupt of GPIO.
>      If VBUS became Low, pch_udc handles 'disconnect'.
>      After VBUS became High, a pull improves D+, and pch_udc
>      handles 'connect'.
>     
>     [ balbi@ti.com : make it actually compile ]
>     
>     Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
>     Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---------------
> 
> breaks the sparc builds in next:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
> http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/
> 
> Thanks,
> Paul.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Greg KH]

On Sat, Mar 03, 2012 at 10:41:42AM +1100, Stephen Rothwell wrote:
> [Just cc'ing Greg as this commit is in the usb tree]
> 
> On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> >
> > This commit:
> > 
> > ---------------
> > commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
> > Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> > Date:   Fri Feb 3 16:14:18 2012 +0900
> > 
> >     usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
> >     
> >     Problem:
> >      pch_udc continues operation even if VBUS becomes Low.
> >      pch_udc performs D+ pulling up before VBUS becomes High.
> >      USB device should be controlled according to VBUS state.
> >     
> >     Root cause:
> >      The current pch_udc is not always monitoring VBUS.
> >     
> >     Solution:
> >      The change of VBUS is detected using an interrupt of GPIO.
> >      If VBUS became Low, pch_udc handles 'disconnect'.
> >      After VBUS became High, a pull improves D+, and pch_udc
> >      handles 'connect'.
> >     
> >     [ balbi@ti.com : make it actually compile ]
> >     
> >     Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> >     Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---------------
> > 
> > breaks the sparc builds in next:
> > 
> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

Ick, not good.

Tomoya, can you please send me a patch to fix this?  Felipe is off-line
for a few days and can't do this himself.


greg k-h

Re: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Tomoya MORINAGA]

Hi Greg

Sorry, for inconvenience.
I'll re-submit ASAP.

thanks

-- 
ROHM Co., Ltd.
tomoya

2012年3月6日1:43 Greg KH <gregkh@linuxfoundation.org>:
> On Sat, Mar 03, 2012 at 10:41:42AM +1100, Stephen Rothwell wrote:
>> [Just cc'ing Greg as this commit is in the usb tree]
>>
>> On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>> >
>> > This commit:
>> >
>> > ---------------
>> > commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
>> > Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
>> > Date:   Fri Feb 3 16:14:18 2012 +0900
>> >
>> >     usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
>> >
>> >     Problem:
>> >      pch_udc continues operation even if VBUS becomes Low.
>> >      pch_udc performs D+ pulling up before VBUS becomes High.
>> >      USB device should be controlled according to VBUS state.
>> >
>> >     Root cause:
>> >      The current pch_udc is not always monitoring VBUS.
>> >
>> >     Solution:
>> >      The change of VBUS is detected using an interrupt of GPIO.
>> >      If VBUS became Low, pch_udc handles 'disconnect'.
>> >      After VBUS became High, a pull improves D+, and pch_udc
>> >      handles 'connect'.
>> >
>> >     [ balbi@ti.com : make it actually compile ]
>> >
>> >     Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
>> >     Signed-off-by: Felipe Balbi <balbi@ti.com>
>> > ---------------
>> >
>> > breaks the sparc builds in next:
>> >
>> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
>> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/
>
> Ick, not good.
>
> Tomoya, can you please send me a patch to fix this?  Felipe is off-line
> for a few days and can't do this himself.
>
>
> greg k-h