From: David Howells <dhowells@redhat.com>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
Scott Mayhew <smayhew@redhat.com>,
Ard Biesheuvel <ardb@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break?
Date: Thu, 13 Apr 2023 14:55:38 +0100 [thread overview]
Message-ID: <1078650.1681394138@warthog.procyon.org.uk> (raw)
In-Reply-To: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com>
Chuck Lever III <chuck.lever@oracle.com> wrote:
> Ah, I see Scott is Cc'd. Yes, Scott reported this to me yesterday.
Found it (see patch sent separately). There was an uninitialised variable in
sunrpc.
The krb5lib problem was that I'd lost the byteswapping of the usage value in
the test data when I split it out of the net/rxrpc/ directory, e.g.:
@@ -167,7 +167,7 @@ const struct krb5_enc_test krb5_enc_tests[] = {
.plain = "'1",
.conf = "6F2FC3C2A166FD8898967A83DE9596D9",
.K0 = "5027BC231D0F3A9D23333F1CA6FDBE7C",
- .usage = 1,
+ .usage = htonl(1),
.ct = "842D21FD950311C0DD464A3F4BE8D6DA88A56D559C9B47D3F9A85067AF661559B8",
}, {
.krb5 = &krb5_camellia128_cts_cmac,
David
next prev parent reply other threads:[~2023-04-13 13:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 15:56 Did the in-kernel Camellia or CMAC crypto implementation break? David Howells
2023-04-12 16:57 ` Chuck Lever III
2023-04-12 17:44 ` Scott Mayhew
2023-04-12 17:50 ` David Howells
2023-04-13 6:07 ` Herbert Xu
2023-04-13 6:36 ` David Howells
2023-04-13 6:40 ` Herbert Xu
2023-04-13 8:59 ` David Howells
2023-04-13 13:55 ` David Howells [this message]
2023-04-14 2:08 ` Herbert Xu
2023-04-14 8:47 ` David Howells
2023-04-14 8:52 ` Herbert Xu
2023-04-14 10:17 ` David Howells
2023-04-14 10:18 ` Herbert Xu
2023-04-14 10:34 ` David Howells
2023-04-14 11:04 ` Herbert Xu
2023-04-14 12:32 ` David Howells
2023-05-22 21:07 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1078650.1681394138@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ardb@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=jlayton@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox