Re: Did the in-kernel Camellia or CMAC crypto implementation break?

[David Howells <dhowells@redhat.com>]

Herbert Xu <herbert@gondor.apana.org.au> wrote:

> > Actually, I was wondering about that.  I see that all the testing data
> > seems to be statically loaded in testmgr.[ch], even if the algorithms to
> > be tested are resident in modules that aren't loaded yet (so it's kind of
> > test "on demand").  I guess it can't be split up amongst the algorithm
> > modules as some of the tests require stuff from multiple modules (eg. aes
> > + cbs + cts).
> 
> Yes I've been meaning to split this up so they're colocated with
> the generic implementation.

Might be easier if I wait to see how you do that.

> Unless this code has at least two users it's probably not worth
> it (but there are exceptions, e.g. we did a one-user algorithm
> for dm-crypt).

There would be just two users at the moment: sunrpc/nfs and rxrpc/afs.  I
don't know if cifs or ceph could make use of it.

David