public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Treinish <treinish@linux.vnet.ibm.com>
To: linux-nfs@vger.kernel.org
Cc: treinish@linux.vnet.ibm.com
Subject: [PATCH/RFC 7/7] Added error handling for NFS4ERR_FHEXPIRED
Date: Fri, 11 Nov 2011 18:04:32 -0500	[thread overview]
Message-ID: <1321052673-22171-8-git-send-email-treinish@linux.vnet.ibm.com> (raw)
In-Reply-To: <1321052673-22171-1-git-send-email-treinish@linux.vnet.ibm.com>

Added checks in the nfs4_handle_exception for FHEXPIRED.
If FHEXPIRED is received from the server and the appropriate
attributes are enabled then the client calls
nfs4_fhexpired_recovery() to perform the lookup operation to
try and recovery the expired vfh.

If the mount option is not enabled or the server FH_EXPIRE_TYPE
doesn't have VOLATILE_ANY then client will convert the
FHEXPIRED error into ESTALE since recovery isn't possible.

Signed-off-by: Matthew Treinish <treinish@linux.vnet.ibm.com>
---
 fs/nfs/nfs4proc.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index ebc5ee9..8ae5c49 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -277,6 +277,16 @@ static int nfs4_handle_exception(struct nfs_server *server, int errorcode, struc
 		case -NFS4ERR_STALE_CLIENTID:
 			nfs4_schedule_lease_recovery(clp);
 			goto wait_on_recovery;
+		case -NFS4ERR_FHEXPIRED:
+			if (server->flags & NFS_MOUNT_VFHRETRY)
+				if (server->fhexpiretype & NFS4_FH_VOLATILE_ANY) {
+					ret = nfs4_fhexpired_recovery(server, exception);
+					if (!ret)
+						ret = -EAGAIN;
+					break;
+				}
+			ret = -ESTALE;
+			break;
 #if defined(CONFIG_NFS_V4_1)
 		case -NFS4ERR_BADSESSION:
 		case -NFS4ERR_BADSLOT:
-- 
1.7.4.4


  parent reply	other threads:[~2011-11-11 23:06 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 23:04 [PATCH/RFC 0/7] Volatile Filehandle Client-side Support Matthew Treinish
2011-11-11 23:04 ` [PATCH/RFC 1/7] New mount option for volatile filehandle recovery Matthew Treinish
2011-11-12  0:19   ` Trond Myklebust
2011-11-12  3:35     ` Malahal Naineni
2011-11-11 23:04 ` [PATCH/RFC 2/7] Added support for FH_EXPIRE_TYPE attribute Matthew Treinish
2011-11-11 23:04 ` [PATCH/RFC 3/7] Add VFS objects from nfs4_proc calls into nfs4_exception Matthew Treinish
2011-11-11 23:04 ` [PATCH/RFC 4/7] Save root file handle in nfs_server Matthew Treinish
2011-11-11 23:04 ` [PATCH/RFC 5/7] Added VFH FHEXPIRED recovery functions Matthew Treinish
2011-11-12  0:27   ` Trond Myklebust
2011-11-12  3:45     ` Malahal Naineni
2011-11-12 17:16       ` Trond Myklebust
2011-11-14 21:12         ` Matthew Treinish
2011-11-11 23:04 ` [PATCH/RFC 6/7] Perform recovery on both inodes for rename Matthew Treinish
2011-11-11 23:04 ` Matthew Treinish [this message]
2011-11-11 23:04 ` [PATCH/RFC] Hard code testing on server <ONLY FOR TESTING> Matthew Treinish
2011-11-12  0:13 ` [PATCH/RFC 0/7] Volatile Filehandle Client-side Support Trond Myklebust
2011-11-12 14:49   ` Christoph Hellwig
2011-11-13  3:54     ` NeilBrown
2011-11-13 13:45       ` Tigran Mkrtchyan
2011-11-13 16:36         ` J. Bruce Fields
2011-11-13 21:07           ` NeilBrown
2011-11-14  0:42             ` J. Bruce Fields
2011-11-14  1:26               ` NeilBrown
2011-11-14 17:27             ` Trond Myklebust
2011-11-15  6:33             ` Trond Myklebust
2012-01-13 17:09               ` Malahal Naineni
2012-01-14  1:38                 ` J. Bruce Fields
2012-01-16 16:52                   ` Malahal Naineni
2012-01-17 15:18                     ` J. Bruce Fields
2012-01-17 17:22                       ` Malahal Naineni
2012-01-17 18:47                         ` J. Bruce Fields
2012-01-17 19:43                           ` Malahal Naineni
2011-11-14 16:29         ` Trond Myklebust
2011-11-13 16:42       ` J. Bruce Fields
2011-11-13 16:45         ` J. Bruce Fields
2011-11-13 18:25           ` Matthew Treinish
2011-11-13 18:06       ` Matthew Treinish
2011-11-14  9:09         ` Tigran Mkrtchyan
2011-11-14 21:47           ` Matthew Treinish
2011-11-15  6:49         ` Trond Myklebust
2011-11-15 22:38           ` Matthew Treinish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321052673-22171-8-git-send-email-treinish@linux.vnet.ibm.com \
    --to=treinish@linux.vnet.ibm.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox