public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Simo Sorce <simo@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Steve Dickson <steved@redhat.com>,
	Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] nfs-service: Added the starting of gssproxy
Date: Mon, 22 Sep 2014 15:46:42 -0400	[thread overview]
Message-ID: <20140922154642.779189c8@willson.usersys.redhat.com> (raw)
In-Reply-To: <20140922194057.GE26763@fieldses.org>

On Mon, 22 Sep 2014 15:40:57 -0400
"J. Bruce Fields" <bfields@fieldses.org> wrote:

> On Mon, Sep 22, 2014 at 03:20:07PM -0400, Steve Dickson wrote:
> > Added the gssproxy.service to both the Wants= and
> > Atfers= lines, before the rpc-svcgssd.service. There
> > are  ConditionPathExists= lines in the rpc-svcgssd.service
> > unit which will stop the rpc.svcgssd daemon from
> > starting when the gssproxy daemon is already running.
> 
> That should read "when the kernel supports gssproxy", not "when the
> gssproxy daemon is already running."

Actually the language is currently correct but it is another bug, the
systemd/rpc-svcgssd.service file still includes
"ConditionPathExists=|!/run/gssproxy.pid"
This line should be removed in this patch.

Simo.

> --b.
> 
> > 
> > Signed-off-by: Steve Dickson <steved@redhat.com>
> > ---
> >  systemd/nfs-server.service | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> > index 2fa7387..c740fa2 100644
> > --- a/systemd/nfs-server.service
> > +++ b/systemd/nfs-server.service
> > @@ -2,12 +2,13 @@
> >  Description=NFS server and services
> >  Requires= network.target proc-fs-nfsd.mount rpcbind.target
> >  Requires= nfs-mountd.service
> > -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service
> > rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service 
> > +Wants=rpc-gssd.service gssproxy.service rpc-svcgssd.service
> >  Wants=rpc-statd-notify.service
> >  
> >  After= network.target proc-fs-nfsd.mount rpcbind.target
> > nfs-mountd.service After= nfs-idmapd.service rpc-statd.service
> > -After= rpc-gssd.service rpc-svcgssd.service
> > +After= rpc-gssd.service gssproxy.service rpc-svcgssd.service
> >  Before= rpc-statd-notify.service
> >  
> >  Wants=nfs-config.service
> > -- 
> > 1.9.3
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-nfs" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Simo Sorce * Red Hat, Inc * New York

  reply	other threads:[~2014-09-22 19:46 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 19:20 [PATCH 0/2] Use the gssproxy damon for GSSAPI credentials (v3) Steve Dickson
2014-09-22 19:20 ` [PATCH 1/2] nfs-service: Added the starting of gssproxy Steve Dickson
2014-09-22 19:26   ` Simo Sorce
2014-09-22 19:43     ` Steve Dickson
2014-09-22 20:44       ` J. Bruce Fields
2014-09-22 21:14         ` Steve Dickson
2014-09-22 21:32           ` Simo Sorce
2014-09-22 22:57             ` Steve Dickson
2014-09-23  0:19               ` Simo Sorce
2014-09-23  1:19                 ` Steve Dickson
2014-09-23 12:52                   ` Simo Sorce
2014-09-23 14:58                     ` Steve Dickson
2014-09-23 15:08                       ` Simo Sorce
2014-09-23 19:29                     ` J. Bruce Fields
2014-09-23 19:40                       ` Simo Sorce
2014-09-23 19:51                         ` J. Bruce Fields
2014-09-22 22:34           ` J. Bruce Fields
2014-09-22 23:58             ` Steve Dickson
2014-09-23  0:26               ` Simo Sorce
2014-09-23  1:55                 ` J. Bruce Fields
2014-09-23  2:08                   ` NeilBrown
2014-09-23  2:11                     ` J. Bruce Fields
2014-09-23 19:23                       ` J. Bruce Fields
2014-09-23 20:17                         ` Steve Dickson
2014-09-23 20:25                           ` J. Bruce Fields
2014-09-23 21:15                             ` Steve Dickson
2014-09-24 15:07                               ` Steve Dickson
2014-09-24 15:15                                 ` J. Bruce Fields
2014-09-24 15:23                                 ` J. Bruce Fields
2014-09-24 15:30                                   ` Steve Dickson
2014-09-23 12:48                     ` Simo Sorce
2014-09-23 15:20                       ` J. Bruce Fields
2014-09-23 16:00                         ` Simo Sorce
2014-09-23 16:12                           ` J. Bruce Fields
2014-09-23 16:57                             ` Simo Sorce
2014-09-23 12:46                   ` Simo Sorce
2014-09-23 15:06                   ` Steve Dickson
2014-09-23 15:16                     ` J. Bruce Fields
2014-09-23 15:52                       ` Steve Dickson
2014-09-23 16:05                         ` J. Bruce Fields
2014-09-23  2:01             ` NeilBrown
2014-09-22 19:40   ` J. Bruce Fields
2014-09-22 19:46     ` Simo Sorce [this message]
2014-09-22 19:53       ` Steve Dickson
2014-09-22 20:00         ` Simo Sorce
2014-09-22 20:02           ` Steve Dickson
2014-09-23  1:42           ` NeilBrown
2014-09-23  2:09             ` J. Bruce Fields
2014-09-23  2:55               ` NeilBrown
2014-09-23 12:45             ` Simo Sorce
2014-09-22 19:20 ` [PATCH 2/2] rpc.svcgssd: the build of rpc.svcgssd is off by default Steve Dickson
2014-09-22 19:43   ` J. Bruce Fields
2014-09-22 19:50     ` Steve Dickson
2014-09-22 20:21       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140922154642.779189c8@willson.usersys.redhat.com \
    --to=simo@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox