public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>,
	Simo Sorce <simo@redhat.com>
Subject: Re: [PATCH 2/2] rpc.svcgssd: the build of rpc.svcgssd is off by default
Date: Mon, 22 Sep 2014 15:43:53 -0400	[thread overview]
Message-ID: <20140922194352.GF26763@fieldses.org> (raw)
In-Reply-To: <1411413608-16462-3-git-send-email-steved@redhat.com>

On Mon, Sep 22, 2014 at 03:20:08PM -0400, Steve Dickson wrote:
> Due to the fact the gssproxy is not managing the
> GASSAPI credentials, on the server, there is
> no need to build/install rpc.svcgssd.
> 
> To re-enable the build use the --enable-svcgss
> configure flag

Since we're not running rpc.svcgssd in those cases where it's not
needed, we should keep --enable-svcgss as the default for now.  It's an
easy way to keep old kernels working.

--b.

> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  configure.ac           | 23 +++++++++++++++++++----
>  utils/gssd/Makefile.am | 11 +++++++++--
>  2 files changed, 28 insertions(+), 6 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index bc48373..6767190 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -90,21 +90,36 @@ AC_ARG_ENABLE(nfsv41,
>  
>  AC_ARG_ENABLE(gss,
>  	[AC_HELP_STRING([--enable-gss],
> -                        [enable support for rpcsec_gss @<:@default=yes@:>@])],
> +              [enable client support for rpcsec_gss @<:@default=yes@:>@])],
>  	enable_gss=$enableval,
>  	enable_gss=yes)
>  	if test "$enable_gss" = yes; then
>  		GSSD=gssd
> -		SVCGSSD=svcgssd
>  	else
>  		enable_gss=
>  		GSSD=
> -		SVCGSSD=
>  	fi
>  	AC_SUBST(GSSD)
> -	AC_SUBST(SVCGSSD)
>  	AC_SUBST(enable_gss)
>  	AM_CONDITIONAL(CONFIG_GSS, [test "$enable_gss" = "yes"])
> +
> +AC_ARG_ENABLE(svcgss,
> +	[AC_HELP_STRING([--enable-svcgss],
> +              [enable server support for rpcsec_gss @<:@default=no@:>@])],
> +	enable_svcgss=$enableval,
> +	enable_svcgss=no)
> +	if test "$enable_gss" = yes; then
> +		if "enable_svcgss" = yes; then
> +			SVCGSSD=svcgssd
> +		fi
> +	else
> +		enable_svcgss=
> +		SVCGSSD=
> +	fi
> +	AC_SUBST(SVCGSSD)
> +	AC_SUBST(enable_svcgss)
> +	AM_CONDITIONAL(CONFIG_SVCGSS, [test "$enable_svcgss" = "yes"])
> +
>  AC_ARG_ENABLE(kprefix,
>  	[AC_HELP_STRING([--enable-kprefix], [install progs as rpc.knfsd etc])],
>  	test "$enableval" = "yes" && kprefix=k,
> diff --git a/utils/gssd/Makefile.am b/utils/gssd/Makefile.am
> index af59791..9835117 100644
> --- a/utils/gssd/Makefile.am
> +++ b/utils/gssd/Makefile.am
> @@ -1,10 +1,17 @@
>  ## Process this file with automake to produce Makefile.in
>  
> -man8_MANS	= gssd.man svcgssd.man
> +man8_MANS	= gssd.man
> +if CONFIG_SVCGSS
> +man8_MANS	+= svcgssd.man
> +endif
>  
>  RPCPREFIX	= rpc.
>  KPREFIX		= @kprefix@
> -sbin_PREFIXED	= gssd svcgssd
> +sbin_PREFIXED	= gssd
> +if CONFIG_SVCGSS
> +sbin_PREFIXED	+= svcgssd
> +endif
> +
>  sbin_PROGRAMS	= $(sbin_PREFIXED)
>  
>  EXTRA_DIST = \
> -- 
> 1.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-09-22 19:43 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 19:20 [PATCH 0/2] Use the gssproxy damon for GSSAPI credentials (v3) Steve Dickson
2014-09-22 19:20 ` [PATCH 1/2] nfs-service: Added the starting of gssproxy Steve Dickson
2014-09-22 19:26   ` Simo Sorce
2014-09-22 19:43     ` Steve Dickson
2014-09-22 20:44       ` J. Bruce Fields
2014-09-22 21:14         ` Steve Dickson
2014-09-22 21:32           ` Simo Sorce
2014-09-22 22:57             ` Steve Dickson
2014-09-23  0:19               ` Simo Sorce
2014-09-23  1:19                 ` Steve Dickson
2014-09-23 12:52                   ` Simo Sorce
2014-09-23 14:58                     ` Steve Dickson
2014-09-23 15:08                       ` Simo Sorce
2014-09-23 19:29                     ` J. Bruce Fields
2014-09-23 19:40                       ` Simo Sorce
2014-09-23 19:51                         ` J. Bruce Fields
2014-09-22 22:34           ` J. Bruce Fields
2014-09-22 23:58             ` Steve Dickson
2014-09-23  0:26               ` Simo Sorce
2014-09-23  1:55                 ` J. Bruce Fields
2014-09-23  2:08                   ` NeilBrown
2014-09-23  2:11                     ` J. Bruce Fields
2014-09-23 19:23                       ` J. Bruce Fields
2014-09-23 20:17                         ` Steve Dickson
2014-09-23 20:25                           ` J. Bruce Fields
2014-09-23 21:15                             ` Steve Dickson
2014-09-24 15:07                               ` Steve Dickson
2014-09-24 15:15                                 ` J. Bruce Fields
2014-09-24 15:23                                 ` J. Bruce Fields
2014-09-24 15:30                                   ` Steve Dickson
2014-09-23 12:48                     ` Simo Sorce
2014-09-23 15:20                       ` J. Bruce Fields
2014-09-23 16:00                         ` Simo Sorce
2014-09-23 16:12                           ` J. Bruce Fields
2014-09-23 16:57                             ` Simo Sorce
2014-09-23 12:46                   ` Simo Sorce
2014-09-23 15:06                   ` Steve Dickson
2014-09-23 15:16                     ` J. Bruce Fields
2014-09-23 15:52                       ` Steve Dickson
2014-09-23 16:05                         ` J. Bruce Fields
2014-09-23  2:01             ` NeilBrown
2014-09-22 19:40   ` J. Bruce Fields
2014-09-22 19:46     ` Simo Sorce
2014-09-22 19:53       ` Steve Dickson
2014-09-22 20:00         ` Simo Sorce
2014-09-22 20:02           ` Steve Dickson
2014-09-23  1:42           ` NeilBrown
2014-09-23  2:09             ` J. Bruce Fields
2014-09-23  2:55               ` NeilBrown
2014-09-23 12:45             ` Simo Sorce
2014-09-22 19:20 ` [PATCH 2/2] rpc.svcgssd: the build of rpc.svcgssd is off by default Steve Dickson
2014-09-22 19:43   ` J. Bruce Fields [this message]
2014-09-22 19:50     ` Steve Dickson
2014-09-22 20:21       ` J. Bruce Fields
  -- strict thread matches above, loose matches on Subject: below --
2014-09-19 17:10 [PATCH 0/2] Use the gssproxy damon for GSSAPI credentials (v2) Steve Dickson
2014-09-19 17:10 ` [PATCH 2/2] rpc.svcgssd: the build of rpc.svcgssd is off by default Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140922194352.GF26763@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=simo@redhat.com \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox