* [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed @ 2014-01-07 4:41 Kinglong Mee 2014-01-07 5:01 ` Trond Myklebust 0 siblings, 1 reply; 7+ messages in thread From: Kinglong Mee @ 2014-01-07 4:41 UTC (permalink / raw) To: J. Bruce Fields, Trond Myklebust; +Cc: Linux NFS Mailing List If try_module_get failed, xpt_bc_xprt should be set to NULL, because xprt will be free. Don't needed using xprt_put to free xprt, because it is always new. Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> --- net/sunrpc/xprtsock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 4fcdf74..5ed124f 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) */ xprt_set_connected(xprt); - if (try_module_get(THIS_MODULE)) return xprt; - xprt_put(xprt); + + args->bc_xprt->xpt_bc_xprt = NULL; ret = ERR_PTR(-EINVAL); out_err: xs_xprt_free(xprt); -- 1.8.4.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed 2014-01-07 4:41 [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed Kinglong Mee @ 2014-01-07 5:01 ` Trond Myklebust 2014-01-07 5:21 ` Kinglong Mee 2014-01-07 7:26 ` Kinglong Mee 0 siblings, 2 replies; 7+ messages in thread From: Trond Myklebust @ 2014-01-07 5:01 UTC (permalink / raw) To: Kinglong Mee; +Cc: Dr Fields James Bruce, Linux NFS Mailing List On Jan 6, 2014, at 23:41, Kinglong Mee <kinglongmee@gmail.com> wrote: > If try_module_get failed, xpt_bc_xprt should be set to NULL, > because xprt will be free. > > Don't needed using xprt_put to free xprt, because it is always new. > > Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> > --- > net/sunrpc/xprtsock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c > index 4fcdf74..5ed124f 100644 > --- a/net/sunrpc/xprtsock.c > +++ b/net/sunrpc/xprtsock.c > @@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) > */ > xprt_set_connected(xprt); > > - > if (try_module_get(THIS_MODULE)) > return xprt; > - xprt_put(xprt); > + > + args->bc_xprt->xpt_bc_xprt = NULL; > ret = ERR_PTR(-EINVAL); > out_err: > xs_xprt_free(xprt); Just move the 'args->bc_xprt->xpt_bc_xprt = xprt’ line into the caller (see earlier discussion about xs_setup_bc_tcp()). Quite frankly, I don’t see why the client code should be modifying this variable in the first place. An svc_xprt is a server construct. Trond ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed 2014-01-07 5:01 ` Trond Myklebust @ 2014-01-07 5:21 ` Kinglong Mee 2014-01-07 7:26 ` Kinglong Mee 1 sibling, 0 replies; 7+ messages in thread From: Kinglong Mee @ 2014-01-07 5:21 UTC (permalink / raw) To: Trond Myklebust; +Cc: Dr Fields James Bruce, Linux NFS Mailing List On 01/07/2014 01:01 PM, Trond Myklebust wrote: > > On Jan 6, 2014, at 23:41, Kinglong Mee <kinglongmee@gmail.com> wrote: > >> If try_module_get failed, xpt_bc_xprt should be set to NULL, >> because xprt will be free. >> >> Don't needed using xprt_put to free xprt, because it is always new. >> >> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> >> --- >> net/sunrpc/xprtsock.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c >> index 4fcdf74..5ed124f 100644 >> --- a/net/sunrpc/xprtsock.c >> +++ b/net/sunrpc/xprtsock.c >> @@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) >> */ >> xprt_set_connected(xprt); >> >> - >> if (try_module_get(THIS_MODULE)) >> return xprt; >> - xprt_put(xprt); >> + >> + args->bc_xprt->xpt_bc_xprt = NULL; >> ret = ERR_PTR(-EINVAL); >> out_err: >> xs_xprt_free(xprt); > > > Just move the 'args->bc_xprt->xpt_bc_xprt = xprt’ line into the caller > (see earlier discussion about xs_setup_bc_tcp()). > Quite frankly, I don’t see why the client code should be modifying this variable in the first place. > An svc_xprt is a server construct. That's really better. I will check those codes for NFSv4.1 backchannel in sunrpc, maybe I will cleanup the client code from svc_xprt. thanks, Kinglong Mee ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed 2014-01-07 5:01 ` Trond Myklebust 2014-01-07 5:21 ` Kinglong Mee @ 2014-01-07 7:26 ` Kinglong Mee 2014-01-09 16:34 ` Dr Fields James Bruce 1 sibling, 1 reply; 7+ messages in thread From: Kinglong Mee @ 2014-01-07 7:26 UTC (permalink / raw) To: Dr Fields James Bruce; +Cc: Trond Myklebust, Linux NFS Mailing List On 01/07/2014 01:01 PM, Trond Myklebust wrote: > > On Jan 6, 2014, at 23:41, Kinglong Mee <kinglongmee@gmail.com> wrote: > >> If try_module_get failed, xpt_bc_xprt should be set to NULL, >> because xprt will be free. >> >> Don't needed using xprt_put to free xprt, because it is always new. >> >> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> >> --- >> net/sunrpc/xprtsock.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c >> index 4fcdf74..5ed124f 100644 >> --- a/net/sunrpc/xprtsock.c >> +++ b/net/sunrpc/xprtsock.c >> @@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) >> */ >> xprt_set_connected(xprt); >> >> - >> if (try_module_get(THIS_MODULE)) >> return xprt; >> - xprt_put(xprt); >> + >> + args->bc_xprt->xpt_bc_xprt = NULL; >> ret = ERR_PTR(-EINVAL); >> out_err: >> xs_xprt_free(xprt); > > Just move the 'args->bc_xprt->xpt_bc_xprt = xprt’ line into the caller (see earlier discussion about xs_setup_bc_tcp()). Quite frankly, I don’t see why the client code should be modifying this variable in the first place. An svc_xprt is a server construct. Hi Bruce, When reviewing those codes for bc_xprt, I found commit d75faea330dbd1873c9094e9926ae306590c0998 'rpc: move sk_bc_xprt to svc_xprt'. I'd like recording bc_xprt in svc_sock. thanks, Kinglong Mee ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed 2014-01-07 7:26 ` Kinglong Mee @ 2014-01-09 16:34 ` Dr Fields James Bruce 2014-01-10 2:43 ` Kinglong Mee 0 siblings, 1 reply; 7+ messages in thread From: Dr Fields James Bruce @ 2014-01-09 16:34 UTC (permalink / raw) To: Kinglong Mee; +Cc: Trond Myklebust, Linux NFS Mailing List On Tue, Jan 07, 2014 at 03:26:04PM +0800, Kinglong Mee wrote: > On 01/07/2014 01:01 PM, Trond Myklebust wrote: > > > > On Jan 6, 2014, at 23:41, Kinglong Mee <kinglongmee@gmail.com> wrote: > > > >> If try_module_get failed, xpt_bc_xprt should be set to NULL, > >> because xprt will be free. > >> > >> Don't needed using xprt_put to free xprt, because it is always new. > >> > >> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> > >> --- > >> net/sunrpc/xprtsock.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c > >> index 4fcdf74..5ed124f 100644 > >> --- a/net/sunrpc/xprtsock.c > >> +++ b/net/sunrpc/xprtsock.c > >> @@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) > >> */ > >> xprt_set_connected(xprt); > >> > >> - > >> if (try_module_get(THIS_MODULE)) > >> return xprt; > >> - xprt_put(xprt); > >> + > >> + args->bc_xprt->xpt_bc_xprt = NULL; > >> ret = ERR_PTR(-EINVAL); > >> out_err: > >> xs_xprt_free(xprt); > > > > Just move the 'args->bc_xprt->xpt_bc_xprt = xprt’ line into the caller (see earlier discussion about xs_setup_bc_tcp()). Quite frankly, I don’t see why the client code should be modifying this variable in the first place. An svc_xprt is a server construct. > > Hi Bruce, > > When reviewing those codes for bc_xprt, I found commit d75faea330dbd1873c9094e9926ae306590c0998 > 'rpc: move sk_bc_xprt to svc_xprt'. I'd like recording bc_xprt in svc_sock. OK, I think it would be alright to revert that commit. --b. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed 2014-01-09 16:34 ` Dr Fields James Bruce @ 2014-01-10 2:43 ` Kinglong Mee 2014-01-10 3:22 ` Kinglong Mee 0 siblings, 1 reply; 7+ messages in thread From: Kinglong Mee @ 2014-01-10 2:43 UTC (permalink / raw) To: Dr Fields James Bruce; +Cc: Trond Myklebust, Linux NFS Mailing List On 01/10/2014 12:34 AM, Dr Fields James Bruce wrote: > On Tue, Jan 07, 2014 at 03:26:04PM +0800, Kinglong Mee wrote: >> On 01/07/2014 01:01 PM, Trond Myklebust wrote: >>> >>> On Jan 6, 2014, at 23:41, Kinglong Mee <kinglongmee@gmail.com> wrote: >>> >>>> If try_module_get failed, xpt_bc_xprt should be set to NULL, >>>> because xprt will be free. >>>> >>>> Don't needed using xprt_put to free xprt, because it is always new. >>>> >>>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> >>>> --- >>>> net/sunrpc/xprtsock.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c >>>> index 4fcdf74..5ed124f 100644 >>>> --- a/net/sunrpc/xprtsock.c >>>> +++ b/net/sunrpc/xprtsock.c >>>> @@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) >>>> */ >>>> xprt_set_connected(xprt); >>>> >>>> - >>>> if (try_module_get(THIS_MODULE)) >>>> return xprt; >>>> - xprt_put(xprt); >>>> + >>>> + args->bc_xprt->xpt_bc_xprt = NULL; >>>> ret = ERR_PTR(-EINVAL); >>>> out_err: >>>> xs_xprt_free(xprt); >>> >>> Just move the 'args->bc_xprt->xpt_bc_xprt = xprt’ line into the caller (see earlier discussion about xs_setup_bc_tcp()). Quite frankly, I don’t see why the client code should be modifying this variable in the first place. An svc_xprt is a server construct. >> >> Hi Bruce, >> >> When reviewing those codes for bc_xprt, I found commit d75faea330dbd1873c9094e9926ae306590c0998 >> 'rpc: move sk_bc_xprt to svc_xprt'. I'd like recording bc_xprt in svc_sock. > > OK, I think it would be alright to revert that commit. I will try to revert it later. Thanks, Kinglong Mee ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed 2014-01-10 2:43 ` Kinglong Mee @ 2014-01-10 3:22 ` Kinglong Mee 0 siblings, 0 replies; 7+ messages in thread From: Kinglong Mee @ 2014-01-10 3:22 UTC (permalink / raw) To: Dr Fields James Bruce; +Cc: Trond Myklebust, Linux NFS Mailing List On 01/10/2014 10:43 AM, Kinglong Mee wrote: > On 01/10/2014 12:34 AM, Dr Fields James Bruce wrote: >> On Tue, Jan 07, 2014 at 03:26:04PM +0800, Kinglong Mee wrote: >>> On 01/07/2014 01:01 PM, Trond Myklebust wrote: >>>> >>>> On Jan 6, 2014, at 23:41, Kinglong Mee <kinglongmee@gmail.com> wrote: >>>> >>>>> If try_module_get failed, xpt_bc_xprt should be set to NULL, >>>>> because xprt will be free. >>>>> >>>>> Don't needed using xprt_put to free xprt, because it is always new. >>>>> >>>>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> >>>>> --- >>>>> net/sunrpc/xprtsock.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c >>>>> index 4fcdf74..5ed124f 100644 >>>>> --- a/net/sunrpc/xprtsock.c >>>>> +++ b/net/sunrpc/xprtsock.c >>>>> @@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) >>>>> */ >>>>> xprt_set_connected(xprt); >>>>> >>>>> - >>>>> if (try_module_get(THIS_MODULE)) >>>>> return xprt; >>>>> - xprt_put(xprt); >>>>> + >>>>> + args->bc_xprt->xpt_bc_xprt = NULL; >>>>> ret = ERR_PTR(-EINVAL); >>>>> out_err: >>>>> xs_xprt_free(xprt); >>>> >>>> Just move the 'args->bc_xprt->xpt_bc_xprt = xprt’ line into the caller (see earlier discussion about xs_setup_bc_tcp()). Quite frankly, I don’t see why the client code should be modifying this variable in the first place. An svc_xprt is a server construct. >>> >>> Hi Bruce, >>> >>> When reviewing those codes for bc_xprt, I found commit d75faea330dbd1873c9094e9926ae306590c0998 >>> 'rpc: move sk_bc_xprt to svc_xprt'. I'd like recording bc_xprt in svc_sock. >> >> OK, I think it would be alright to revert that commit. > > I will try to revert it later. I had try to revert it, but, I don't revert it. I'm sorry for my above thinking. I think it is not needed to move bc_xprt from one place to another without fix some problem, because knfsd running correctly with that. Just let bc_xprt in svc_xprt until some problem appears. Thanks, Kinglong Mee ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-10 3:22 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-07 4:41 [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed Kinglong Mee 2014-01-07 5:01 ` Trond Myklebust 2014-01-07 5:21 ` Kinglong Mee 2014-01-07 7:26 ` Kinglong Mee 2014-01-09 16:34 ` Dr Fields James Bruce 2014-01-10 2:43 ` Kinglong Mee 2014-01-10 3:22 ` Kinglong Mee
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox