Re: [PATCH 2/4] nvmet: pci-epf: Do not fall back to using INTX if not supported

[Damien Le Moal <dlemoal@kernel.org>]

On 5/8/25 10:07 PM, Niklas Cassel wrote:
> On Thu, May 08, 2025 at 03:57:43PM +0900, Damien Le Moal wrote:
>> Some endpoint PCIe controllers do not support raising legacy INTX
>> interrupts. This support is indicated by the intx_capable field of
>> struct pci_epc_features. Modify nvmet_pci_epf_raise_irq() to not
>> automatically fallback to trying raising an INTX interrupt after an MSI
>> or MSI-X error if the controller does not support INTX.
>>
>> Fixes: 0faa0fe6f90e ("nvmet: New NVMe PCI endpoint function target driver")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> 
> Hm..
> 
> 0faa0fe6f90e ("nvmet: New NVMe PCI endpoint function target driver") was first
> included in v6.14-rc1.
> 
> 4b313c69a38e ("PCI: endpoint: Add intx_capable to epc_features struct") was first
> included in v6.15-rc1.
> 
> Perhaps add a:
> Cc: stable+noautosel@kernel.org # depends on patch introducing intx_capable flag
> 
> So that it is not automatically backported.

Good catch. Will drop the Fixes tag. No point in it.

-- 
Damien Le Moal
Western Digital Research