From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 3/4] nvmet: pci-epf: Cleanup nvmet_pci_epf_raise_irq()
Date: Fri, 9 May 2025 08:16:54 +0900 [thread overview]
Message-ID: <e63e391d-44a6-4f46-9996-8d6abaa090fa@kernel.org> (raw)
In-Reply-To: <aBysnmAu_ik89fse@ryzen>
On 5/8/25 10:07 PM, Niklas Cassel wrote:
> Nit: since we no longer perform the NVMET_PCI_EPF_Q_IRQ_ENABLED check in
> nvmet_pci_epf_should_raise_irq(), should we rename the function to something
> else? nvmet_pci_epf_irq_allowed() ? Any ideas ?
nvmet_pci_epf_should_raise_irq() is still in charge of handling IRQ coalescing,
returning true if we should raise an IRQ and false if the IRQs are still being
coalesced. So the name as is still seems fine to me.
> Reviewed-by: Niklas Cassel <cassel@kernel.org>
Thanks.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-05-08 23:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 6:57 [PATCH 0/4] nvmet pci-epf fixes Damien Le Moal
2025-05-08 6:57 ` [PATCH 1/4] nvmet: pci-epf: Clear completion queue IRQ flag on delete Damien Le Moal
2025-05-08 13:07 ` Niklas Cassel
2025-05-08 23:13 ` Damien Le Moal
2025-05-09 13:14 ` Niklas Cassel
2025-05-08 6:57 ` [PATCH 2/4] nvmet: pci-epf: Do not fall back to using INTX if not supported Damien Le Moal
2025-05-08 13:07 ` Niklas Cassel
2025-05-08 23:14 ` Damien Le Moal
2025-05-08 6:57 ` [PATCH 3/4] nvmet: pci-epf: Cleanup nvmet_pci_epf_raise_irq() Damien Le Moal
2025-05-08 13:07 ` Niklas Cassel
2025-05-08 23:16 ` Damien Le Moal [this message]
2025-05-08 6:57 ` [PATCH 4/4] nvmet: pci-epf: Improve debug message Damien Le Moal
2025-05-08 13:07 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e63e391d-44a6-4f46-9996-8d6abaa090fa@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox