Re: [PATCH 4/4] nvmet: pci-epf: Improve debug message

[Niklas Cassel <cassel@kernel.org>]

On Thu, May 08, 2025 at 03:57:45PM +0900, Damien Le Moal wrote:
> Improve the debug message of nvmet_pci_epf_create_cq() to indicate if a
> completion queue IRQ is disabled.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
>  drivers/nvme/target/pci-epf.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c
> index 34dd73d6457c..bd79e059e066 100644
> --- a/drivers/nvme/target/pci-epf.c
> +++ b/drivers/nvme/target/pci-epf.c
> @@ -1321,8 +1321,14 @@ static u16 nvmet_pci_epf_create_cq(struct nvmet_ctrl *tctrl,
>  
>  	set_bit(NVMET_PCI_EPF_Q_LIVE, &cq->flags);
>  
> -	dev_dbg(ctrl->dev, "CQ[%u]: %u entries of %zu B, IRQ vector %u\n",
> -		cqid, qsize, cq->qes, cq->vector);
> +	if (test_bit(NVMET_PCI_EPF_Q_IRQ_ENABLED, &cq->flags))
> +		dev_dbg(ctrl->dev,
> +			"CQ[%u]: %u entries of %zu B, IRQ vector %u\n",
> +			cqid, qsize, cq->qes, cq->vector);
> +	else
> +		dev_dbg(ctrl->dev,
> +			"CQ[%u]: %u entries of %zu B, IRQ disabled\n",
> +			cqid, qsize, cq->qes);
>  
>  	return NVME_SC_SUCCESS;
>  
> -- 
> 2.49.0
> 
> 

Reviewed-by: Niklas Cassel <cassel@kernel.org>