From: Alan Adamson <alan.adamson@oracle.com>
To: linux-nvme@lists.infradead.org
Cc: alan.adamson@oracle.com, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me
Subject: [PATCH 0/1] nvme: Add verbose error logging
Date: Thu, 9 Dec 2021 09:32:12 -0800 [thread overview]
Message-ID: <20211209173213.14249-1-alan.adamson@oracle.com> (raw)
This patch improves logging for NVMe errors. Currently, we only get a
a vague idea as to why commands fail since only the block layer status
is captured on error. This patch allows us to see why a command was failed
by the controller. This is very useful when debugging problems in the field.
An example of an imnproved logged error:
[ 4652.812867] nvme0n1: Read @ LBA 1536, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR
Alan Adamson (1):
nvme: Add verbose error logging
drivers/nvme/host/Kconfig | 8 ++
drivers/nvme/host/Makefile | 1 +
drivers/nvme/host/core.c | 4 +
drivers/nvme/host/errors.c | 176 +++++++++++++++++++++++++++++++++++++
drivers/nvme/host/nvme.h | 6 ++
include/linux/nvme.h | 1 +
6 files changed, 196 insertions(+)
create mode 100644 drivers/nvme/host/errors.c
--
2.27.0
next reply other threads:[~2021-12-09 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 17:32 Alan Adamson [this message]
2021-12-09 17:32 ` [PATCH 1/1] nvme: Add verbose error logging Alan Adamson
2021-12-10 11:36 ` Chaitanya Kulkarni
2021-12-10 15:54 ` Martin K. Petersen
2021-12-10 16:56 ` Keith Busch
2021-12-12 9:52 ` Sagi Grimberg
2021-12-13 8:09 ` Chaitanya Kulkarni
2021-12-14 0:31 ` Alan Adamson
2021-12-13 8:12 ` hch
2021-12-13 9:28 ` Sagi Grimberg
2021-12-14 3:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209173213.14249-1-alan.adamson@oracle.com \
--to=alan.adamson@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox