From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Alan Adamson <alan.adamson@oracle.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 1/1] nvme: Add verbose error logging
Date: Fri, 10 Dec 2021 10:54:45 -0500 [thread overview]
Message-ID: <yq1mtl8qxc4.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <fc8f5858-3bea-675b-003f-b59059bd5e5a@nvidia.com> (Chaitanya Kulkarni's message of "Fri, 10 Dec 2021 11:36:38 +0000")
Hi Chaitanya!
> Although I always prefer descriptive error messages, I've not seen even
> half of these errors in the field. This will :-
>
> 1. Increase the size of the driver code.
> 2. Require constant patching of the driver code when spec is updated,
> I'm afraid this will turn into churn.
Updating the corresponding list in SCSI hasn't been a big problem.
> Also, we can easily track down the error in the NVMe spec from the
> error code that driver is printing currently, is that not sufficient ?
Only the block layer status is captured.
In addition, customers are not really armed with the NVMe error decoder
ring and are left with no explanation as to why an I/O failed. We have
had good results in the field with the verbose SCSI error logging and
that's why this patch was modeled to work the same way.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-12-10 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 17:32 [PATCH 0/1] nvme: Add verbose error logging Alan Adamson
2021-12-09 17:32 ` [PATCH 1/1] " Alan Adamson
2021-12-10 11:36 ` Chaitanya Kulkarni
2021-12-10 15:54 ` Martin K. Petersen [this message]
2021-12-10 16:56 ` Keith Busch
2021-12-12 9:52 ` Sagi Grimberg
2021-12-13 8:09 ` Chaitanya Kulkarni
2021-12-14 0:31 ` Alan Adamson
2021-12-13 8:12 ` hch
2021-12-13 9:28 ` Sagi Grimberg
2021-12-14 3:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mtl8qxc4.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=alan.adamson@oracle.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox