Re: [PATCH 1/1] nvme: Add verbose error logging

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

Alan,

On 12/9/21 9:32 AM, Alan Adamson wrote:
> Enable more verbose reporting of NVMe errors. The kernel needs to be compiled
> with the NVME_VERBOSE_ERRORS kernel config option enabled.
> 
> Logged error example:
> 
> nvme0n1: Read @ LBA 2304, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR
> 
> Signed-off-by: Alan Adamson <alan.adamson@oracle.com>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
> ---

Although I always prefer descriptive error messages, I've not seen even
half of these errors in the field. This will :-

1. Increase the size of the driver code.
2. Require constant patching of the driver code when spec is updated,
    I'm afraid this will turn into churn.

Also, we can easily track down the error in the NVMe spec from the error
code that driver is printing currently, is that not sufficient ?
if not please provide a scenario, we can always improve bare minimum
error logging.

-ck