From: "hch@lst.de" <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Alan Adamson <alan.adamson@oracle.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 1/1] nvme: Add verbose error logging
Date: Mon, 13 Dec 2021 09:12:17 +0100 [thread overview]
Message-ID: <20211213081217.GA21297@lst.de> (raw)
In-Reply-To: <20211210165648.GB3856533@dhcp-10-100-145-180.wdc.com>
On Fri, Dec 10, 2021 at 08:56:48AM -0800, Keith Busch wrote:
> I'm not sure having it be a new Kconfig option is a good idea since it
> requires a recompile to enable/disable. Could this be toggled with a
> static_key instead so we may disable/enable verbose logging at runtime?
We need to think about module size. NVMe is not only used in big
enterprise setups but also in deeply embedded scenarious these days.
I'm also not really convince of the usefulness (but also not strictly
againt it), but if we support it it needs to be conditional.
next prev parent reply other threads:[~2021-12-13 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 17:32 [PATCH 0/1] nvme: Add verbose error logging Alan Adamson
2021-12-09 17:32 ` [PATCH 1/1] " Alan Adamson
2021-12-10 11:36 ` Chaitanya Kulkarni
2021-12-10 15:54 ` Martin K. Petersen
2021-12-10 16:56 ` Keith Busch
2021-12-12 9:52 ` Sagi Grimberg
2021-12-13 8:09 ` Chaitanya Kulkarni
2021-12-14 0:31 ` Alan Adamson
2021-12-13 8:12 ` hch [this message]
2021-12-13 9:28 ` Sagi Grimberg
2021-12-14 3:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213081217.GA21297@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox