From: Chao Leng <lengchao@huawei.com>
To: <linux-nvme@lists.infradead.org>
Cc: <hch@lst.de>, <sagi@grimberg.me>, <kbusch@kernel.org>,
<lengchao@huawei.com>
Subject: [PATCH] nvme-rdma: set ack timeout of RoCE to 262ms
Date: Fri, 19 Aug 2022 15:58:25 +0800 [thread overview]
Message-ID: <20220819075825.21231-1-lengchao@huawei.com> (raw)
Now the ack timeout of RoCE is 2 second(2^(18+1)*4us=2 second). In the
case of low concurrency, if some packets lost due to network abnormal
such as network rerouting, Optical fiber signal interference, etc,
it will wait 2 second to try retransmitting the lost packets.
As a result, the I/O latency is greater than 2 seconds.
The I/O latency is so long for real-time transaction service. Indeed we
do not have to wait so long time to make sure that packets are lost.
Setting the ack timeout to 262ms(2^(15+1)*4us=262ms) is sufficient.
Signed-off-by: Chao Leng <lengchao@huawei.com>
---
drivers/nvme/host/rdma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 7d01fb770284..2dbb1b21acc8 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -602,6 +602,8 @@ static int nvme_rdma_alloc_queue(struct nvme_rdma_ctrl *ctrl,
ret = PTR_ERR(queue->cm_id);
goto out_destroy_mutex;
}
+ /* set ack timeout to 262ms(2^(15+1)*4us=262ms) */
+ rdma_set_ack_timeout(queue->cm_id, 15);
if (ctrl->ctrl.opts->mask & NVMF_OPT_HOST_TRADDR)
src_addr = (struct sockaddr *)&ctrl->src_addr;
--
2.16.4
next reply other threads:[~2022-08-19 7:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 7:58 Chao Leng [this message]
2022-08-21 6:20 ` [PATCH] nvme-rdma: set ack timeout of RoCE to 262ms Christoph Hellwig
2022-08-22 9:50 ` Chao Leng
2022-08-22 15:30 ` Max Gurtovoy
2022-08-25 9:58 ` Chao Leng
2022-08-28 14:57 ` Sagi Grimberg
2022-08-29 8:05 ` Chao Leng
2022-08-29 9:06 ` Sagi Grimberg
2022-08-29 13:15 ` Chao Leng
2022-10-10 9:12 ` Chao Leng
2022-10-14 0:05 ` Max Gurtovoy
2022-10-14 2:15 ` Chao Leng
2022-11-16 2:24 ` Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819075825.21231-1-lengchao@huawei.com \
--to=lengchao@huawei.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox