From: hare@kernel.org
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Pankaj Raghav <kernel@pankajraghav.com>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 3/5] block/bdev: lift restrictions on supported blocksize
Date: Fri, 10 May 2024 12:29:04 +0200 [thread overview]
Message-ID: <20240510102906.51844-4-hare@kernel.org> (raw)
In-Reply-To: <20240510102906.51844-1-hare@kernel.org>
From: Hannes Reinecke <hare@suse.de>
We now can support blocksizes larger than PAGE_SIZE, so lift
the restriction.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
block/bdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/bdev.c b/block/bdev.c
index b8e32d933a63..d37aa51b99ed 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -146,8 +146,8 @@ static void set_init_blocksize(struct block_device *bdev)
int set_blocksize(struct block_device *bdev, int size)
{
- /* Size must be a power of two, and between 512 and PAGE_SIZE */
- if (size > PAGE_SIZE || size < 512 || !is_power_of_2(size))
+ /* Size must be a power of two, and larger than 512 */
+ if (size < 512 || !is_power_of_2(size))
return -EINVAL;
/* Size cannot be smaller than the size supported by the device */
@@ -170,7 +170,7 @@ int sb_set_blocksize(struct super_block *sb, int size)
if (set_blocksize(sb->s_bdev, size))
return 0;
/* If we get here, we know size is power of two
- * and it's value is between 512 and PAGE_SIZE */
+ * and it's value is larger than 512 */
sb->s_blocksize = size;
sb->s_blocksize_bits = blksize_bits(size);
return sb->s_blocksize;
--
2.35.3
next prev parent reply other threads:[~2024-05-10 10:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:29 [PATCH 0/5] enable bs > ps for block devices hare
2024-05-10 10:29 ` [PATCH 1/5] fs/mpage: use blocks_per_folio instead of blocks_per_page hare
2024-05-10 22:19 ` Matthew Wilcox
2024-05-11 9:12 ` Hannes Reinecke
2024-05-10 10:29 ` [PATCH 2/5] fs/mpage: avoid negative shift for large blocksize hare
2024-05-10 22:24 ` Matthew Wilcox
2024-05-11 9:13 ` Hannes Reinecke
2024-05-10 10:29 ` hare [this message]
2024-05-10 22:25 ` [PATCH 3/5] block/bdev: lift restrictions on supported blocksize Matthew Wilcox
2024-05-11 9:15 ` Hannes Reinecke
2024-05-11 22:57 ` Luis Chamberlain
2024-05-11 22:54 ` Luis Chamberlain
2024-05-10 10:29 ` [PATCH 4/5] block/bdev: enable large folio support for large logical block sizes hare
2024-05-10 22:35 ` Matthew Wilcox
2024-05-11 9:18 ` Hannes Reinecke
2024-05-11 5:07 ` kernel test robot
2024-05-11 7:04 ` kernel test robot
2024-05-10 10:29 ` [PATCH 5/5] nvme: enable logical block size > PAGE_SIZE hare
2024-05-10 22:37 ` Matthew Wilcox
2024-05-11 9:18 ` Hannes Reinecke
2024-05-11 23:11 ` Luis Chamberlain
2024-05-11 23:09 ` Luis Chamberlain
2024-05-11 23:30 ` Matthew Wilcox
2024-05-11 23:51 ` Luis Chamberlain
2024-05-12 2:43 ` Luis Chamberlain
2024-05-12 9:16 ` Luis Chamberlain
2024-05-13 16:07 ` Hannes Reinecke
2024-05-13 21:05 ` Luis Chamberlain
2024-05-13 23:07 ` Hannes Reinecke
2024-05-24 10:04 ` Hannes Reinecke
2024-05-14 5:08 ` Matthew Wilcox
2024-05-13 13:43 ` Hannes Reinecke
2024-05-13 14:32 ` Luis Chamberlain
2024-05-11 23:12 ` [PATCH 0/5] enable bs > ps for block devices Luis Chamberlain
2024-05-30 13:37 ` Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510102906.51844-4-hare@kernel.org \
--to=hare@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.de \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox