From: Hannes Reinecke <hare@suse.de>
To: Matthew Wilcox <willy@infradead.org>, hare@kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pankaj Raghav <kernel@pankajraghav.com>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/5] fs/mpage: avoid negative shift for large blocksize
Date: Sat, 11 May 2024 11:13:15 +0200 [thread overview]
Message-ID: <3e6bbc4a-c1ed-4460-a266-3d4b0fdbb9c6@suse.de> (raw)
In-Reply-To: <Zj6ehjm1iVcc_x2m@casper.infradead.org>
On 5/11/24 00:24, Matthew Wilcox wrote:
> On Fri, May 10, 2024 at 12:29:03PM +0200, hare@kernel.org wrote:
>> - block_in_file = (sector_t)folio->index << (PAGE_SHIFT - blkbits);
>> + block_in_file = (sector_t)(((loff_t)folio->index << PAGE_SHIFT) >> blkbits);
>
> block_in_file = folio_pos(folio) >> blkbits;
>
>
I know there was a better way. Will be fixing it up.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2024-05-11 9:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:29 [PATCH 0/5] enable bs > ps for block devices hare
2024-05-10 10:29 ` [PATCH 1/5] fs/mpage: use blocks_per_folio instead of blocks_per_page hare
2024-05-10 22:19 ` Matthew Wilcox
2024-05-11 9:12 ` Hannes Reinecke
2024-05-10 10:29 ` [PATCH 2/5] fs/mpage: avoid negative shift for large blocksize hare
2024-05-10 22:24 ` Matthew Wilcox
2024-05-11 9:13 ` Hannes Reinecke [this message]
2024-05-10 10:29 ` [PATCH 3/5] block/bdev: lift restrictions on supported blocksize hare
2024-05-10 22:25 ` Matthew Wilcox
2024-05-11 9:15 ` Hannes Reinecke
2024-05-11 22:57 ` Luis Chamberlain
2024-05-11 22:54 ` Luis Chamberlain
2024-05-10 10:29 ` [PATCH 4/5] block/bdev: enable large folio support for large logical block sizes hare
2024-05-10 22:35 ` Matthew Wilcox
2024-05-11 9:18 ` Hannes Reinecke
2024-05-11 5:07 ` kernel test robot
2024-05-11 7:04 ` kernel test robot
2024-05-10 10:29 ` [PATCH 5/5] nvme: enable logical block size > PAGE_SIZE hare
2024-05-10 22:37 ` Matthew Wilcox
2024-05-11 9:18 ` Hannes Reinecke
2024-05-11 23:11 ` Luis Chamberlain
2024-05-11 23:09 ` Luis Chamberlain
2024-05-11 23:30 ` Matthew Wilcox
2024-05-11 23:51 ` Luis Chamberlain
2024-05-12 2:43 ` Luis Chamberlain
2024-05-12 9:16 ` Luis Chamberlain
2024-05-13 16:07 ` Hannes Reinecke
2024-05-13 21:05 ` Luis Chamberlain
2024-05-13 23:07 ` Hannes Reinecke
2024-05-24 10:04 ` Hannes Reinecke
2024-05-14 5:08 ` Matthew Wilcox
2024-05-13 13:43 ` Hannes Reinecke
2024-05-13 14:32 ` Luis Chamberlain
2024-05-11 23:12 ` [PATCH 0/5] enable bs > ps for block devices Luis Chamberlain
2024-05-30 13:37 ` Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e6bbc4a-c1ed-4460-a266-3d4b0fdbb9c6@suse.de \
--to=hare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hare@kernel.org \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox