From: Christoph Hellwig <hch@lst.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
Lawrence Troup <ltroup@cisco.com>
Subject: Re: [PATCH V3] nvme-pci: allow unmanaged interrupts
Date: Tue, 16 Jul 2024 06:29:55 +0200 [thread overview]
Message-ID: <20240716042955.GA25427@lst.de> (raw)
In-Reply-To: <ZpVINh3BA88U6KEc@tpad>
On Mon, Jul 15, 2024 at 01:03:02PM -0300, Marcelo Tosatti wrote:
> What if you set "static bool managed_irqs" to false when isolcpus is being used?
>
> For example:
>
> if (housekeeping_enabled(HK_TYPE_MANAGED_IRQ))
> managed_irqs = false;
>
> Then there is no additional parameter to tune (which addresses
> Christoph's concern).
No, it absolutely does not. We need to still properly spread the irqs
using the proper managed irq setup, we just need to do it only on the
CPUs they should be spread on.
prev parent reply other threads:[~2024-07-16 4:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 10:41 [PATCH V3] nvme-pci: allow unmanaged interrupts Ming Lei
2024-07-02 11:50 ` Christoph Hellwig
2024-07-02 12:12 ` Ming Lei
2024-07-02 12:20 ` Lawrence Troup (ltroup)
2024-07-02 15:28 ` Christoph Hellwig
2024-07-03 1:57 ` Ming Lei
2024-07-03 5:24 ` Christoph Hellwig
2024-07-02 16:28 ` Daniel Wagner
2024-07-03 1:51 ` Ming Lei
2024-07-16 10:18 ` Hannes Reinecke
2024-07-15 16:03 ` Marcelo Tosatti
2024-07-15 16:23 ` Marcelo Tosatti
2024-07-16 4:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716042955.GA25427@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ltroup@cisco.com \
--cc=ming.lei@redhat.com \
--cc=mtosatti@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox