Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
	linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
	Lawrence Troup <ltroup@cisco.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	ming.lei@redhat.com
Subject: Re: [PATCH V3] nvme-pci: allow unmanaged interrupts
Date: Tue, 2 Jul 2024 20:12:11 +0800	[thread overview]
Message-ID: <ZoPum7MPTuA6/t7O@fedora> (raw)
In-Reply-To: <20240702115002.GA16219@lst.de>

On Tue, Jul 02, 2024 at 01:50:02PM +0200, Christoph Hellwig wrote:
> On Tue, Jul 02, 2024 at 06:41:12PM +0800, Ming Lei wrote:
> > From: Keith Busch <kbusch@kernel.org>
> > 
> > People _really_ want to control their interrupt affinity in some
> > cases, such as Openshift with Performance profile, in which each
> > irq's affinity is completely specified from userspace. Turns out
> > that 'isolcpus=managed_irqs' isn't enough.
> > 
> > Add module parameter to allow unmanaged interrupts, just as some
> > SCSI drivers are doing.
> 
> Same as before: hell no.  We can't just add hacky global kernel
> parameters everywhere.  We need the cpu isolation infrastructure to
> work properly instead of piling hacks of hacks in every relevant driver.

Per my understanding, here cpu isolation infrastructure can't work for
Openshift, in which IO workload can be run on applications which are executed
on isolated CPUs, meantime userspace do expect that interrupts can be
triggered on user-specified CPU cores only in controllable way.  

Marcelo and Lawrence may have more input in this area.

Also irq allocation really belongs to device & driver stuff, how can that be
hack? We even may not abstract public API in block layer for handling
irq related thing.


Thanks, 
Ming



  reply	other threads:[~2024-07-02 12:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 10:41 [PATCH V3] nvme-pci: allow unmanaged interrupts Ming Lei
2024-07-02 11:50 ` Christoph Hellwig
2024-07-02 12:12   ` Ming Lei [this message]
2024-07-02 12:20     ` Lawrence Troup (ltroup)
2024-07-02 15:28       ` Christoph Hellwig
2024-07-03  1:57         ` Ming Lei
2024-07-03  5:24           ` Christoph Hellwig
2024-07-02 16:28     ` Daniel Wagner
2024-07-03  1:51       ` Ming Lei
2024-07-16 10:18         ` Hannes Reinecke
2024-07-15 16:03 ` Marcelo Tosatti
2024-07-15 16:23   ` Marcelo Tosatti
2024-07-16  4:29   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoPum7MPTuA6/t7O@fedora \
    --to=ming.lei@redhat.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ltroup@cisco.com \
    --cc=mtosatti@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox