Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Lawrence Troup (ltroup)" <ltroup@cisco.com>,
	Keith Busch <kbusch@kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Franck Baudin <fbaudin@redhat.com>
Subject: Re: [PATCH V3] nvme-pci: allow unmanaged interrupts
Date: Wed, 3 Jul 2024 09:57:29 +0800	[thread overview]
Message-ID: <ZoSwCeZZIiQqisYG@fedora> (raw)
In-Reply-To: <20240702152809.GA32373@lst.de>

On Tue, Jul 02, 2024 at 05:28:09PM +0200, Christoph Hellwig wrote:
> On Tue, Jul 02, 2024 at 12:20:30PM +0000, Lawrence Troup (ltroup) wrote:
> > Openshift needs the ability to dynamically move IRQs of all drivers away from a specific set of CPUs, at the point that an isolated workload starts running on those CPUs, and requires high performance guarantees, i.e. no HW interrupts to occur. To achieve this, dynamic setting of the smp_affinity for all drivers is used - at the moment, the NVME driver does not support this, so the NVME IRQs remain running on CPUs they should not be on, and so impact performance of the isolated workload.
> 
> Then you need to create a core kernel interface that moves all managed
> IRQs of these CPUs.

It is basically not doable or too hard since blk-mq queue mapping
depends on managed irq affinity.

> Without that you have a never ending whack a mole
> adding hacks to the drivers of the day that you care about.

So far, most popular SCSI hosts support the option via module parameter, and
the only remainder could be nvme-pci.


Thanks, 
Ming



  reply	other threads:[~2024-07-03  1:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 10:41 [PATCH V3] nvme-pci: allow unmanaged interrupts Ming Lei
2024-07-02 11:50 ` Christoph Hellwig
2024-07-02 12:12   ` Ming Lei
2024-07-02 12:20     ` Lawrence Troup (ltroup)
2024-07-02 15:28       ` Christoph Hellwig
2024-07-03  1:57         ` Ming Lei [this message]
2024-07-03  5:24           ` Christoph Hellwig
2024-07-02 16:28     ` Daniel Wagner
2024-07-03  1:51       ` Ming Lei
2024-07-16 10:18         ` Hannes Reinecke
2024-07-15 16:03 ` Marcelo Tosatti
2024-07-15 16:23   ` Marcelo Tosatti
2024-07-16  4:29   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoSwCeZZIiQqisYG@fedora \
    --to=ming.lei@redhat.com \
    --cc=fbaudin@redhat.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ltroup@cisco.com \
    --cc=mtosatti@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox