* [PATCH] nvme-fabrics: fix returnvar.cocci warnings [not found] <202201221116.hWZkKqts-lkp@intel.com> @ 2022-01-22 3:17 ` kernel test robot 2022-01-22 4:27 ` Chaitanya Kulkarni 2022-01-23 9:16 ` Sagi Grimberg 0 siblings, 2 replies; 6+ messages in thread From: kernel test robot @ 2022-01-22 3:17 UTC (permalink / raw) To: Hannes Reinecke Cc: kbuild-all, linux-kernel, Christoph Hellwig, Chaitanya Kulkarni, Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme From: kernel test robot <lkp@intel.com> drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke <hare@suse.de> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9b57f458985742bd1c585f4c7f36d04634ce1143 commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 13 hours ago :::::: commit date: 4 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-fabrics: fix returnvar.cocci warnings 2022-01-22 3:17 ` [PATCH] nvme-fabrics: fix returnvar.cocci warnings kernel test robot @ 2022-01-22 4:27 ` Chaitanya Kulkarni 2022-01-23 9:16 ` Sagi Grimberg 1 sibling, 0 replies; 6+ messages in thread From: Chaitanya Kulkarni @ 2022-01-22 4:27 UTC (permalink / raw) To: kernel test robot, Hannes Reinecke Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig, Chaitanya Kulkarni, Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme@lists.infradead.org On 1/21/22 19:17, kernel test robot wrote: > External email: Use caution opening links or attachments > > > From: kernel test robot <lkp@intel.com> > > drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") > CC: Hannes Reinecke <hare@suse.de> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > --- Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-fabrics: fix returnvar.cocci warnings 2022-01-22 3:17 ` [PATCH] nvme-fabrics: fix returnvar.cocci warnings kernel test robot 2022-01-22 4:27 ` Chaitanya Kulkarni @ 2022-01-23 9:16 ` Sagi Grimberg 1 sibling, 0 replies; 6+ messages in thread From: Sagi Grimberg @ 2022-01-23 9:16 UTC (permalink / raw) To: kernel test robot, Hannes Reinecke Cc: kbuild-all, linux-kernel, Christoph Hellwig, Chaitanya Kulkarni, Keith Busch, Jens Axboe, linux-nvme Reviewed-by: Sagi Grimberg <sagi@grimberg.me> ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <202201260046.otELTDdH-lkp@intel.com>]
* [PATCH] nvme-fabrics: fix returnvar.cocci warnings [not found] <202201260046.otELTDdH-lkp@intel.com> @ 2022-01-25 16:12 ` kernel test robot 0 siblings, 0 replies; 6+ messages in thread From: kernel test robot @ 2022-01-25 16:12 UTC (permalink / raw) To: Hannes Reinecke Cc: kbuild-all, linux-kernel, Christoph Hellwig, Chaitanya Kulkarni, Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme From: kernel test robot <lkp@intel.com> drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke <hare@suse.de> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a08b41ab9e2e468647f78eb17c28e29b93006394 commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 10 hours ago :::::: commit date: 5 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file) ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <202201181710.TjfwKXN9-lkp@intel.com>]
* [PATCH] nvme-fabrics: fix returnvar.cocci warnings [not found] <202201181710.TjfwKXN9-lkp@intel.com> @ 2022-01-18 9:25 ` kernel test robot 2022-01-19 7:40 ` Chaitanya Kulkarni 0 siblings, 1 reply; 6+ messages in thread From: kernel test robot @ 2022-01-18 9:25 UTC (permalink / raw) To: Hannes Reinecke Cc: kbuild-all, linux-kernel, Christoph Hellwig, Chaitanya Kulkarni, Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme From: kernel test robot <lkp@intel.com> drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke <hare@suse.de> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e3a8b6a1e70c37702054ae3c7c07ed828435d8ee commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 5 hours ago :::::: commit date: 4 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-fabrics: fix returnvar.cocci warnings 2022-01-18 9:25 ` kernel test robot @ 2022-01-19 7:40 ` Chaitanya Kulkarni 0 siblings, 0 replies; 6+ messages in thread From: Chaitanya Kulkarni @ 2022-01-19 7:40 UTC (permalink / raw) To: kernel test robot, Hannes Reinecke Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig, Chaitanya Kulkarni, Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme@lists.infradead.org On 1/18/22 1:25 AM, kernel test robot wrote: > External email: Use caution opening links or attachments > > > From: kernel test robot <lkp@intel.com> > > drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") > CC: Hannes Reinecke <hare@suse.de> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > --- > Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-25 16:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202201221116.hWZkKqts-lkp@intel.com>
2022-01-22 3:17 ` [PATCH] nvme-fabrics: fix returnvar.cocci warnings kernel test robot
2022-01-22 4:27 ` Chaitanya Kulkarni
2022-01-23 9:16 ` Sagi Grimberg
[not found] <202201260046.otELTDdH-lkp@intel.com>
2022-01-25 16:12 ` kernel test robot
[not found] <202201181710.TjfwKXN9-lkp@intel.com>
2022-01-18 9:25 ` kernel test robot
2022-01-19 7:40 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox