Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Shrihari E S <shrihari.s@samsung.com>
To: Junjie Cao <junjie.cao@intel.com>
Cc: jic23@kernel.org, mst@redhat.com, marcel.apfelbaum@gmail.com,
	dave@stgolabs.net, arun.george@samsung.com,
	dongjoo.seo1@samsung.com, s.neeraj@samsung.com,
	vikash.k5@samsung.com, cpgs@samsung.com, gost.dev@samsung.com,
	linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org,
	qemu-devel@nongnu.org
Subject: Re: [RFC V2 0/9] hw/pci: hw/cxl: Add UIO support in CXL and PCIe stack.
Date: Thu, 10 Sep 2026 13:52:50 +0530	[thread overview]
Message-ID: <1742920067.01789064282454.JavaMail.epsvc@epcpadp2new> (raw)
In-Reply-To: <20260830071953.399414-1-junjie.cao@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

On 30/08/26 03:19PM, Junjie Cao wrote:
>Hi Shrihari,
>
>On Wed, 26 Aug 2026 11:04:00 +0530, Shrihari E S wrote:
>> This series is written on top of:
>>
>> Base commit: 3c99db7705c1a885c795b7c14f751c7a3ba29ed8
>> Repository: https://gitlab.com/jic23/qemu
>> Branch: cxl-2026-01-09-draft
>
>Applies clean there and builds; x86_64 cxl-test still passes.  I
>booted the patch-10 example topology and walked the extended
>capability chains and the HDM decoder registers: the v1 SVC/AER
>collision is fixed.  Two things are broken, both on 7/10: the
>switch USP never advertises HDM UIO -- its uio gate reads a flitmode
>field that nothing sets -- so the example topology can't advertise UIO
>end to end, and "-device ioh3420,x-svc=on" aborts QEMU.  Per-patch
>comments on 2, 3 and 5 through 10.
>
>Testing point 3 looks at whether existing configurations still work;
>the compat question is whether they still look the same to a guest.
>2/10 moves x-256b-flit onto pcie-root-port with the default left on,
>so every pcie-root-port on q35 comes up in flit mode with no compat
>entry -- an inbound migration already fails at that patch, I tried
>it -- and 7/10 shifts the CXL DVSEC offsets whether or not x-svc is set.
>
>Worth adding the PCI maintainers on v3 -- eight of the ten patches
>touch files under their entry, and both new capabilities land in
>hw/pci.
>
>I'll re-run the topology once the USP gate is settled.
>
>Many thanks,
>Junjie

Hi Junjie,

Thank you for the detailed review and testing. Your feedback helped
catch several issues that were missing in this patch series
(particularly the derived ports abort scenario). Will address your
comments in the next version of this patch series.

Thanks and regards,
Shrihari


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2026-09-10 18:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260826051958epcas5p3db6cf2ef9115168c5d8dcec7bdb9b8c3@epcas5p3.samsung.com>
2026-08-26  5:34 ` [RFC V2 0/9] hw/pci: hw/cxl: Add UIO support in CXL and PCIe stack Shrihari E S
2026-08-30  7:19   ` Junjie Cao
2026-09-10  8:22     ` Shrihari E S [this message]
     [not found] <CGME20260826052014epcas5p11846c6a40fcec4ec4ba441ceb26e5dcc@epcas5p1.samsung.com>
     [not found] ` <20260826053410.1322176-1-shrihari.s@samsung.com>
2026-08-26  5:34   ` [RFC V2 01/10] hw/pci: Refactor flitmode from PCIESlot to PCIEPort Shrihari E S
2026-08-26  5:34   ` [RFC V2 02/10] hw/pci: Move 'x-256b-flit' property from cxl_root_port to pcie_root_port Shrihari E S
2026-08-30  7:20     ` Junjie Cao
2026-08-26  5:34   ` [RFC V2 03/10] hw/pci: Add SVC capability and UIO properties to PCIe ports Shrihari E S
2026-08-30  7:20     ` Junjie Cao
2026-08-26  5:34   ` [RFC V2 04/10] hw/cxl: Add Streamlined Virtual Channel (SVC) property to CXL ports Shrihari E S
2026-08-26  5:34   ` [RFC V2 05/10] hw/cxl: Wire UIO capability into HDM decoder and DVSEC registers Shrihari E S
2026-08-30  7:21     ` Junjie Cao
2026-09-10  9:37       ` Shrihari E S
2026-08-26  5:34   ` [RFC V2 06/10] hw/pci: Add PCIe Streamlined Virtual Channel (SVC) capability Shrihari E S
2026-08-30  7:21     ` Junjie Cao
2026-09-10  8:40       ` Shrihari E S
2026-08-26  5:34   ` [RFC V2 07/10] hw/pci: hw/cxl: Wire SVC initialization into port realize functions Shrihari E S
2026-08-30  7:22     ` Junjie Cao
2026-08-26  5:34   ` [RFC V2 08/10] hw/pci: Add PCIe Device3 capability support Shrihari E S
2026-08-30  7:22     ` Junjie Cao
2026-08-26  5:34   ` [RFC V2 09/10] hw/cxl: Wire SVC and Dev3 capability to CXL Type 3 device Shrihari E S
2026-08-30  7:23     ` Junjie Cao
2026-08-26  5:34   ` [RFC V2 10/10] cxl: Add documentation for CXL UIO support Shrihari E S
2026-08-30  7:23     ` Junjie Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1742920067.01789064282454.JavaMail.epsvc@epcpadp2new \
    --to=shrihari.s@samsung.com \
    --cc=arun.george@samsung.com \
    --cc=cpgs@samsung.com \
    --cc=dave@stgolabs.net \
    --cc=dongjoo.seo1@samsung.com \
    --cc=gost.dev@samsung.com \
    --cc=jic23@kernel.org \
    --cc=junjie.cao@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=s.neeraj@samsung.com \
    --cc=vikash.k5@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox